From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Reza Nikoopour Newsgroups: gmane.emacs.bugs Subject: bug#47105: defface docs Date: Fri, 12 Mar 2021 08:53:18 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000046085705bd59bdcb" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16221"; mail-complaints-to="usenet@ciao.gmane.io" To: 47105@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 12 18:05:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKlEX-00045o-39 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 18:05:53 +0100 Original-Received: from localhost ([::1]:44230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKlEW-0001YY-2R for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 12:05:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKl8s-0005KO-NA for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 12:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKl8s-0005Sa-9y for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 12:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKl8s-0000ZV-4J for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 12:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reza Nikoopour Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 17:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47105 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16155683842122 (code B ref -1); Fri, 12 Mar 2021 17:00:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Mar 2021 16:59:44 +0000 Original-Received: from localhost ([127.0.0.1]:58250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKl8Y-0000Y5-0V for submit@debbugs.gnu.org; Fri, 12 Mar 2021 11:59:44 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKl2h-0000PO-1x for submit@debbugs.gnu.org; Fri, 12 Mar 2021 11:53:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKl2g-0000DZ-ED for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 11:53:38 -0500 Original-Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]:44742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKl2Y-0002Az-Tz for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 11:53:38 -0500 Original-Received: by mail-io1-xd33.google.com with SMTP id 81so26394340iou.11 for ; Fri, 12 Mar 2021 08:53:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=FXssOZprSX7T7Np+Vl6TAYt7cidD+/zJv6RNvH5YbNc=; b=epC+Js9o+bRKVIfnrVC2xZDyy1CZWRqjh3VmVLRbyDStzs0TAwhPPF+xGEoVXBxC7l 93KVOOzHvbrvkMQQtMzFUoTYjTEGXGYnbVOYAI1cRyZgXi1n2yg89eCxcvvKJHAJgGpF 5QN4NtmfLwBGXJTPiJFRTQyWuTsU+8ekdJB+Do1RwGnDoQ+dhRdPSaBmzRMMUD+zUFzI poVkG/Lbr6S/aZ6OFpzGeG0dFVfMe0g4jq3RR0KWVfHKHapvaidsLARbNcmSoTLnxjPb ZuUATiIZfuV+UXLD7jHxV5Xef+X3fhvRiz72+atBuu1yHnL+lalwoMQDQZ2Q2UgNYgwZ CgEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=FXssOZprSX7T7Np+Vl6TAYt7cidD+/zJv6RNvH5YbNc=; b=S7DxiuF+JMrgxTPjq5D76vN+6mm7fPwg6ka3hjIjRLSHdD1YSFxV6osIeLnuwjNPIs eIrcfKf2KagtybviUjKAQuTflxIcHf/N3ucmyzen4bTTZxiV1PlnJB2AkTIvzOKjE6OD Mhg1JKXD9Ug2dQWzvsGIYEAsC0mNSCZp4Z7Mph3uzsAUN7PUdTkmiIaiVywRhpZU+c00 +MeqicZ9CAnc5Z+06oFMV0Ri4+FuU7Hpe274rVbw4xr8e1YTR3DEefBS9qUnN+lZ9KTH 5VszBXe6zq5qG4lvzdVmWc5sd4RbubSHWaLqCnmyDChzfa4ScWcNzsU3THrwQhYS/G+k KJvg== X-Gm-Message-State: AOAM531CaLqnmDV6n7OL1uK/DzUMKY0/9w8MZTqK53Bh3HsxAwvU2nPq bhA4tWQY2sL5FVTPMMQmkMt+uwmyCv2mqiZycgEVyWY3poU= X-Google-Smtp-Source: ABdhPJwers3q9eh29xirpiuktJrq4DDEgEVjEWwK5ufQp/ZvLj82JPh75cuiKIZoYU9r3sBkWCqh4n8m5gtVBc3nR1k= X-Received: by 2002:a5e:8d09:: with SMTP id m9mr118284ioj.29.1615568008774; Fri, 12 Mar 2021 08:53:28 -0800 (PST) Received-SPF: pass client-ip=2607:f8b0:4864:20::d33; envelope-from=rnikoopour@gmail.com; helo=mail-io1-xd33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 12 Mar 2021 11:59:40 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202178 Archived-At: --00000000000046085705bd59bdcb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I've been reading the docs in the emacs manual about defface: https://www.gnu.org/software/emacs/manual/html_node/elisp/Defining-Faces.ht= ml I had a question about the following two conventions People are sometimes tempted to create a variable whose value is a face > name. In the vast majority of cases, this is not necessary; the usual > procedure is to define a face with defface, and then use its name directl= y. You should not quote the symbol face, and it should not end in =E2=80=98-fa= ce=E2=80=99 > (that would be redundant). I see both of these conventions in font-lock.el. https://github.com/emacs-mirror/emacs/blob/master/lisp/font-lock.el#L318-L3= 19 https://github.com/emacs-mirror/emacs/blob/master/lisp/font-lock.el#L1976-L= 1979 Could the docs be updated to reflect what's happening in font-lock.el? I'd be happy to make the contribution, but I don't know the proper way to suggest an update to the manual. Alternatively, could it be explained why font-lock.el doesn't follow these conventions? Cheers, Reza --00000000000046085705bd59bdcb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I've been reading the docs in the emacs = manual about defface:

I had a question about the following two conventions

People are som= etimes tempted to create a variable whose value is a face name. In the vast= majority of cases, this is not necessary; the usual procedure is to define= a face with defface, and then use its name directly.=C2=A0

You should no= t quote the symbol face, and it should not end in =E2=80=98-face=E2=80=99 (= that would be redundant).

I see both of the= se conventions=C2=A0in font-lock.el.=C2=A0

https://gi= thub.com/emacs-mirror/emacs/blob/master/lisp/font-lock.el#L318-L319
= https://github.com/emacs-mirror/emacs/blob/master/lisp/fon= t-lock.el#L1976-L1979

Could the docs be=C2=A0updated to reflect = what's happening in font-lock.el?=C2=A0 I'd be happy to make the co= ntribution, but I don't know the proper way to suggest an update to the= manual.

Alternatively, could it be explained why = font-lock.el doesn't follow these conventions?

Cheers,
Reza --00000000000046085705bd59bdcb--