From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tim Van Holder Newsgroups: gmane.emacs.bugs Subject: bug#18975: 24.4; vc-svn does not recognize file externals as svn-managed files Date: Fri, 7 Nov 2014 19:44:03 +0100 Message-ID: References: <87egtga41b.fsf@leeloo.anubex.internal> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b15a2976f1ee7050749325c X-Trace: ger.gmane.org 1415385924 17831 80.91.229.3 (7 Nov 2014 18:45:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Nov 2014 18:45:24 +0000 (UTC) Cc: 18975@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 07 19:45:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XmoX6-0008Qt-Mc for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Nov 2014 19:45:16 +0100 Original-Received: from localhost ([::1]:33436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmoX6-0002cm-8v for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Nov 2014 13:45:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmoWy-0002Zw-BZ for bug-gnu-emacs@gnu.org; Fri, 07 Nov 2014 13:45:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmoWs-0002IF-Le for bug-gnu-emacs@gnu.org; Fri, 07 Nov 2014 13:45:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmoWs-0002Hm-I5 for bug-gnu-emacs@gnu.org; Fri, 07 Nov 2014 13:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XmoWr-0004Us-WA for bug-gnu-emacs@gnu.org; Fri, 07 Nov 2014 13:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tim Van Holder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Nov 2014 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18975-submit@debbugs.gnu.org id=B18975.141538584817198 (code B ref 18975); Fri, 07 Nov 2014 18:45:01 +0000 Original-Received: (at 18975) by debbugs.gnu.org; 7 Nov 2014 18:44:08 +0000 Original-Received: from localhost ([127.0.0.1]:53115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XmoVz-0004TJ-8q for submit@debbugs.gnu.org; Fri, 07 Nov 2014 13:44:07 -0500 Original-Received: from mail-pa0-f53.google.com ([209.85.220.53]:60543) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XmoVw-0004TA-LU for 18975@debbugs.gnu.org; Fri, 07 Nov 2014 13:44:05 -0500 Original-Received: by mail-pa0-f53.google.com with SMTP id kx10so4033610pab.12 for <18975@debbugs.gnu.org>; Fri, 07 Nov 2014 10:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/UKt0hRyThYcvuNZgMffNQS/STbxEuTuXu6gX16opeA=; b=ox0kOdJZd3UP2JPpHWhBe97bZA4sFV2yGGDlWm9Xj9f4M/zQ1ZEWAlCluwdCoebWM2 GR1grfbEIxJmWsAVDy97uLG+N8FYNCKW98CvpLsX4Csswn85xrcKVwmkc1PHLtuIAwBF sgpiSTWv6s1b6TK2ArEQVmkGhhWII4bUwukHuaKRmyCMuANjgQSfOGS/6LHrljxSWiUa Wd5weNfnNV6w3iD5E7j5cfKEpko0BZkkgwSpi1+MzNhUkUEqkTBwFJ7Lz9fWQeuNnjMP BV7HwMAfxyahyDEn4Pdv16E72YT/x9rHDJSAMcbg1nqblD56NqHlj/lMzVW7YCAYjIzO bWpw== X-Received: by 10.66.234.100 with SMTP id ud4mr14278423pac.36.1415385843701; Fri, 07 Nov 2014 10:44:03 -0800 (PST) Original-Received: by 10.70.49.168 with HTTP; Fri, 7 Nov 2014 10:44:03 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95679 --047d7b15a2976f1ee7050749325c Content-Type: text/plain; charset=UTF-8 On 6 November 2014 16:46, Stefan Monnier wrote: > > I added a file external to an SVN tree. > > I haven't used SVN is many years and have never had to use its externals > support, so I'm not really sure exactly what it does and even less how > it should be supported in VC. > SVN has two types of externals (both set via svn:externals properties on directories). Regular externals (supported for a very long time) pull in external SVN trees inside your checkout. Because they get their own .svn root, vc-svn handles these just fine. File externals (added more recently; in 1.7 I think) allow you to pull in a single file from elsewhere in your repository; sort of the SVN equivalent of a hard link. It is these files that vc-svn does not recognize as svn-controlled right now. > resolves my issue, but I can't be sure it doesn't cause problems > > elsewhere. > > Hopefully someone else knows better, but otherwise I suggest you try to > use this change for a while, testing it with things like > diff/annotate/younameit. > > And then report here if you really think that works better. > Well it makes vc-svn recognize the files as svn-controlled, so it definitely works better :-) I'll see about putting a fixed version in a private load path, so that if it breaks something it doesn't affect all users. --047d7b15a2976f1ee7050749325c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 6= November 2014 16:46, Stefan Monnier <monnier@iro.umontreal.ca&= gt; wrote:
>= I added a file external to an SVN tree.

I haven't used SVN is many years and have never had to use its external= s
support, so I'm not really sure exactly what it does and even less how<= br> it should be supported in VC.

SVN has tw= o types of externals (both set via svn:externals properties on directories)= .
Regular externals (supported for a very long time) pull in external SVN trees insi= de your checkout. Because they get their own .svn root, vc-svn handles these just fine.
File ext= ernals (added more recently; in 1.7 I think) allow you to pull in a single = file from elsewhere in your repository; sort of the SVN equivalent of a har= d link.
It is these files that vc-svn does not recognize as svn-controll= ed right now.



Well it makes vc-svn recognize the files as svn-controlled, so it definite= ly works better :-)
I'll see about putting a fixed versio= n in a private load path, so that if it breaks something it doesn't aff= ect all users.
--047d7b15a2976f1ee7050749325c--