From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jimmy Yuen Ho Wong Newsgroups: gmane.emacs.bugs Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Date: Tue, 4 May 2021 17:15:18 +0100 Message-ID: References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000001e39305c1836376" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5474"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48153@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 04 18:19:02 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldxlG-0001KN-DX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 18:19:02 +0200 Original-Received: from localhost ([::1]:57668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldxlF-0000S0-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 12:19:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldxiO-0007BF-Tm for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 12:16:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldxiM-0006UU-Fp for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 12:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldxiM-00035g-BN for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 12:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162014493811868 (code B ref 48153); Tue, 04 May 2021 16:16:02 +0000 Original-Received: (at 48153) by debbugs.gnu.org; 4 May 2021 16:15:38 +0000 Original-Received: from localhost ([127.0.0.1]:54078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldxhx-00035M-Ux for submit@debbugs.gnu.org; Tue, 04 May 2021 12:15:38 -0400 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:35717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldxhv-00035F-JR for 48153@debbugs.gnu.org; Tue, 04 May 2021 12:15:36 -0400 Original-Received: by mail-lf1-f54.google.com with SMTP id x19so14140486lfa.2 for <48153@debbugs.gnu.org>; Tue, 04 May 2021 09:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XxFu3NAV/idbhwuwLMT7IAxZwvhspYrHEMjMtVBIe7o=; b=YPKqY8YhlQrTg8e13UHTDJeg5aN4VG4xJ8pc5VIHA3EbtTZKWbCX4NYSjLnliERLxl zgKCbxWHCJY0W7HboCYrgnz7MdpqkrP+RJlvSaqUEMl8UsO+gMcehRxyta77zyY2+6C6 xD+pGnrPnaOykWA3qYOBZAzrvwLQ7QY2a4zBn2dvqWKiHPu+8K404MyEHUkmH6Z6V/rw zLtr36fFjT+BVVuQsST3xpNBAK8PywnFrYbOCzpzBqEb4G5yLbBA8pppUnHMF0TexWpv i5NMZNw55V8lHhrzjj2PXd4TO43MMimmypmZFv2BZDUzcbrtDhzYwR+El0qqR1smHe5Y Hcww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XxFu3NAV/idbhwuwLMT7IAxZwvhspYrHEMjMtVBIe7o=; b=i0ebtjHrmL1j0kmu0AQUPruJkJch/TFjB9/2e6NlvWdY68GMqWGZGWwolUwETzMIhY xFwj9lZmB9QR1Xdf4G8hRlkXoZd20sjD1UQsNUS8+WmaR1jMuUrRDT6KIHcePCo7B15C ZAWjIiwM9MutjEY7SPKSEfpWQ5CHL7WWBQfgkCLqFajlynJIko6/06AJim5OUDuXkbgf tQkZfivqG+zy5eNlhc4nrnW4rhX111pOztxF7MvfvoUhJzBgP7M51JBUVXznzJAszGR9 zwDRhFLxD4f6yVil2xxf6iC7DvkyQseFiAAD6hRmT6Bte8CYZ/Tqna+h+2XL+CxVNWLZ 9gQQ== X-Gm-Message-State: AOAM533kVYQNwSu5AOPG7nqrAnRH7a07Xh2JmnCOqiZQZYLjN5gxkxT6 5CIDuVLqKRsieQ8YhVRoNjF11bU5p5VIsMeXU2o= X-Google-Smtp-Source: ABdhPJzaCdZDUyv1J4rrbcpPI23Gv8C/vafFcCyWG15XJ2u8SrLZ5EIYufX+2XvMpegv0NnfO0uZQowjOG2mrAxvaLI= X-Received: by 2002:a05:6512:12c7:: with SMTP id p7mr16460721lfg.494.1620144929496; Tue, 04 May 2021 09:15:29 -0700 (PDT) In-Reply-To: <1a73bd6c69101f3312ad@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205626 Archived-At: --00000000000001e39305c1836376 Content-Type: text/plain; charset="UTF-8" The minor mode is exactly the same as what you have in your previous email. What actually happens in my regular setup is the key bindings in multiple minor modes override the key map given to read-from-minibuffer. The problem is I don't want to turn off those minor mode as they used to work in the minibuffer in emacs 27 as intended, but not so in emacs 28. One mode is smartparens and another is move-dup. On Tue, 4 May 2021 at 3:29 pm Gregory Heytings wrote: > > >> It's literally just a global minor mode defined for your test minor > >> mode, basically `(define-global-minor-mode test-global-mode test-mode > >> (lambda() t))` > > > > In that case, you should disable (or rather, not enable) that minor mode > > for minibuffers, for example: > > > > (define-global-minor-mode test-global-mode test-mode (lambda () (or > > (minibufferp) (test-mode 1)))) > > > > (Note that this does not answer your question "In Emacs 27, turning the > minor mode on inside the minibuffer would not override the key map given > to read-from-minibuffer", with the above the effect is the same in Emacs > 27 and 28 AFAICS. Without seeing the minor mode, I cannot help you more, > I don't have a crystal ball.) > -- Jimmy Yuen Ho Wong --00000000000001e39305c1836376 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The minor mode is exactly the same as what you have in yo= ur previous email. What actually happens in my regular setup is the key bin= dings in multiple minor modes override the key map given to read-from-minib= uffer. The problem is I don't want to turn off those minor mode as they= used to work in the minibuffer in emacs 27 as intended, but not so in emac= s 28.

One mode is smartp= arens and another is move-dup.

On Tue, 4 May 2021 at 3:29 pm Gregory He= ytings <gregory@heytings.org= > wrote:

>> It's literally just a global minor mode defined for your test = minor
>> mode, basically `(define-global-minor-mode test-global-mode test-m= ode
>> (lambda() t))`
>
> In that case, you should disable (or rather, not enable) that minor mo= de
> for minibuffers, for example:
>
> (define-global-minor-mode test-global-mode test-mode (lambda () (or > (minibufferp) (test-mode 1))))
>

(Note that this does not answer your question "In Emacs 27, turning th= e
minor mode on inside the minibuffer would not override the key map given to read-from-minibuffer", with the above the effect is the same in Ema= cs
27 and 28 AFAICS.=C2=A0 Without seeing the minor mode, I cannot help you mo= re,
I don't have a crystal ball.)
--
Jimmy Yuen Ho Wong
--00000000000001e39305c1836376--