unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
To: Gregory Heytings <gregory@heytings.org>
Cc: 48153@debbugs.gnu.org
Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer
Date: Tue, 4 May 2021 17:15:18 +0100	[thread overview]
Message-ID: <CAKDRQS7TqY6ypuEorEOvRjx-2Fnn37qj1CAincFfy4_dfOWuag@mail.gmail.com> (raw)
In-Reply-To: <1a73bd6c69101f3312ad@heytings.org>

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

The minor mode is exactly the same as what you have in your previous email.
What actually happens in my regular setup is the key bindings in multiple
minor modes override the key map given to read-from-minibuffer. The problem
is I don't want to turn off those minor mode as they used to work in the
minibuffer in emacs 27 as intended, but not so in emacs 28.

One mode is smartparens and another is move-dup.

On Tue, 4 May 2021 at 3:29 pm Gregory Heytings <gregory@heytings.org> wrote:

>
> >> It's literally just a global minor mode defined for your test minor
> >> mode, basically `(define-global-minor-mode test-global-mode test-mode
> >> (lambda() t))`
> >
> > In that case, you should disable (or rather, not enable) that minor mode
> > for minibuffers, for example:
> >
> > (define-global-minor-mode test-global-mode test-mode (lambda () (or
> > (minibufferp) (test-mode 1))))
> >
>
> (Note that this does not answer your question "In Emacs 27, turning the
> minor mode on inside the minibuffer would not override the key map given
> to read-from-minibuffer", with the above the effect is the same in Emacs
> 27 and 28 AFAICS.  Without seeing the minor mode, I cannot help you more,
> I don't have a crystal ball.)
>
-- 
Jimmy Yuen Ho Wong

[-- Attachment #2: Type: text/html, Size: 1849 bytes --]

  reply	other threads:[~2021-05-04 16:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02  6:58 bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Jimmy Yuen Ho Wong
2021-05-03 15:15 ` Gregory Heytings
2021-05-04 12:53   ` Jimmy Yuen Ho Wong
2021-05-04 13:13     ` Gregory Heytings
2021-05-04 13:52       ` Jimmy Yuen Ho Wong
2021-05-04 14:02         ` Gregory Heytings
2021-05-04 14:29           ` Gregory Heytings
2021-05-04 16:15             ` Jimmy Yuen Ho Wong [this message]
2021-05-04 16:36               ` Gregory Heytings
2021-05-04 22:40                 ` Jimmy Yuen Ho Wong
2021-05-05  8:09                   ` Gregory Heytings
2021-05-05  9:10                     ` Jimmy Yuen Ho Wong
2021-05-05 12:15                       ` Eli Zaretskii
2021-05-05 13:12                         ` Gregory Heytings
2021-05-05 13:24                           ` Jimmy Yuen Ho Wong
2021-05-05 14:17                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06 10:55                               ` Jimmy Yuen Ho Wong
2021-05-09 14:57                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-05 13:06                       ` Gregory Heytings
2021-05-05 14:05     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKDRQS7TqY6ypuEorEOvRjx-2Fnn37qj1CAincFfy4_dfOWuag@mail.gmail.com \
    --to=wyuenho@gmail.com \
    --cc=48153@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).