From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jimmy Yuen Ho Wong Newsgroups: gmane.emacs.bugs Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Date: Wed, 5 May 2021 10:10:23 +0100 Message-ID: References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7271"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48153@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 11:13:03 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leDaY-0001ni-Rz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 11:13:02 +0200 Original-Received: from localhost ([::1]:52048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leDaX-0004wC-V7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 05:13:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leDZa-0003hF-Pr for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 05:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leDZa-0006vJ-HP for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 05:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leDZa-0006fq-CA for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 05:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162020586825641 (code B ref 48153); Wed, 05 May 2021 09:12:02 +0000 Original-Received: (at 48153) by debbugs.gnu.org; 5 May 2021 09:11:08 +0000 Original-Received: from localhost ([127.0.0.1]:58809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leDYh-0006fV-O0 for submit@debbugs.gnu.org; Wed, 05 May 2021 05:11:07 -0400 Original-Received: from mail-lf1-f42.google.com ([209.85.167.42]:43714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leDYf-0006f3-K6 for 48153@debbugs.gnu.org; Wed, 05 May 2021 05:11:06 -0400 Original-Received: by mail-lf1-f42.google.com with SMTP id x2so1530903lff.10 for <48153@debbugs.gnu.org>; Wed, 05 May 2021 02:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NUm9oUTxPqjmfbjjyQSQDFQnXqBSD4G8msADx+l1R08=; b=cnvIQqSgulHUH7Ic2N3qIERYWnocOC9+aLRXl0X8VMOceZE8MEEuUBRgz2BAWFs86a icejFjPeayV+cjqMokXzNQI5yAtY6uGChtVG2kQSmq7AibzCWxQw280hV4AOQD4SptDa tsJJfpBlQOAYW6Kuz89FAFeyBNR6jrPbIbwrYOxUOrSObMp2mBk2QGTGZ7NyrEBqr6k4 ZZw/SfdW4mIjTx63J0S0OFFDyd5AZ1EsYRaTvHxNCM4JUyRtcpRgOU6Vi7SJUdHMJdI0 DEoFz2XR/qjujvC73CCN9y5TskJNDK4Baj8bKLXLx/+Izz0INT+PnWKzeqxAlEz3dWYz YNfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NUm9oUTxPqjmfbjjyQSQDFQnXqBSD4G8msADx+l1R08=; b=Yuu1OhtplyNZBBtVgPR0hvOixSxAcgGW0FZ4XE8SuRwPkfqwPXi9q7wd2kBtA4q9zk VF+AlrBBzm+BYsyaxPiKfIB6tJnSAMZn4LEOLMBoswqFvVO5zUSoWHSJlpIlpEWDIXfh LbR0tSe2GJjMOFA5gtgJnN5ZpgK3Ml1y1qZ607LnfwxEkj5OM6nfDufgdM+dr5JgNPWT 9oZE2NnORgEhjRLcrmpR4Fe8f0o5XhO+yYIiJ953/eLEOPLF52LzMinModM/G13xrixb BagQfPA52nnJb+ou3fHf93Xp+WYDIS66+XBloxwhQd8g4g8gZjt/SX/E7nAN7wvS0vZy Qytw== X-Gm-Message-State: AOAM5322/SmAAkUw47VGcV53T4cpX2ikz8oMG4g4a25eRllMlRUIEqmb SECk2NsiLA8BANzpT2R0ZBhtMDMBRBLfvLlzY8c= X-Google-Smtp-Source: ABdhPJzy3s/a7lUVWF4wswFzl7vrGe9xmmusB7upFwvxV3Fji1++tOBR1p+ENRWD4gJbSVace/ODE2oZ2DwletWguqQ= X-Received: by 2002:a05:6512:3f3:: with SMTP id n19mr17595986lfq.594.1620205859281; Wed, 05 May 2021 02:10:59 -0700 (PDT) In-Reply-To: <70f2eadd5f48937bb057@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205670 Archived-At: > > Why would they not? The minibuffer behaves, in that respect, like any > other buffer. Note that they do so only when the minor mode is enabled in > the minibuffer. > Because the minibuffer does not behave like any other buffers. Setting `minor-mode-overriding-map-alist` has no effect, so I think either the minibuffer really needs to behave like any other buffer, or special-cased and documented the ways it differs from regular buffers. I have this code in my init.el, and it doesn't seem to work. (defun ido-resurrect-keybinding () (pcase-dolist (`(,minor-mode . ,keymap) (seq-filter (lambda (entry) (symbol-value (car entry))) minor-mode-map-alist)) (cl-loop for buf in (buffer-list) if (and (minibufferp buf) (with-current-buffer buf (symbol-value minor-mode))) do (map-keymap (lambda (event def) (when-let (key (and (or (characterp event) (and (symbolp event) (not (eq event 'remap)) (not (keymapp def)))) (if (characterp event) (format "%c" event) (vector event)))) (when (lookup-key ido-completion-map key) (let ((map (copy-keymap keymap))) (define-key map key nil) (with-current-buffer buf (push (cons minor-mode map) minor-mode-overriding-map-alist)))))) keymap)))) (with-eval-after-load 'ido (add-hook 'ido-setup-hook 'ido-resurrect-keybinding))