From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jimmy Yuen Ho Wong Newsgroups: gmane.emacs.bugs Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Date: Wed, 5 May 2021 14:24:22 +0100 Message-ID: References: <1a73bd6c69bb5c6a8431@heytings.org> <1a73bd6c69374497d37b@heytings.org> <1a73bd6c69101f3312ad@heytings.org> <1a73bd6c691b937c82fc@heytings.org> <70f2eadd5f48937bb057@heytings.org> <83r1il2x7t.fsf@gnu.org> <70f2eadd5fbd139e3c62@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24756"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48153@debbugs.gnu.org, Stefan Monnier To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 15:26:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leHXk-0006Hf-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 15:26:24 +0200 Original-Received: from localhost ([::1]:38466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leHXi-00047F-6q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 09:26:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leHXS-00046q-50 for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 09:26:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leHXO-00030u-Kq for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 09:26:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leHXO-0007oY-H4 for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 09:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 48153-submit@debbugs.gnu.org id=B48153.162022110830019 (code B ref 48153); Wed, 05 May 2021 13:26:02 +0000 Original-Received: (at 48153) by debbugs.gnu.org; 5 May 2021 13:25:08 +0000 Original-Received: from localhost ([127.0.0.1]:60196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHWV-0007o7-Nv for submit@debbugs.gnu.org; Wed, 05 May 2021 09:25:08 -0400 Original-Received: from mail-lj1-f179.google.com ([209.85.208.179]:33365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leHWS-0007nl-PG for 48153@debbugs.gnu.org; Wed, 05 May 2021 09:25:06 -0400 Original-Received: by mail-lj1-f179.google.com with SMTP id s25so2485246lji.0 for <48153@debbugs.gnu.org>; Wed, 05 May 2021 06:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+uc4fMVRKV2ZvD2LBNyWZCVJkUM5cmch9dXUEIGJZqY=; b=JZJL/1C8ygkOyjLuOxQULwnT42kBfsqr2weu4XhDymwTHIVBk3K268gX4QsNR8+DrC sSakw62/iEWkYFaCByeHcYTLIyhNobJJrafqMudfgsuQXyA59qpoHj9HB1N4m/QHk77c gr5s+hDTWE2JhIZS8diXR3T/h5bF7M3VTtlBfwqCcCm3Keco3N4MSmERmsmsbxP8paWv lybJ2FJeyuRvcM9CEG4wyASW5qia0fAGMWsIuOPC8rphSfBTO7gmVaD8WkNuN/dGuz15 Dhcp869vhVwsjLxukFyHDAG4/UPxKov5Qv9nqXg5JEJSP0FuELj94tX0isfznbI/lKQ1 ayxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+uc4fMVRKV2ZvD2LBNyWZCVJkUM5cmch9dXUEIGJZqY=; b=r7/cpNUgeb1K4Udfqrzb1AraPoSjhgTtBgwirJohd3sifWH9e0F7AfQWUcR3Usty8I DIDhxD/4h/wjLLfKLqmRuesvyJvujsqZPLaTDrd2q1UagAVNHCkVzXzw+H18YFd6xNku epN1zmRaK7tp2ysQ73AtKvquRBywoS7QMPTHA0K04h67Ftw6cQ3oKfjWPyfyurz4r/Lb p4zL3C/72SkNPWEoeaZphhkxuy6V8xg3FQWrWy2+HvQ23MuVU6PFaTfgWBMSqVxBNgU8 RwLqur4er6OdQJ0RYWFhjd4Z6gpAV2iwUvB3gc0AcBobWaS4enq0BNeBuHHxU5uwJ5Fl XCpw== X-Gm-Message-State: AOAM533/GtuypJYnwSwNSWvQw5tQ7koZJLG/ghB1m0pB5fC3ys7zd5wh 6uum3azCZ2+XxQs8tVqOZVKT/oAL31Qbtmo4qLC9q+PDiiE= X-Google-Smtp-Source: ABdhPJzRA2RozzfiStTWGr8ncpxgSROtJnVuMpWT1NXEonTdcozxMCSifmyirlNcJJH/mAoXiwmJW2C7PTTo+QQuozs= X-Received: by 2002:a05:651c:319:: with SMTP id a25mr21051207ljp.69.1620221098616; Wed, 05 May 2021 06:24:58 -0700 (PDT) In-Reply-To: <70f2eadd5fbd139e3c62@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205696 Archived-At: Ok let me summarize the issue here. 1. On emacs 27, minor mode keybindings will only override the key bindings given to read-from-minibuffer after the second invocation of the minibuffer, but doesn't on the first invocation. 2. On emacs 28, minor mode keybindings override the key bindings given to read-from-minibuffer at all times. 3. But, `minor-mode-overriding-map-alist` does not override the override in effect in the minibuffer like other buffers. My expectation is when a keymap is explicitly given to read-from-minibuffer, the key bindings in it should take precedence, but it doesn't. As you can see from the snippet from my last email, both ido-completion-map and test-mode bind to C-k, I expect the C-k binding in ido-completion-map to take effect inside the minibuffer, without being overridden by any minor modes in effect inside the minibuffer. If this is not to be desired, I'd expect setting minor-mode-overriding-map-alist or the usual key binding lookup search algorithm to work inside the minibuffer. Does it make sense? Jimmy On Wed, May 5, 2021 at 2:12 PM Gregory Heytings wrote: > > > >>> Why would they not? The minibuffer behaves, in that respect, like any > >>> other buffer. Note that they do so only when the minor mode is > >>> enabled in the minibuffer. > >> > >> Because the minibuffer does not behave like any other buffers. Setting > >> `minor-mode-overriding-map-alist` has no effect, so I think either the > >> minibuffer really needs to behave like any other buffer, or > >> special-cased and documented the ways it differs from regular buffers. > > > > I admit that I've lost the context in this discussion. I'm CC'ing > > Stefan in the hope he could tell whether we do or don't have a problem > > here; if Stefan is unable to do that, either, we will unfortunately have > > to get back to the beginning and explain what kind of problems the > > current behavior causes. Because in general what Jimmy described in the > > original report sounds the expected behavior to me. > > > > I admit I'm lost, too. The description of the problem has changed several > times, and what was described in the original report is the actual > behavior. Of course I may be missing something; I'm not fortunate enough > to have a crystal ball, like Stefan ;-)