unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Christoph via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 66534@debbugs.gnu.org
Subject: bug#66534: 30.0.50; [PATCH] Expand file-name of ~/.emacs before attempt to load it
Date: Sat, 14 Oct 2023 11:05:42 +0200	[thread overview]
Message-ID: <CAK9rt1o_C8aJs_fDOa0d36_qM7E26=z9B=ruMjsWphGeVhkSKw@mail.gmail.com> (raw)
In-Reply-To: <87cyxhhdhd.fsf@igel.home>

On Sat, Oct 14, 2023 at 9:25 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Okt 13 2023, Christoph via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>
> > I noticed that during startup, emacs tries to load ~/.emacs (with
> > different extensions) many times over.  You can see this by using
> > strace and tracing the openat syscall.  The problem is, that `load'
> > does not expand the ~/ in the filename passed to it.  So it does not
> > recognize the file as being absolute and tries to resolve it using
> > the load-path.
>
> That's probably a bug in complete_filename_p.
>

I am not so sure if complete_filename_p should be able to recognize
these kinds of paths, or if `load' should expand the filename before
using it.  I am not familiar with all supported platforms, but it might
be tricky to check if a filename is absolute, without expanding it
beforehand.

For instance, what about filenames that start with a series of "../".
I guess they should be considered to be absolute, if the path goes up
to the root.

On the other hand, the documentation of `load' does not mention
absolute paths at all and states, This function searches the
directories on `load-path'.  So I can't say what the expected behaviour
of load is with paths that aren't expanded, but are absolute.

I am hesitant with changing the C code, because I am not very familiar
with it and just started to get into it, so I thought it might be more
appropriate to change it on the Lisp side, since all the other paths
to init files are fully expanded before passing them to load.

But yes, as I wrote before, I think this behaviour of load could be
considered a bug as well.

-- Christoph





      reply	other threads:[~2023-10-14  9:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 18:41 bug#66534: 30.0.50; [PATCH] Expand file-name of ~/.emacs before attempt to load it Christoph via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14  6:54 ` Eli Zaretskii
2023-10-14  9:04   ` Christoph via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-23 15:56   ` Christoph via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14  7:25 ` Andreas Schwab
2023-10-14  9:05   ` Christoph via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK9rt1o_C8aJs_fDOa0d36_qM7E26=z9B=ruMjsWphGeVhkSKw@mail.gmail.com' \
    --to=bug-gnu-emacs@gnu.org \
    --cc=66534@debbugs.gnu.org \
    --cc=just.mychris@googlemail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).