From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastian Beranek Newsgroups: gmane.emacs.bugs Subject: bug#60066: 30.0.50; whitespace-mode modifies buffer Date: Wed, 14 Dec 2022 17:53:54 +0100 Message-ID: References: <877cyuhxj8.fsf@gmail.com> <83h6xym073.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26363"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60066@debbugs.gnu.org, Richard Hansen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 14 17:56:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5V34-0006dV-MZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Dec 2022 17:56:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5V29-0004SO-2S; Wed, 14 Dec 2022 11:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5V26-0004OA-Iv for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 11:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5V26-0008Id-9y for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 11:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5V25-0005Cz-RI for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2022 11:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bastian Beranek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Dec 2022 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60066 X-GNU-PR-Package: emacs Original-Received: via spool by 60066-submit@debbugs.gnu.org id=B60066.167103686220011 (code B ref 60066); Wed, 14 Dec 2022 16:55:01 +0000 Original-Received: (at 60066) by debbugs.gnu.org; 14 Dec 2022 16:54:22 +0000 Original-Received: from localhost ([127.0.0.1]:40336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5V1R-0005Ch-PZ for submit@debbugs.gnu.org; Wed, 14 Dec 2022 11:54:22 -0500 Original-Received: from mail-yb1-f169.google.com ([209.85.219.169]:44549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5V1N-0005Ca-QZ for 60066@debbugs.gnu.org; Wed, 14 Dec 2022 11:54:21 -0500 Original-Received: by mail-yb1-f169.google.com with SMTP id c140so393147ybf.11 for <60066@debbugs.gnu.org>; Wed, 14 Dec 2022 08:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jzkDLiG8/1O62yEPRhuoR1UQfZN3gohW4DgqThS/zg8=; b=EhIaU6fanZdDtqghkGL3S+2yARTGGBVCocvBNwn+CPfvelPtjKYt3lgtARBHaypjzX Yi/wQKYwlVpDMdAZCsMcrOBAJwOFz1N72fDAMatOo04cTW7mXEPK7Tm5Gi8iEy43+fGT wBzwlN0SrGsJuS4s5xjcBWVIxNMmoMEqHtbHY/tjOROWbl3itmQUT7Lm4omFypaAUHE+ yzsJggJc9MJ+7Ak89ola3HPZLKAryB4hK7MTsP5yiC2pKgwvg1CfuN3WWbMFoi+FOOQ+ FwvPnJPvJkfSmJy5PUe2UWD5KwPOj4AW/dU6sSrUXuoFS/eP2utbUfswXqosRnfgqY4C ayTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jzkDLiG8/1O62yEPRhuoR1UQfZN3gohW4DgqThS/zg8=; b=3i5viSYeF0P1O81Wxfe0glukEYBb+KqztDTm+kmwiDROCigzEVScK+TDZ+olkLi/0n XL1oj1rZV13gKAu3KwVMR2B88F883WsbitX7eFPkNyQd3lyt+DuLAUzI811qkDFIT0Mv wcjfX2+kqEB0983qjCmiGyuxPCxfUD6tjNl3sYgZYGr7teX4wH5pgHE/9DnX/CHijs3Z ooQmgoGMNgHHHOmPMcurxEwTdZbXL8W8fjAkKM8kmHbEhIXuc0B2NSfHXXIbEigXIhir Jz8Zhf8/54ccXjYxtq+hyqUs1N2EvPN8JN/WW2nw9ITrJl8modt/4FO/joVCWcyarCxm fPMA== X-Gm-Message-State: ANoB5pmKZCxHasAuRC+cHs87zqAhuJhP0Ieoe8vzSn3Hfgq52WuKY/03 fUEPP/spV0sfjC2COHsBTXBHsCRPb6pgZRYI41A= X-Google-Smtp-Source: AA0mqf7GzvV/62nWjtvJgll7PhJfhAWc9zqxmG9sut4aykZZMaRp20uJMojqLKN9lFcOOt8+hAoS3Pp7gWLzQgvsIQM= X-Received: by 2002:a25:7354:0:b0:6f0:b2d4:1ef4 with SMTP id o81-20020a257354000000b006f0b2d41ef4mr66670246ybc.21.1671036852159; Wed, 14 Dec 2022 08:54:12 -0800 (PST) In-Reply-To: <83h6xym073.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250970 Archived-At: On Wed, Dec 14, 2022 at 5:15 PM Eli Zaretskii wrote: > > > From: Bastian Beranek > > Date: Wed, 14 Dec 2022 15:26:03 +0100 > > > > > > I have > > > > (add-hook 'c-mode-common-hook 'whitespace-mode) > > > > in my .emacs and I am using emacs master (which includes > > whitespace.el). When opening a source file in my project the buffer > > immediately is marked as modified and emacs will ask to save the buffer > > when trying to kill it. > > > > I was able to trace this back to the above line in my .emacs. If I don't > > enable whitespace-mode in the hook the buffer is not marked as modified > > when opening the .C file. > > > > With my configuration I would not expect whitespace-mode to make any > > changes to the buffer. > > > > I went back to whitespace.el from commit > > > > 29eb4596956a74a83ceb4c17835886a23ea0dd20 > > > > and the problem is fixed. So I assume it is a recent regression in > > whitespace.el. > > Richard, could you please look into this? It sounds like your recent > changes to whitespace.el could be the culprit for this regression. I > guess something like with-silent-modifications is missing somewhere? It might be worth pointing out that there are no actual differences between the buffer and its on-disk counterpart, but still emacs considers the buffer to be modified, as if a change was made and reverted (but not through undo).