From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastian Beranek Newsgroups: gmane.emacs.bugs Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. Date: Sat, 13 Feb 2021 20:02:26 +0100 Message-ID: References: <871rdv4xog.fsf@gmail.com> <87a6sfu0fi.fsf@mail.linkov.net> <87v9b2ifrz.fsf@mail.linkov.net> <55ebad56-b440-198a-653e-1660040d5eae@gmx.at> <38b988fd-2ad6-a596-23a0-1d765249f718@gmx.at> <87tuqjydku.fsf@mail.linkov.net> <871rdlr4vc.fsf@mail.linkov.net> <87ft1zsu75.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5128"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46299@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 13 20:03:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB0CD-0001Dw-8u for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 20:03:09 +0100 Original-Received: from localhost ([::1]:54520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lB0CB-00023Z-QH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 14:03:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lB0C6-00023Q-1Y for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 14:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lB0C5-0002fQ-QF for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 14:03:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lB0C5-0002TL-MP for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 14:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bastian Beranek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Feb 2021 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46299 X-GNU-PR-Package: emacs Original-Received: via spool by 46299-submit@debbugs.gnu.org id=B46299.16132429709486 (code B ref 46299); Sat, 13 Feb 2021 19:03:01 +0000 Original-Received: (at 46299) by debbugs.gnu.org; 13 Feb 2021 19:02:50 +0000 Original-Received: from localhost ([127.0.0.1]:35063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB0Bu-0002Sn-9H for submit@debbugs.gnu.org; Sat, 13 Feb 2021 14:02:50 -0500 Original-Received: from mail-qv1-f43.google.com ([209.85.219.43]:36075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB0Bs-0002SZ-0J for 46299@debbugs.gnu.org; Sat, 13 Feb 2021 14:02:48 -0500 Original-Received: by mail-qv1-f43.google.com with SMTP id e9so1427772qvy.3 for <46299@debbugs.gnu.org>; Sat, 13 Feb 2021 11:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3/0JwZgGRW4dQSDoU7DAwbmvfWT5H68Waj9Y9c8pL4Q=; b=oMFc/nN+tGZX/gZrVo+sXV7eQsNR1bEMpOt/bYkmIvalxoPAaD4WsAvbGAjF4IkaDS Zq1Y+hVXffBP+XeeVS6pVcteq3jHe8ErlejAodCOv3PLWOSmnYxBjDdTij+mpBQKLHH0 3Xn1LKvpofOO9k+SkH1XTVmx6J7b9ZH9Ul1sae4lhw3+wqwtxHkVpi6vw4YHn2UrVYaE HXAO4CqugjblCM8cx8BXE7zG6NfWpZbkU/vIy6QZp5c/CBwzCoSizXuI5fJjIQgweBJ4 1erX71tjhsLNGfwoHzag6WOd4f/r8DKZp8kyPsKVwa1K+X3NCgMUMi3U05YeV33LqPQV cayA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3/0JwZgGRW4dQSDoU7DAwbmvfWT5H68Waj9Y9c8pL4Q=; b=MlBWmkptfUq4E3qly8bXHnOnC1wz55gRZXZHO4hfCKG81bOX0QT0YoXfYEsOntp2nX LbfZqXhtLKyrDkWwOrXhFfPLAn7Uo+Csx9D0wfz9uBqh8RcXSbITHtJDoyssBa8AOH/W Gnj592HhkWW4HrvKXvXV71lweu/HMTlOABqOcFJFNdKltE8LeIVPdE2ODo5j3MXtZ7bC ra93EV/6QOdPAcFOKKctgxClontv/X5s3PiSo+KhbyPGPDT12YH0PSuHFYUwp8GXROct Mttm9WB+1A7mVKUdyHLS4LH8APqkKzQtndjjYtQR8r6+cbFWwlE3emMHESYM2zojk1fY OW/A== X-Gm-Message-State: AOAM532H0PlRoxqBF2qhD9Wfwz/14wiYL/xPPYHKdr5bsrcI7ZjL6VnS On3+6DAnRz0OvVqPdQrmkfUH20ljrchh5pcIxZI= X-Google-Smtp-Source: ABdhPJzK+UeLLxSHiCIcU/Jz6QksyzWByl80C93tXw8n/lkeV1tSMufahediTjCIrCSt2yHDv7cVSFdWqmWLVs6MrdQ= X-Received: by 2002:a0c:e708:: with SMTP id d8mr8041431qvn.12.1613242962498; Sat, 13 Feb 2021 11:02:42 -0800 (PST) In-Reply-To: <87ft1zsu75.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199954 Archived-At: On Sat, Feb 13, 2021 at 7:33 PM Juri Linkov wrote: > > Hey Bastian, > > Thank you for working on this patch. Please prepare the ChangeLog > commit message, so your patch could be pushed to master. Then it would be > easier to reason about further changes and base them on the pushed version. I will do that and set a proper patch for git am. > > > @@ -89,8 +89,9 @@ tab-bar-select-tab-modifiers > > :set (lambda (sym val) > > (set-default sym val) > > ;; Reenable the tab-bar with new keybindings > > - (tab-bar-mode -1) > > - (tab-bar-mode 1)) > > + (when tab-bar-mode > > + (tab-bar-mode -1) > > + (tab-bar-mode 1))) > > :group 'tab-bar > > :version "27.1") > > > > This seems to fix the issue. I can't say I fully understand why > > though. It must have something to do with running > > tab-bar--update-tab-bar-lines in early initialization? We could also > > wrap the call to tab-bar--update-tab-bar-lines. > > The problem is that currently the function tab-bar-mode contains: > > (if tab-bar-mode > (tab-bar--define-keys) > ;; Unset only keys bound by tab-bar > (when (eq (global-key-binding [(control tab)]) 'tab-next) > (global-unset-key [(control tab)])) > ... > > If the global-unset-key part would be refactored into a separate > function, then tab-bar-select-tab-modifiers could call two > functions sequentially: a new function that undefines old keys, > then the existing separate function tab-bar--define-keys > that will define keys with customized modifier. But how would that cause visual glitches, such as the tab bar splitting into two lines, menu bar not showing and general visual issues (lines jumping around etc.). This worries me a bit, because I don't understand the problem (just worked around it by not running the (tab-bar-mode -1) (tab-bar-mode 1) sequence. Did you try the recipe I reported above?