From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastian Beranek Newsgroups: gmane.emacs.bugs Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. Date: Mon, 8 Feb 2021 00:03:26 +0100 Message-ID: References: <871rdv4xog.fsf@gmail.com> <87k0rmnbqs.fsf@mail.linkov.net> <87a6sfu0fi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000008d00d805bac7107f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6781"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46299@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 08 00:08:04 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8t9u-0001cw-Nu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 00:08:02 +0100 Original-Received: from localhost ([::1]:36960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8t9t-0001ug-Pm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Feb 2021 18:08:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8t62-0007l3-EX for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 18:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8t62-00037G-5m for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 18:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8t62-0002IT-0Z for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 18:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bastian Beranek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2021 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46299 X-GNU-PR-Package: emacs Original-Received: via spool by 46299-submit@debbugs.gnu.org id=B46299.16127390308811 (code B ref 46299); Sun, 07 Feb 2021 23:04:01 +0000 Original-Received: (at 46299) by debbugs.gnu.org; 7 Feb 2021 23:03:50 +0000 Original-Received: from localhost ([127.0.0.1]:49171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8t5p-0002I2-Vk for submit@debbugs.gnu.org; Sun, 07 Feb 2021 18:03:50 -0500 Original-Received: from mail-qk1-f176.google.com ([209.85.222.176]:41548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8t5n-0002Hp-VL for 46299@debbugs.gnu.org; Sun, 07 Feb 2021 18:03:49 -0500 Original-Received: by mail-qk1-f176.google.com with SMTP id q85so453317qke.8 for <46299@debbugs.gnu.org>; Sun, 07 Feb 2021 15:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LVeBFB4BFQC1Ziy1GFFUggNbp0pbWI/LtPRgZUeIbro=; b=IqpB5VbXbXKb8r3O3/Hq1F1wCVoI+4fGaog5uQByKk7UOisKpHajeC+BNYBUnFPWce FO4pcpA38L9gXuYeqGMIxj2GQVLJlVHajWtufvPw7TT4xj3s6mryqFIZuYn1Hx09w3NJ T7ySM5HalznUaoURXf2gi4az4UFn++pJ2l21vYhHhqqdMgShxwNRkd0GFQp/NG6tgtx2 qhpstZyPAaJWVVubIz3X5HmjcyetEQ/KWG2EJq9oLrXQcFNcJ8Aw+L2APOZPR9Y2plQ5 detfvquMy3kh+8uiNMZPoKvV0COU4cX4zph+jz3RcGxLx56cQUXtVzwsVXoKePPd+ycF 5/oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LVeBFB4BFQC1Ziy1GFFUggNbp0pbWI/LtPRgZUeIbro=; b=AukToNntojlF8v/1zobap6ym6Smq+G4E+1TGXBkfDTZR7wMMAUjLqaLkNTig+jusYY XGkWFMx3oFQcQLWl3oqJHhaW8znWAflZs+ln5zqrScnE6JkFWvkJXUe4RV9fU2t4fEd3 u7L9fkRkxPLEkajx2HECPNIQWqGlMk3Pma/E3yEiTFvL/Q40YRSdy1/Wfu1H444ADOME uNqojDXcNEH9td+vzk55P6xwh9Dr+g+5JaltKk3knPUrNY5SJEHYdVC/XryenNEo/fEs ubDJe7MjUmmD9KfTI26hdK6M4ECCoxlVKM2R3c5FFq50qykUjXq2B9dFajwecUA3uFmj kYfg== X-Gm-Message-State: AOAM533V0VLg5C5yeAe+BD53k7JvszQJkNL9JobfzK9vEC4q11klgA3z DrnD/fmeb4E84CQCOMNxVmRNupoSLUvFHoUCwkXhrNkWuyk= X-Google-Smtp-Source: ABdhPJyAHsJ1N5xWhD2OKPcZUIfxu+EjWiKuarugyzVMI0M30qEypvG0SujG3uN8H10frYcsRcm1gsIRsz9Zqa+zPLw= X-Received: by 2002:a05:620a:1096:: with SMTP id g22mr14710066qkk.316.1612739022453; Sun, 07 Feb 2021 15:03:42 -0800 (PST) In-Reply-To: <87a6sfu0fi.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199584 Archived-At: --0000000000008d00d805bac7107f Content-Type: text/plain; charset="UTF-8" Hello Juri, On Sun, Feb 7, 2021 at 8:48 PM Juri Linkov wrote: > > > I added code to make the frame setting of tab-bar-lines as well as the > > default-frame-alist value dependent on tab-bar-show to the > > tab-bar-mode function. > > I think with this the part to which sets frame parameters in > > tab-bar-show :set is not needed because (tab-bar-mode 1) is called > > anyway, which already does everything. > > > > What do you think about the attached patch? > > I think your earlier idea was better - to have a dynamic function which > counts the numbers of tabs and adapts the number of tab-bar-lines > according to the value of tab-bar-show. > > Then such a function could be called from many places: > - tab-bar-mode > - tab-bar-show :set > - from the end of tab-bar-new-tab-to > - from the end of tab-bar-close-tab > - from the end of tab-bar-close-other-tabs > > to sync the actual tabs with the value of tab-bar-show. Makes sense! How about the attached? Cheers Bastian --0000000000008d00d805bac7107f Content-Type: text/x-patch; charset="US-ASCII"; name="tab-bar_v2.patch" Content-Disposition: attachment; filename="tab-bar_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kkvr5t730 ZGlmZiAtLWdpdCBhL2xpc3AvdGFiLWJhci5lbCBiL2xpc3AvdGFiLWJhci5lbAppbmRleCA2NzIw ZDgyYjQ3Li4wM2RkZDc1ODgxIDEwMDY0NAotLS0gYS9saXNwL3RhYi1iYXIuZWwKKysrIGIvbGlz cC90YWItYmFyLmVsCkBAIC0xMzQsMjEgKzEzNCwzMCBAQCBQb3NzaWJsZSBtb2RpZmllciBrZXlz IGFyZSBgY29udHJvbCcsIGBtZXRhJywgYHNoaWZ0JywgYGh5cGVyJywgYHN1cGVyJyBhbmQKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDphc2NlbnQgY2VudGVyKSkK ICAgICAgICAgICAgICAgICAgICAgICAgICB0YWItYmFyLWNsb3NlLWJ1dHRvbikpKQogCisoZGVm dW4gdGFiLWJhci0tdXBkYXRlLXRhYi1iYXItbGluZXMgKCkKKyAgOzsgU2V0IGZyYW1lIHBhcmFt ZXRlcnMuCisgIChsZXQgKChkZWZhdWx0dmFsIChpZiAoYW5kIHRhYi1iYXItbW9kZSB0YWItYmFy LXNob3cpIDEgMCkpKQorICAgIChkb2xpc3QgKGZyYW1lIChmcmFtZS1saXN0KSkKKyAgICAgIChs ZXQgKChmcmFtZXZhbCAoaWYgKG5hdG51bXAgdGFiLWJhci1zaG93KQorICAgICAgICAgICAgICAg ICAgICAgICAgICAoaWYgKGFuZCBkZWZhdWx0dmFsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICg+IChsZW5ndGggKGZ1bmNhbGwgdGFiLWJhci10YWJzLWZ1bmN0aW9uIGZyYW1l KSkgdGFiLWJhci1zaG93KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDEgMCkKKyAg ICAgICAgICAgICAgICAgICAgICAgIGRlZmF1bHR2YWwpKSkKKyAgICAgICAgKHNldC1mcmFtZS1w YXJhbWV0ZXIgZnJhbWUgJ3RhYi1iYXItbGluZXMgZnJhbWV2YWwpKSkKKyAgICAobGV0ICgobmV3 ZnJhbWV2YWwgKGlmIChhbmQgZGVmYXVsdHZhbCAoZXEgdGFiLWJhci1zaG93IHQpKSAxIDApKSkK KyAgICAgIChzZXRxIGRlZmF1bHQtZnJhbWUtYWxpc3QKKyAgICAgICAgICAgIChjb25zIChjb25z ICd0YWItYmFyLWxpbmVzIG5ld2ZyYW1ldmFsKQorICAgICAgICAgICAgICAgICAgKGFzc3EtZGVs ZXRlLWFsbCAndGFiLWJhci1saW5lcyBkZWZhdWx0LWZyYW1lLWFsaXN0KSkpKSkpCisKIChkZWZp bmUtbWlub3ItbW9kZSB0YWItYmFyLW1vZGUKICAgIlRvZ2dsZSB0aGUgdGFiIGJhciBpbiBhbGwg Z3JhcGhpY2FsIGZyYW1lcyAoVGFiIEJhciBtb2RlKS4iCiAgIDpnbG9iYWwgdAogICA7OyBJdCdz IGRlZmluZWQgaW4gQy9jdXMtc3RhcnQsIHRoaXMgc3RvcHMgdGhlIGQtbS1tIG1hY3JvIGRlZmlu aW5nIGl0IGFnYWluLgogICA6dmFyaWFibGUgdGFiLWJhci1tb2RlCi0gIChsZXQgKCh2YWwgKGlm IHRhYi1iYXItbW9kZSAxIDApKSkKLSAgICAoZG9saXN0IChmcmFtZSAoZnJhbWUtbGlzdCkpCi0g ICAgICAoc2V0LWZyYW1lLXBhcmFtZXRlciBmcmFtZSAndGFiLWJhci1saW5lcyB2YWwpKQotICAg IDs7IElmIHRoZSB1c2VyIGhhcyBnaXZlbiBgZGVmYXVsdC1mcmFtZS1hbGlzdCcgYSBgdGFiLWJh ci1saW5lcycKLSAgICA7OyBwYXJhbWV0ZXIsIHJlcGxhY2UgaXQuCi0gICAgKGlmIChhc3NxICd0 YWItYmFyLWxpbmVzIGRlZmF1bHQtZnJhbWUtYWxpc3QpCi0gICAgICAgIChzZXRxIGRlZmF1bHQt ZnJhbWUtYWxpc3QKLSAgICAgICAgICAgICAgKGNvbnMgKGNvbnMgJ3RhYi1iYXItbGluZXMgdmFs KQotICAgICAgICAgICAgICAgICAgICAoYXNzcS1kZWxldGUtYWxsICd0YWItYmFyLWxpbmVzCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmYXVsdC1mcmFtZS1hbGlzdCkp KSkpCisKKyAgOzsgUmVjYWxjdWxhdGUgdGFiLWJhci1saW5lcyBmb3IgYWxsIGZyYW1lcworICAo dGFiLWJhci0tdXBkYXRlLXRhYi1iYXItbGluZXMpCisKICAgKHdoZW4gdGFiLWJhci1tb2RlCiAg ICAgKHRhYi1iYXItLWxvYWQtYnV0dG9ucykpCiAgIChpZiB0YWItYmFyLW1vZGUKQEAgLTI1Miwx NSArMjYxLDcgQEAgeW91IGNhbiB1c2UgdGhlIGNvbW1hbmQgYHRvZ2dsZS1mcmFtZS10YWItYmFy Jy4iCiAgICAgICAgICAoc2V0LWRlZmF1bHQgc3ltIHZhbCkKICAgICAgICAgIDs7IFByZWxvYWQg YnV0dG9uIGltYWdlcwogICAgICAgICAgKHRhYi1iYXItbW9kZSAxKQotICAgICAgICAgOzsgVGhl biBoYW5kbGUgZWFjaCBmcmFtZSBpbmRpdmlkdWFsbHkKLSAgICAgICAgIChkb2xpc3QgKGZyYW1l IChmcmFtZS1saXN0KSkKLSAgICAgICAgICAgKHNldC1mcmFtZS1wYXJhbWV0ZXIKLSAgICAgICAg ICAgIGZyYW1lICd0YWItYmFyLWxpbmVzCi0gICAgICAgICAgICAoaWYgKG9yIChlcSB2YWwgdCkK LSAgICAgICAgICAgICAgICAgICAgKGFuZCAobmF0bnVtcCB2YWwpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgKD4gKGxlbmd0aCAoZnVuY2FsbCB0YWItYmFyLXRhYnMtZnVuY3Rpb24gZnJhbWUp KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZhbCkpKQotICAgICAgICAgICAgICAgIDEg MCkpKSkKKyAgICAgICAgICh0YWItYmFyLS11cGRhdGUtdGFiLWJhci1saW5lcykpCiAgIDpncm91 cCAndGFiLWJhcgogICA6dmVyc2lvbiAiMjcuMSIpCiAKQEAgLTg1MiwxNiArODUzLDExIEBAIEFm dGVyIHRoZSB0YWIgaXMgY3JlYXRlZCwgdGhlIGhvb2tzIGluCiAgICAgICAocnVuLWhvb2std2l0 aC1hcmdzICd0YWItYmFyLXRhYi1wb3N0LW9wZW4tZnVuY3Rpb25zCiAgICAgICAgICAgICAgICAg ICAgICAgICAgIChudGggdG8taW5kZXggdGFicykpKQogCi0gICAgKGNvbmQKLSAgICAgKChlcSB0 YWItYmFyLXNob3cgdCkKLSAgICAgICh0YWItYmFyLW1vZGUgMSkpCi0gICAgICgoYW5kIChuYXRu dW1wIHRhYi1iYXItc2hvdykKLSAgICAgICAgICAgKD4gKGxlbmd0aCAoZnVuY2FsbCB0YWItYmFy LXRhYnMtZnVuY3Rpb24pKSB0YWItYmFyLXNob3cpCi0gICAgICAgICAgICh6ZXJvcCAoZnJhbWUt cGFyYW1ldGVyIG5pbCAndGFiLWJhci1saW5lcykpKQotICAgICAgKHByb2duCi0gICAgICAgICh0 YWItYmFyLS1sb2FkLWJ1dHRvbnMpCi0gICAgICAgICh0YWItYmFyLS1kZWZpbmUta2V5cykKLSAg ICAgICAgKHNldC1mcmFtZS1wYXJhbWV0ZXIgbmlsICd0YWItYmFyLWxpbmVzIDEpKSkpCisgICAg OzsgUmVjYWxjdWxhdGUgdGFiLWJhci1saW5lcyBhbmQgdXBkYXRlIGZyYW1lcworICAgICh0YWIt YmFyLS11cGRhdGUtdGFiLWJhci1saW5lcykKKyAgICAod2hlbiB0YWItYmFyLW1vZGUKKyAgICAg ICh0YWItYmFyLS1sb2FkLWJ1dHRvbnMpCisgICAgICAodGFiLWJhci0tZGVmaW5lLWtleXMpKQog CiAgICAgKGZvcmNlLW1vZGUtbGluZS11cGRhdGUpCiAgICAgKHVubGVzcyB0YWItYmFyLW1vZGUK QEAgLTk5NiwxMSArOTkyLDggQEAgZm9yIHRoZSBsYXN0IHRhYiBvbiBhIGZyYW1lIGlzIGRldGVy bWluZWQgYnkKICAgICAgICAgICAgICAgICB0YWItYmFyLWNsb3NlZC10YWJzKQogICAgICAgICAg IChzZXQtZnJhbWUtcGFyYW1ldGVyIG5pbCAndGFicyAoZGVscSBjbG9zZS10YWIgdGFicykpKQog Ci0gICAgICAgICh3aGVuIChhbmQgKG5vdCAoemVyb3AgKGZyYW1lLXBhcmFtZXRlciBuaWwgJ3Rh Yi1iYXItbGluZXMpKSkKLSAgICAgICAgICAgICAgICAgICAobmF0bnVtcCB0YWItYmFyLXNob3cp Ci0gICAgICAgICAgICAgICAgICAgKDw9IChsZW5ndGggKGZ1bmNhbGwgdGFiLWJhci10YWJzLWZ1 bmN0aW9uKSkKLSAgICAgICAgICAgICAgICAgICAgICAgdGFiLWJhci1zaG93KSkKLSAgICAgICAg ICAoc2V0LWZyYW1lLXBhcmFtZXRlciBuaWwgJ3RhYi1iYXItbGluZXMgMCkpCisgICAgICAgIDs7 IFJlY2FsY3VsYXRlIHRhYi1iYXItbGluZXMgYW5kIHVwZGF0ZSBmcmFtZXMKKyAgICAgICAgKHRh Yi1iYXItLXVwZGF0ZS10YWItYmFyLWxpbmVzKQogCiAgICAgICAgIChmb3JjZS1tb2RlLWxpbmUt dXBkYXRlKQogICAgICAgICAodW5sZXNzIHRhYi1iYXItbW9kZQpAQCAtMTAzNiwxMSArMTAyOSw4 IEBAIGZvciB0aGUgbGFzdCB0YWIgb24gYSBmcmFtZSBpcyBkZXRlcm1pbmVkIGJ5CiAgICAgICAg ICAgKHJ1bi1ob29rLXdpdGgtYXJncyAndGFiLWJhci10YWItcHJlLWNsb3NlLWZ1bmN0aW9ucyAo bnRoIGluZGV4IHRhYnMpIG5pbCkpKQogICAgICAgKHNldC1mcmFtZS1wYXJhbWV0ZXIgbmlsICd0 YWJzIChsaXN0IChudGggY3VycmVudC1pbmRleCB0YWJzKSkpCiAKLSAgICAgICh3aGVuIChhbmQg KG5vdCAoemVyb3AgKGZyYW1lLXBhcmFtZXRlciBuaWwgJ3RhYi1iYXItbGluZXMpKSkKLSAgICAg ICAgICAgICAgICAgKG5hdG51bXAgdGFiLWJhci1zaG93KQotICAgICAgICAgICAgICAgICAoPD0g KGxlbmd0aCAoZnVuY2FsbCB0YWItYmFyLXRhYnMtZnVuY3Rpb24pKQotICAgICAgICAgICAgICAg ICAgICAgdGFiLWJhci1zaG93KSkKLSAgICAgICAgKHNldC1mcmFtZS1wYXJhbWV0ZXIgbmlsICd0 YWItYmFyLWxpbmVzIDApKQorICAgICAgOzsgUmVjYWxjdWxhdGUgdGFiLWJhci1saW5lcyBhbmQg dXBkYXRlIGZyYW1lcworICAgICAgKHRhYi1iYXItLXVwZGF0ZS10YWItYmFyLWxpbmVzKQogCiAg ICAgICAoZm9yY2UtbW9kZS1saW5lLXVwZGF0ZSkKICAgICAgICh1bmxlc3MgdGFiLWJhci1tb2Rl Cg== --0000000000008d00d805bac7107f--