unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Adam Plaice <plaiceadam@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 29584@debbugs.gnu.org
Subject: bug#29584: imagemagick-types-inhibit does not result in correct image backend (minor)
Date: Wed, 6 Dec 2017 19:32:12 +0000	[thread overview]
Message-ID: <CAJw81dbWUnrqBjRSzq_cCCOyEe-0Cm-Vd-y2gJ9jZF+rEdB48g@mail.gmail.com> (raw)
In-Reply-To: <588tefbtn1.fsf@fencepost.gnu.org>

Thanks for the clarification.

As it's a deliberate change and to avoid over-complication that nobody
usually needs (if one generally dislikes the imagemagick backend then
one should use a version of emacs compiled without it, and in the very
rare case when one does need to change the backend on the fly, one can
just override image-toggle-display-image), leaving the code alone is
probably the best option.

However, I'd argue that the documentation should be updated — the
docstring of imagemagick-types-inhibit already contains extensive
warnings

"
If you change this without using customize, you must call
‘imagemagick-register-types’ afterwards.

If Emacs is compiled without ImageMagick support, this variable
has no effect.
"

so another sentence to the effect of "If emacs is compiled with
alternative image backends, in addition to ImageMagick support, this
variable also has no effect." wouldn't be out place (and since there
are already extensive warnings, creating an impression of
completeness, the absence of an important warning — having multiple sets
of backends is probably the most frequent situation on GNU/Linux —
would be confusing).





  reply	other threads:[~2017-12-06 19:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 21:12 bug#29584: imagemagick-types-inhibit does not result in correct image backend (minor) adam plaice
2017-12-06 18:25 ` Glenn Morris
2017-12-06 19:32   ` Adam Plaice [this message]
2017-12-06 20:17     ` Lars Ingebrigtsen
2018-04-14 13:37       ` Lars Ingebrigtsen
2018-04-15 11:26         ` Adam Plaice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJw81dbWUnrqBjRSzq_cCCOyEe-0Cm-Vd-y2gJ9jZF+rEdB48g@mail.gmail.com \
    --to=plaiceadam@gmail.com \
    --cc=29584@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).