unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "kassick@gmail.com" <kassick@gmail.com>
To: Andrea Corallo <acorallo@gnu.org>
Cc: 71654-done@debbugs.gnu.org
Subject: bug#71654: [PATCH] Fix display-buffer-override-next-command
Date: Wed, 19 Jun 2024 18:54:35 -0300	[thread overview]
Message-ID: <CAJvJD8i_OHd+0i3CzYw+dH_k7De-wqmsNofzMUozwkJafEo10g@mail.gmail.com> (raw)
In-Reply-To: <yp1wmmkfwku.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Awesome!

Any chance of cherry-picking it on emacs-29?

Em qua., 19 de jun. de 2024 às 18:32, Andrea Corallo <acorallo@gnu.org>
escreveu:

> "kassick@gmail.com" <kassick@gmail.com> writes:
>
> > When display-buffer-overriding-action's car is set to a function instead
> of a list, display-buffer-override-next-command
> > must ensure that the car is a list before pushing a new element to it,
> otherwise the car will become a itself a cons-cell
> > and the clear-fun will trigger a wrong-type-argumen error when trying to
> delq the action.
> >
> > The error can be triggered by using some minor mode that updates
> display-buffer-override-next-command (such as
> > purpose-mode) and then calling other-window-prefix.
>
> Hi Rodrigo,
>
> the patch LGTM so I applied it after some indentation massage to master.
>
> Closing then, happy to reopen if some more work is needed.
>
> Thanks
>
>   Andrea
>


-- 
Rodrigo Virote Kassick
------------------------------------------------------------

[-- Attachment #2: Type: text/html, Size: 1643 bytes --]

  reply	other threads:[~2024-06-19 21:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 15:20 bug#71654: [PATCH] Fix display-buffer-override-next-command kassick
2024-06-19 21:17 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-19 21:53   ` kassick
2024-06-19 21:32 ` Andrea Corallo
2024-06-19 21:54   ` kassick [this message]
2024-06-19 22:11     ` Andrea Corallo
2024-06-19 22:16       ` kassick
2024-06-20  7:55         ` Andrea Corallo
2024-06-20  5:15       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJvJD8i_OHd+0i3CzYw+dH_k7De-wqmsNofzMUozwkJafEo10g@mail.gmail.com \
    --to=kassick@gmail.com \
    --cc=71654-done@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).