unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: PJ Weisberg <pj@irregularexpressions.net>
To: 9030@debbugs.gnu.org
Subject: bug#9030: `where-is' doesn't play well `with with-output-to-string'
Date: Fri, 8 Jul 2011 19:39:24 -0700	[thread overview]
Message-ID: <CAJsNXT=2Cf=FFBoL8D3EkgCYGLKKODmMj_F0sehdDQHzbcWRqA@mail.gmail.com> (raw)

This expression:

(with-output-to-string
  (where-is 'yank))

returns nil, and prints a message in the echo area.  This one-line
change fixes it:

diff --git a/lisp/help.el b/lisp/help.el
index e6496f6..53e99e7 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -527,7 +527,7 @@ If INSERT (the prefix arg) is non-nil, insert the
message in the buffer."
   (unless definition (error "No command"))
   (let ((func (indirect-function definition))
         (defs nil)
-        (standard-output (if insert (current-buffer) t)))
+        (standard-output (if insert (current-buffer) standard-output)))
     ;; In DEFS, find all symbols that are aliases for DEFINITION.
     (mapatoms (lambda (symbol)
 		(and (fboundp symbol)





             reply	other threads:[~2011-07-09  2:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-09  2:39 PJ Weisberg [this message]
2011-07-12 22:33 ` bug#9030: `where-is' doesn't play well `with with-output-to-string' Glenn Morris
2011-07-13  3:54   ` Stefan Monnier
2011-07-13  4:44     ` PJ Weisberg
2011-08-07 17:21       ` Stefan Monnier
2011-09-13  7:18 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJsNXT=2Cf=FFBoL8D3EkgCYGLKKODmMj_F0sehdDQHzbcWRqA@mail.gmail.com' \
    --to=pj@irregularexpressions.net \
    --cc=9030@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).