From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Date: Sat, 2 Dec 2017 00:22:17 -0800 Message-ID: References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> <83mv323kvx.fsf@gnu.org> <87a7z1vb3z.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="94eb2c0853faf1d7c9055f572e4c" X-Trace: blaine.gmane.org 1512202995 23138 195.159.176.226 (2 Dec 2017 08:23:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Dec 2017 08:23:15 +0000 (UTC) Cc: 29465@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 02 09:23:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL34j-0005VC-VM for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Dec 2017 09:23:06 +0100 Original-Received: from localhost ([::1]:34752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL34q-0003Nc-RY for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Dec 2017 03:23:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL34k-0003NM-LA for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 03:23:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eL34g-00045b-CV for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 03:23:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eL34g-00045R-8I for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 03:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eL34f-0007HD-VC for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2017 03:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151220294627925 (code B ref 29465); Sat, 02 Dec 2017 08:23:01 +0000 Original-Received: (at 29465) by debbugs.gnu.org; 2 Dec 2017 08:22:26 +0000 Original-Received: from localhost ([127.0.0.1]:40959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL345-0007GK-QM for submit@debbugs.gnu.org; Sat, 02 Dec 2017 03:22:26 -0500 Original-Received: from mail-qk0-f171.google.com ([209.85.220.171]:45842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL343-0007G7-G4 for 29465@debbugs.gnu.org; Sat, 02 Dec 2017 03:22:23 -0500 Original-Received: by mail-qk0-f171.google.com with SMTP id d141so15972837qkc.12 for <29465@debbugs.gnu.org>; Sat, 02 Dec 2017 00:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LQC17Utbr59x+Vp7BfKjbGtCLGlyP+L/JtJHMrroPA4=; b=JrefIQbgkcX0vv++m/l80Ar17yo5FFAM8fFoEXF0uPZgdAUyV95d6a7lrIYc2N9Ujs coLmBlzt4YbIq6zWIwdrQW38epQKsSC8XzJb6WvrqJN5vcWvCOfYqCkjOeLo6DZRFVIF 4pMiCqYgxheFMIMUK8YBbVqt1VZKcZsQhxzsTuLvXJ0U2Kttv7d0jqcv0mxP3HB40IVZ /l80zyKYk9mlI2u8yeKQ68AtcX5+wu8q2Z3LfmuEnhULeRQ0gVqnx6ZtghvJRDYmcTyN pvvii+6ZE6EhbVczrY9gU6N/vG3q8/egDuLZ7sPSkECsmJ8vaMxOQCprnUZ16NCo07d0 ddAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LQC17Utbr59x+Vp7BfKjbGtCLGlyP+L/JtJHMrroPA4=; b=hoFbY0s4Rh8FHF66nxyzYzOoIaoDmzHPgLnmsI3YJG2MVwsJCj2qf6I9vQktAMC2Ob aLwrpjHbsFp92dLLbNJ3jPFnK6iRcOteIeRcl8kUhzsan/z5ZAF3WnyNKG4LWx7B8UDl eiD8uj9rNUo9H9ea2KCDNhXB9ZZPRhwwstl3I1kJAtqpGcxHOk0WFUGyuzGlnr5Huhxf FniupTXarsfMZo/BEFajhpACknRBMDlz5dPYBNtOLMHDoU5feNb3e7MhNu9c+HgbBdMX 6MSwdglzV+W0jnPgp7aGF6SaPLqrM5oswIzkDXedaE+q9jmVaa35k7gxectlkWu0Mi5D 08Yg== X-Gm-Message-State: AKGB3mJq2Ch1ZrKg9YOeIfkZ8Y1zgNyPuRfkN0Ex85+QMZlKG/v27mW6 /kRk2Sf3YPB0SRcbT1cNhLiVNKU8Mb9Q1Jl4wnY= X-Google-Smtp-Source: AGs4zMZw0NACikVxz2txkQSggavkw0afNIOp+nA3Dvq+Mh3qGHH3qKGX/5mthJOvd1LHflDMXw3sSYG3yf2qqOPqlmI= X-Received: by 10.55.142.3 with SMTP id q3mr11950743qkd.276.1512202937930; Sat, 02 Dec 2017 00:22:17 -0800 (PST) Original-Received: by 10.237.52.161 with HTTP; Sat, 2 Dec 2017 00:22:17 -0800 (PST) In-Reply-To: <87a7z1vb3z.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140617 Archived-At: --94eb2c0853faf1d7c9055f572e4c Content-Type: text/plain; charset="UTF-8" On Fri, Dec 1, 2017 at 11:32 PM, Tino Calancha wrote: > Allen Li writes: > > Thank you for the new patches Allen! > I don't have strong opinions on this thread; probably because > I am already in Christmass mode or something... Anyway, I think > you guys are discussing pretty well the thing! > > I have just two comments in the second patch: >> +;;;###autoload >> +(defcustom dired-confirm-shell-command t >> + "Whether to prompt for confirmation for Dired shell commands. >> +If t, prompt" >> + :type '(choice (const :tag "No restrictions" nil) >> + (const :tag "When point is on a file name initially, search file names" dwim) >> + (const :tag "Always search in file names" t)) >> + :group 'dired >> + :version "26.0") > ^^^^ > > * Version must be 26.1 > * The :type looks unrelated with the option. > Maybe better something like this: > > :type '(choice (const :tag "Ask confirmation" t) > (const :tag "Never ask confirmation" nil)) >> + >> - (string-match regexp res)))) >> + (when >> + dired-confirm-shell-command >> + (let ((res cmd) > You might put the option in the same line as `when', i.e.: > (when dired-confirm-shell-command Thanks, attached new second patch. --94eb2c0853faf1d7c9055f572e4c Content-Type: text/x-patch; charset="UTF-8"; name="0002-Add-option-for-controlling-dired-do-shell-command-pr.patch" Content-Disposition: attachment; filename="0002-Add-option-for-controlling-dired-do-shell-command-pr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jap2knz80 RnJvbSAzYTY4NjE1NTJkMmE0OWUwNTJiNzZiMTBkNWI3N2I5Y2UyZWVkMDE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBGcmksIDEgRGVjIDIwMTcgMjI6MjI6NTMgLTA4MDAKU3ViamVjdDogW1BBVENIIDIvMl0g QWRkIG9wdGlvbiBmb3IgY29udHJvbGxpbmcgZGlyZWQtZG8tc2hlbGwtY29tbWFuZCBwcm9tcHQK CiogZG9jL2VtYWNzL2RpcmVkLnRleGkgKFNoZWxsIENvbW1hbmRzIGluIERpcmVkKTogRG9jdW1l bnQgb3B0aW9uCiogbGlzcC9kaXJlZC1hdXguZWwgKGRpcmVkLWNvbmZpcm0tc2hlbGwtY29tbWFu ZCk6IEFkZCBvcHRpb24KKGRpcmVkLWRvLXNoZWxsLWNvbW1hbmQpOiBDaGVjayBvcHRpb24gYmVm b3JlIHByb21wdGluZwotLS0KIGRvYy9lbWFjcy9kaXJlZC50ZXhpIHwgIDQgKysrLQogbGlzcC9k aXJlZC1hdXguZWwgICAgfCAyNCArKysrKysrKysrKysrKysrKy0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mv ZW1hY3MvZGlyZWQudGV4aSBiL2RvYy9lbWFjcy9kaXJlZC50ZXhpCmluZGV4IDkzNDhlZjUwNDIu LjRjMDgyNmUxYTMgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9kaXJlZC50ZXhpCisrKyBiL2RvYy9l bWFjcy9kaXJlZC50ZXhpCkBAIC04NjYsNiArODY2LDcgQEAgU2hlbGwgQ29tbWFuZHMgaW4gRGly ZWQKIEBmaW5kZXggZGlyZWQtZG8tc2hlbGwtY29tbWFuZAogQGtpbmRleCAhIEByeyhEaXJlZCl9 CiBAa2luZGV4IFggQHJ7KERpcmVkKX0KK0B2aW5kZXggZGlyZWQtY29uZmlybS1zaGVsbC1jb21t YW5kCiBUaGUgRGlyZWQgY29tbWFuZCBAa2JkeyF9IChAY29kZXtkaXJlZC1kby1zaGVsbC1jb21t YW5kfSkgcmVhZHMgYQogc2hlbGwgY29tbWFuZCBzdHJpbmcgaW4gdGhlIG1pbmlidWZmZXIsIGFu ZCBydW5zIHRoYXQgc2hlbGwgY29tbWFuZCBvbgogb25lIG9yIG1vcmUgZmlsZXMuICBUaGUgZmls ZXMgdGhhdCB0aGUgc2hlbGwgY29tbWFuZCBvcGVyYXRlcyBvbiBhcmUKQEAgLTkwMiw3ICs5MDMs OCBAQCBTaGVsbCBDb21tYW5kcyBpbiBEaXJlZAogSWYgeW91IHdhbnQgdG8gdXNlIEBzYW1weyp9 IGFzIGEgc2hlbGwgd2lsZGNhcmQgd2l0aCB3aGl0ZXNwYWNlIGFyb3VuZAogaXQsIHdyaXRlIEBz YW1weyoiIn0uICBJbiB0aGUgc2hlbGwsIHRoaXMgaXMgZXF1aXZhbGVudCB0byBAc2FtcHsqfTsK IGJ1dCBzaW5jZSB0aGUgQHNhbXB7Kn0gaXMgbm90IHN1cnJvdW5kZWQgYnkgd2hpdGVzcGFjZSwg RGlyZWQgZG9lcyBub3QKLXRyZWF0IGl0IHNwZWNpYWxseS4KK3RyZWF0IGl0IHNwZWNpYWxseS4g IEVtYWNzIHdpbGwgcHJvbXB0IGZvciBjb25maXJtYXRpb24gaWYgeW91IGRvCit0aGlzLCB1bmxl c3MgQGNvZGV7ZGlyZWQtY29uZmlybS1zaGVsbC1jb21tYW5kfSBpcyBAY29kZXtuaWx9LgogCiBA aXRlbQogT3RoZXJ3aXNlLCBpZiB0aGUgY29tbWFuZCBzdHJpbmcgY29udGFpbnMgQHNhbXB7P30g c3Vycm91bmRlZCBieQpkaWZmIC0tZ2l0IGEvbGlzcC9kaXJlZC1hdXguZWwgYi9saXNwL2RpcmVk LWF1eC5lbAppbmRleCA1N2ViMjE2MjMxLi5jOWYyNDBkZDQ2IDEwMDY0NAotLS0gYS9saXNwL2Rp cmVkLWF1eC5lbAorKysgYi9saXNwL2RpcmVkLWF1eC5lbApAQCAtNjQ5LDYgKzY0OSwxNSBAQCBk aXJlZC1yZWFkLXNoZWxsLWNvbW1hbmQKICAgICAgIChkaXJlZC1tYXJrLXBvcC11cCBuaWwgJ3No ZWxsIGZpbGVzCiAJCQkgJ3JlYWQtc2hlbGwtY29tbWFuZCBwcm9tcHQgbmlsIG5pbCkpKSkKIAor Ozs7IyMjYXV0b2xvYWQKKyhkZWZjdXN0b20gZGlyZWQtY29uZmlybS1zaGVsbC1jb21tYW5kIHQK KyAgIldoZXRoZXIgdG8gcHJvbXB0IGZvciBjb25maXJtYXRpb24gZm9yIOKAmGRpcmVkLWRvLXNo ZWxsLWNvbW1hbmTigJkuCitJZiB0LCBwcm9tcHQgZm9yIGNvbmZpcm1hdGlvbiBpZiB0aGUgY29t bWFuZCBjb250YWlucyBwb3RlbnRpYWxseQorZGFuZ2Vyb3VzIGNoYXJhY3RlcnMuICBJZiBuaWws IG5ldmVyIHByb21wdCBmb3IgY29uZmlybWF0aW9uLiIKKyAgOnR5cGUgJ2Jvb2xlYW4KKyAgOmdy b3VwICdkaXJlZAorICA6dmVyc2lvbiAiMjYuMSIpCisKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4g ZGlyZWQtZG8tYXN5bmMtc2hlbGwtY29tbWFuZCAoY29tbWFuZCAmb3B0aW9uYWwgYXJnIGZpbGUt bGlzdCkKICAgIlJ1biBhIHNoZWxsIGNvbW1hbmQgQ09NTUFORCBvbiB0aGUgbWFya2VkIGZpbGVz IGFzeW5jaHJvbm91c2x5LgpAQCAtNzM3LDEzICs3NDYsMTQgQEAgZGlyZWQtZG8tc2hlbGwtY29t bWFuZAogICAgICAgZmlsZXMpKSkKICAgKGNsLWZsZXQgKChuZWVkLWNvbmZpcm0tcAogICAgICAg ICAgICAgIChjbWQgc3RyKQotICAgICAgICAgICAgIChsZXQgKChyZXMgY21kKQotICAgICAgICAg ICAgICAgICAgIChyZWdleHAgKHJlZ2V4cC1xdW90ZSBzdHIpKSkKLSAgICAgICAgICAgICAgIDs7 IERyb3AgYWxsID8gYW5kICogc3Vycm91bmRlZCBieSBzcGFjZXMgYW5kIGA/YC4KLSAgICAgICAg ICAgICAgICh3aGlsZSAoYW5kIChzdHJpbmctbWF0Y2ggcmVnZXhwIHJlcykKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgIChkaXJlZC0tc3Rhci1vci1xbWFyay1wIHJlcyBzdHIpKQotICAgICAg ICAgICAgICAgICAoc2V0cSByZXMgKHJlcGxhY2UtbWF0Y2ggIiIgdCB0IHJlcyAyKSkpCi0gICAg ICAgICAgICAgICAoc3RyaW5nLW1hdGNoIHJlZ2V4cCByZXMpKSkpCisgICAgICAgICAgICAgKHdo ZW4gZGlyZWQtY29uZmlybS1zaGVsbC1jb21tYW5kCisgICAgICAgICAgICAgICAobGV0ICgocmVz IGNtZCkKKyAgICAgICAgICAgICAgICAgICAgIChyZWdleHAgKHJlZ2V4cC1xdW90ZSBzdHIpKSkK KyAgICAgICAgICAgICAgICAgOzsgRHJvcCBhbGwgPyBhbmQgKiBzdXJyb3VuZGVkIGJ5IHNwYWNl cyBhbmQgYD9gLgorICAgICAgICAgICAgICAgICAod2hpbGUgKGFuZCAoc3RyaW5nLW1hdGNoIHJl Z2V4cCByZXMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlZC0tc3Rhci1vci1x bWFyay1wIHJlcyBzdHIpKQorICAgICAgICAgICAgICAgICAgIChzZXRxIHJlcyAocmVwbGFjZS1t YXRjaCAiIiB0IHQgcmVzIDIpKSkKKyAgICAgICAgICAgICAgICAgKHN0cmluZy1tYXRjaCByZWdl eHAgcmVzKSkpKSkKICAgKGxldCogKChvbi1lYWNoIChub3QgKGRpcmVkLS1zdGFyLW9yLXFtYXJr LXAgY29tbWFuZCAiKiIgJ2tlZXApKSkKIAkgKG5vLXN1YnN0IChub3QgKGRpcmVkLS1zdGFyLW9y LXFtYXJrLXAgY29tbWFuZCAiPyIgJ2tlZXApKSkKICAgICAgICAgIDs7IEdldCBjb25maXJtYXRp b24gZm9yIHdpbGRjYXJkcyB0aGF0IG1heSBoYXZlIGJlZW4gbWVhbnQKLS0gCjIuMTUuMQoK --94eb2c0853faf1d7c9055f572e4c--