From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#29575: 25.3; Secret Service API treats labels as unique Date: Mon, 4 Dec 2017 21:42:26 -0800 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1512452592 13742 195.159.176.226 (5 Dec 2017 05:43:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Dec 2017 05:43:12 +0000 (UTC) To: 29575@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 05 06:43:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM60Y-0003Ln-Gw for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Dec 2017 06:43:06 +0100 Original-Received: from localhost ([::1]:46561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM60f-0007ch-Su for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Dec 2017 00:43:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM60V-0007cJ-KT for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:43:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM60U-0004vx-Jd for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:43:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eM60U-0004vt-FL for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eM60U-0007nu-9J for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Dec 2017 05:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.151245255929968 (code B ref -1); Tue, 05 Dec 2017 05:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Dec 2017 05:42:39 +0000 Original-Received: from localhost ([127.0.0.1]:46267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM606-0007nI-PP for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM605-0007n4-1x for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM5zy-0004qX-Pi for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:31 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eM5zy-0004qT-Ls for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM5zx-0007Ls-EK for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM5zw-0004os-IR for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:29 -0500 Original-Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:41474) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eM5zw-0004oi-Ck for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:28 -0500 Original-Received: by mail-qt0-x22c.google.com with SMTP id i40so26581194qti.8 for ; Mon, 04 Dec 2017 21:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=rmqDLKrtrr2Sy1M2TlEAV8cAB1751+eqGSUNHPYgWJI=; b=Ql4VMVHd26vcaPe8qxTvHCpLvVqhlhyUC7va9wulG4vyDPLt6Jk0145H8zdsCHAcdv oxmKkiqBLDO3qJR9Vfj0otw8T75LhCd8KcQ5PrUWu0wFJkrAxzfLWA7RGBnm34XoRndT nWRClgfbKx0VQknQtAAy8jD2cg1zC9zsGboIXYICeZKE01jdaiX/4IJIyRFluJP0mRD6 y6k0Ov7nX7h5nNsM50V6XJklu3kzOdHv0EdgwRqhTwTrmQW4OAJ0EZiPsqTAJ9IXHmL2 /stOXAO8Xj9XuKVKS97RpyrQrsWOc3PL760rjkiuxT/AioE0bn88ATan3orUuZAjVQ24 Hbpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rmqDLKrtrr2Sy1M2TlEAV8cAB1751+eqGSUNHPYgWJI=; b=KNyeQnujXjOzoSeS95P4Jwl+u6ABZIOlaNNpBJFjXChVI14tfDROBDAY4sAoef4IdU s8GGZRTb91jIhWT/Yz6ED2HQgcsZs9tVzxvjheZ1q8Y90zyl5MdTuAGxXStiLo1csmx+ 5kd8E94/HapciaJiCxb3iRp/Xm5ZEh04S0syc9jR9wVYcNKMI0x37vsnHGabEb4SGAzn m5z2ms2soLsOudwe40pqmCsve6seiFzoeeT4QjyHRoWOoEMiUWK1oHihgkv4nYMnt+qN veuqME6mKkHg2kdJ3xeLJgkY6gPhmI2mFxJeCm5ue52QP7kng47GvLkxo2ELIEzSBy26 BFlg== X-Gm-Message-State: AKGB3mKOlCkd+vr0osJY7zyqP01hgbaTx7kpDPCs3DPobNHhVgFIuRXF VU81yr9mZwri+YJySbKIqrqSHiiAjGC0HsYBn4ehn2Db X-Google-Smtp-Source: AGs4zMZAkPACYnzW97As5qrjm1kyA6HRN2F89nUdlXUcw1jWGJ7GXx+hNKVV+ssDmEdnp1iHGIbf9o1Fi+d3A5+DhEA= X-Received: by 10.55.18.134 with SMTP id 6mr22183642qks.136.1512452547269; Mon, 04 Dec 2017 21:42:27 -0800 (PST) Original-Received: by 10.237.55.36 with HTTP; Mon, 4 Dec 2017 21:42:26 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140716 Archived-At: The Secret Service API [1] treats labels as unique keys for each secret item in a collection. However, labels are not required to be unique in a collection [2], the attribute key/value pairs are. It is perfectly valid to have multiple secrets with the same label, in which case Emacs's Secret Service API is not able to retrieve all but the most recently created (?) secret. This can be demonstrated by creating two such secrets using the secret-tool utility: secret-tool store --label=Test1 id foo secret-tool store --label=Test1 id bar You can see how the attributes uniquely identify secrets: secret-tool store --label=Test2 id foo # This overwrites the first secret. Implementation idea: Use attribute plists instead of label strings to uniquely identify secret items. This would require creating a new copy of the API to preserve backward compatibility. [1]: https://www.gnu.org/software/emacs/manual/html_node/auth/Secret-Service-API.html [2]: https://specifications.freedesktop.org/secret-service/re02.html In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES