From: Allen Li <vianchielfaura@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 29924@debbugs.gnu.org
Subject: bug#29924: [PATCH] Preserve special abbrev properties when writing
Date: Fri, 26 Jan 2018 18:48:02 -0800 [thread overview]
Message-ID: <CAJr1M6dQKUGxmZ96jCJJoF7hLk=64XZ54SwTZejkc+4qd6yx1w@mail.gmail.com> (raw)
In-Reply-To: <87zi50kq31.fsf@users.sourceforge.net>
On Fri, Jan 26, 2018 at 6:12 PM, Noam Postavsky
<npostavs@users.sourceforge.net> wrote:
> Allen Li <vianchielfaura@gmail.com> writes:
>
>> Apologies, the original patch is incorrect because define-abbrev
>> requires passing :count as a keyword argument unlike the obsolete
>> calling convention.
>>
>> Attached is a new patch, which unfortunately does not preserve the old
>> abbrev file writing format. However, any recent version of Emacs will
>> be able to accept this format for define-abbrev, and the previously
>> written abbrev file format is documented as obsolete, so now is as
>> good a time as any.
>
> I think it would be helpful to have a basic test to ensure we preserve
> round-tripping.
What round-tripping are you referring to?
next prev parent reply other threads:[~2018-01-27 2:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 3:47 bug#29924: 25.3; write-abbrev-file does not preserve abbrev properties Allen Li
2018-01-01 4:18 ` bug#29924: [PATCH] Preserve special abbrev properties when writing Allen Li
2018-01-23 8:19 ` Allen Li
2018-01-27 2:12 ` Noam Postavsky
2018-01-27 2:48 ` Allen Li [this message]
2018-01-27 12:19 ` Noam Postavsky
2018-01-30 21:49 ` Allen Li
2018-02-01 2:12 ` Noam Postavsky
2018-02-16 5:40 ` Allen Li
2018-02-17 14:11 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJr1M6dQKUGxmZ96jCJJoF7hLk=64XZ54SwTZejkc+4qd6yx1w@mail.gmail.com' \
--to=vianchielfaura@gmail.com \
--cc=29924@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).