From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#30056: 25.3; battery-mode-line-string missing leading space Date: Wed, 10 Jan 2018 15:26:42 -0800 Message-ID: References: <83fu7d68bf.fsf@gnu.org> <834lnt5ybx.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1515626728 22130 195.159.176.226 (10 Jan 2018 23:25:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 Jan 2018 23:25:28 +0000 (UTC) Cc: 30056@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 11 00:25:24 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZPk7-0004dR-HF for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jan 2018 00:25:12 +0100 Original-Received: from localhost ([::1]:49013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZPm7-00084C-0C for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jan 2018 18:27:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZPly-000830-GU for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 18:27:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZPlu-0006WO-Ez for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 18:27:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43605) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZPlt-0006VW-W2 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 18:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eZPlt-0007jU-KD for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 18:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2018 23:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30056 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30056-submit@debbugs.gnu.org id=B30056.151562681229709 (code B ref 30056); Wed, 10 Jan 2018 23:27:01 +0000 Original-Received: (at 30056) by debbugs.gnu.org; 10 Jan 2018 23:26:52 +0000 Original-Received: from localhost ([127.0.0.1]:51502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZPlk-0007j7-Gs for submit@debbugs.gnu.org; Wed, 10 Jan 2018 18:26:52 -0500 Original-Received: from mail-qk0-f181.google.com ([209.85.220.181]:41907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZPlg-0007is-Ih for 30056@debbugs.gnu.org; Wed, 10 Jan 2018 18:26:48 -0500 Original-Received: by mail-qk0-f181.google.com with SMTP id a8so1796560qkb.8 for <30056@debbugs.gnu.org>; Wed, 10 Jan 2018 15:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZyoqIc9wxmZKg/g0Uleh7f/j43za+qziWYMs1Irevds=; b=U6OKHyuY4inlv7Yex9fk+TmeUOqKRXUUqkseM+/gC4qqqzoGvwWXTi/ENbPECi0wZr TvFkTZ0a5K1nnTi/btn1BzzJCTUG7WG9TRaIKa7Dv4B4UGvEECmg8GYTOo8ngqWfSqQ1 ZvwmqXVvcQwu3lHdDTSwOoMwndPeGahqnZ7t58dlapTYhgmul21bg1jNTTboLKzb4l05 m2fVAFIwxj90gEMR6yfVt5+oUmWpBKBYgVx1g29GBApYSddWfshDWsJ/tVqBJxoUO/BW Y/RrzrxrZJPpPhe++fMGP8TDBXVrH5Im5GaiNlZIrBHGzKIyBud3gwRpisTBR//fTUmZ gTVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZyoqIc9wxmZKg/g0Uleh7f/j43za+qziWYMs1Irevds=; b=Yvj8N8yDoQkU+Jn1+S06cqFqvm0ziZ6tCpdVP8Ou4rO0IINejARqPRx16TpzB5m17K 9R5AjsOSAiplFhK+/f9Aok1oTiYYqhWQeIejU7OaDLYuzwt6IlrjFGeu9BJBkHRztD4+ NtWYvVVkxWK6xpnDG0PqWIxWQEEjCaFDUd4kQaws6VrnBJEhbL0aeD/3sCY0oZXv+jz+ SpKOvOJDH/OjgeLVFWDRvRAxVd6Hx7AOTtECkZ/1KENVtekMJlMi3OiL0AEgsr3unsbo Et7cXgKrKwfkHWt8XSi7dkBZdb/vHicXpaoCsiFK0M5k505x62KjaSa6/Vptdjj6mxlb KR4g== X-Gm-Message-State: AKwxytcAuDYEqqTBwyilE70sZEU6R5TOIbS62BQo5Rt5DZzoYe/BW5hO lrHTq4rRjAI7bslK+xf66GUZR72LCMF0vTomZik= X-Google-Smtp-Source: ACJfBou7mgF5vzGDjVtPBcrt6MzrL5yA0jzABiNBr2/7fka9Y7TK9ULKXIgTRi6xFayK3LclfvP8Jd+DQrCjvIpL6Zo= X-Received: by 10.237.39.214 with SMTP id m22mr26801163qtg.303.1515626802764; Wed, 10 Jan 2018 15:26:42 -0800 (PST) Original-Received: by 10.237.55.36 with HTTP; Wed, 10 Jan 2018 15:26:42 -0800 (PST) In-Reply-To: <834lnt5ybx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142014 Archived-At: On Wed, Jan 10, 2018 at 11:05 AM, Eli Zaretskii wrote: >> From: Glenn Morris >> Cc: Allen Li , 30056@debbugs.gnu.org >> Date: Wed, 10 Jan 2018 12:06:47 -0500 >> >> M-x display-time-mode >> M-x display-battery-mode >> >> -> 9.05AM 0.45 Mail[100.0%] >> >> See also https://debbugs.gnu.org/18164 > > We don't do this consistently in the modes which use > global-mode-string: some of them leave a blank at the beginning, > others (the majority, AFACT) don't. There's not much space on the > mode line, so I'm not sure which way is better. The standard for minor mode strings is to include a leading space, right? That seems like the right approach for global-mode-strings, which also follows an "append" pattern like minor modes. >From what I can grok, the general standard of the mode line is to use spaces at the end for "top level" mode line items (mode-line-modes, mode-line-position) and spaces at the beginning for sub items (minor modes, the parts inside mode-line-position). In any case, Emacs packages should probably be consistent, and currently display-battery-mode and display-time-mode are inconsistent. I don=E2=80=99t know which other modes use global-mode-string; is display-t= ime mode the only outlier? > But if we want to have a separation there, would it make sense to do > this in bindings.el, so that global-mode-string is always separated by > a blank from the preceding text, and modes don't have to remember this > gork?