From: Chris Findeisen <cfindeisen@google.com>
To: 30943@debbugs.gnu.org
Subject: bug#30943: save-hist creates massive cache file
Date: Sun, 25 Mar 2018 19:11:21 +0000 [thread overview]
Message-ID: <CAJqN1i_KwD1MWaAH+Pufq+2+U7QW5k7GBh8YVv0GExjx=SHrJQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
save-hist-additional-variables never get truncated by save-hist, leading
to a massive cache file and slowdown. Practically, this matters when the
cache file silently grows to 1/2 a GB, and emacs begins randomly freezing.
history-length is supposed to keep a limit on the max history for
save-hist-additional-variables, but it doesn't.
In the savehist-save function:
(dolist (symbol savehist-minibuffer-history-variables)
(when (and (boundp symbol)
(not (memq symbol savehist-ignored-variables)))
(let ((value (savehist-trim-history (symbol-value symbol)))
;;....
))))
(dolist (symbol savehist-additional-variables)
(when (boundp symbol)
(let ((value (symbol-value symbol)))
(when (savehist-printable value)
;; ...
))))
As you can see, the save-hist-trim-history fn is not called in the
second code block.
[-- Attachment #2: Type: text/html, Size: 16919 bytes --]
next reply other threads:[~2018-03-25 19:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 19:11 Chris Findeisen [this message]
2018-03-26 14:59 ` bug#30943: save-hist creates massive cache file Eli Zaretskii
2018-03-27 2:50 ` Chris Findeisen
2018-03-27 19:44 ` Glenn Morris
2018-03-29 16:27 ` Chris Findeisen
2018-03-29 17:09 ` Eli Zaretskii
2018-03-29 18:08 ` Glenn Morris
2018-03-29 18:47 ` Eli Zaretskii
2018-03-30 5:25 ` Glenn Morris
2018-03-30 8:14 ` Eli Zaretskii
2022-02-15 10:29 ` Lars Ingebrigtsen
2018-03-27 19:12 ` Glenn Morris
2018-03-29 10:49 ` Eli Zaretskii
2018-03-29 17:12 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJqN1i_KwD1MWaAH+Pufq+2+U7QW5k7GBh8YVv0GExjx=SHrJQ@mail.gmail.com' \
--to=cfindeisen@google.com \
--cc=30943@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).