From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dario Gjorgjevski Newsgroups: gmane.emacs.bugs Subject: bug#35452: Fwd: bug#35452: Line number faces should check for remapping of the default face Date: Thu, 16 May 2019 11:05:06 +0200 Message-ID: References: <878svvehl1.fsf@gmail.com> <8336lvoqss.fsf@gnu.org> <87a7fmixj1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="243756"; mail-complaints-to="usenet@blaine.gmane.org" To: 35452@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 16:31:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRHPh-0011JZ-Ho for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 16:31:17 +0200 Original-Received: from localhost ([127.0.0.1]:59055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRHPg-0006Wv-Hr for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2019 10:31:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRHPW-0006VE-UZ for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 10:31:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRHPT-0001tE-FD for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 10:31:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRHPS-0001rt-Ib for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 10:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRHPS-0006L6-E0 for bug-gnu-emacs@gnu.org; Thu, 16 May 2019 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dario Gjorgjevski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2019 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35452-submit@debbugs.gnu.org id=B35452.155801704124337 (code B ref 35452); Thu, 16 May 2019 14:31:02 +0000 Original-Received: (at 35452) by debbugs.gnu.org; 16 May 2019 14:30:41 +0000 Original-Received: from localhost ([127.0.0.1]:56008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRHP6-0006KS-Ut for submit@debbugs.gnu.org; Thu, 16 May 2019 10:30:41 -0400 Original-Received: from mail-pl1-f182.google.com ([209.85.214.182]:43893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRCKj-0006SN-Av for 35452@debbugs.gnu.org; Thu, 16 May 2019 05:05:52 -0400 Original-Received: by mail-pl1-f182.google.com with SMTP id n8so1287980plp.10 for <35452@debbugs.gnu.org>; Thu, 16 May 2019 02:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=RjBiNjpMOcgzT0nqa9NnHYxL6tUsoVOI0enrB28zScU=; b=QbX1iG2vV9gHi5/VotGHn/yr+LiT0t/1dUIEDtmVycbE5bUBf3qqBW2rY0Fxx/xzh7 jRtCYyH+1a27bpcwNwwWIEx1EqMjy/bZdiB7uza4bXoSrMYQaDEHOxVtzEhvXGYwSt4B qMFXYg02NpVgyuclGZa8IeakjW7DiPwsCBmkP1SW3nD9vazWbXcBsg3fMHEWvL7c9TyR bnLf10+rmL2zPOEyQKbav+CCSrx2hJ3fAWEEjJkQg/nb557cJMbRbsHz7pI9dKFwHu2o wIV7Q72ItXtYmmUaeiVfVkqSB+SVNZtJEJH9yI+ZTFV81xkz1TS2J9tWsWEZ9pvzxLt9 u19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=RjBiNjpMOcgzT0nqa9NnHYxL6tUsoVOI0enrB28zScU=; b=PG6NMEsw33H91GZSxcuGsSEulBW9xZGaHUl/kBNCucwhXYdS1xTcf/SICDFZC6ox1Y /8cNSSn87D6X6D1PeEfv77kXyod2itcO0h6vCficHaRmzY8jx/zSOblAbhkRwlal9yTr Bst1SELQJA529Zhk7Q0rm27utth+F/VladlTKZu9l0AJHH9AEhmDTzA+8+5YCmPlAM6u eMATDG1wq/WeSRWYnGrX62iYOxMN2km64jcUdQTKIlsriXMXmB8ZmgT6KwyK6opxHA7l YnoNj91mIWNmaS75els0Rr0GReVsoEvZ7UiYKP9mgzPydRQy64NC5UeQn5ITTTYzAwna YBsw== X-Gm-Message-State: APjAAAX+ZSuyPSTsAkZ50yfOTkBrwBxQjZM5aAR548yzM+D5SL74Gzxx 55H5alNZjeJDTFHZlEnxMGfWPttcJt8C2avucnRte6yB X-Google-Smtp-Source: APXvYqzQi1O/djghXggkoZALb8IuT2+hIizv4C0JTodJg1upZIIR6wNtbOIZhos31TU9UivJSB5f/7I9gdrwN9w7AuU= X-Received: by 2002:a17:902:442:: with SMTP id 60mr10352712ple.325.1557997542462; Thu, 16 May 2019 02:05:42 -0700 (PDT) In-Reply-To: <87a7fmixj1.fsf@gmail.com> X-Mailman-Approved-At: Thu, 16 May 2019 10:30:39 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159394 Archived-At: > Thanks, but I don't think I understand the advantages of this approach > vs the current one. Concretely, why would we want not to inherit > from the 'default' face? Indeed, there is no reason not to inherit from the default face. In fact, what I suggested was making the inheritance _always hold_, i.e., despite of the user's definitions of the line number faces. Which brings us to the next point you brought up... > Also, doesn't your change force the line-number face to change > together with 'default', even if the user defines the face to not > inherit from 'default'? With the current code, users are free to > define the face without inheritance, and that will stop update the > line-number face together with 'default', e.g. when the user enlarges > the default face's font or makes it smaller. With your proposal, the > size changes in 'default' will always be propagated to line-number, > right? I agree with you. In fact, this is exactly the reason why I had suggested the change -- I was using a theme were the line number faces were not set to inherit from default, and realized that text-scale-adjust does not affect them. > And finally, if we do make the proposed change, shouldn't we stop > inheriting from 'default' at the same time? Absolutely. With all this being said, I agree with you that it is best to let the user choose whether he or she wants the line number faces to inherit from the default one. -- Dario Gjorgjevski :: dario.gjorgjevski@gmail.com :: +389 (0)70 784 142