From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.bugs Subject: bug#65188: 29.1; WEBP image not displayed Date: Thu, 10 Aug 2023 04:16:08 -0500 Message-ID: References: <83pm3vjti1.fsf@gnu.org> <83edkbjq6m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9369"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65188@debbugs.gnu.org, awrhygty@outlook.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 10 11:17:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qU1nD-00025n-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Aug 2023 11:17:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qU1n0-0002GE-4g; Thu, 10 Aug 2023 05:17:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU1mw-0002Di-De for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 05:17:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU1mv-0008Oa-TC for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 05:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qU1mv-0006DG-OJ for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 05:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Corwin Brust Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 09:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65188 X-GNU-PR-Package: emacs Original-Received: via spool by 65188-submit@debbugs.gnu.org id=B65188.169165898723831 (code B ref 65188); Thu, 10 Aug 2023 09:17:01 +0000 Original-Received: (at 65188) by debbugs.gnu.org; 10 Aug 2023 09:16:27 +0000 Original-Received: from localhost ([127.0.0.1]:41376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU1mN-0006CJ-EI for submit@debbugs.gnu.org; Thu, 10 Aug 2023 05:16:27 -0400 Original-Received: from mail-ot1-f47.google.com ([209.85.210.47]:59408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU1mL-0006C2-7f for 65188@debbugs.gnu.org; Thu, 10 Aug 2023 05:16:26 -0400 Original-Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6bd045336c6so655793a34.2 for <65188@debbugs.gnu.org>; Thu, 10 Aug 2023 02:16:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691658979; x=1692263779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8KMnZ7Byofv1meqxHLmDmEjhYM/fEiGENtriF1sE1Eg=; b=e4jeA15Ej+juajVhklBw/dzsRcSEGvCWphdi/solbtvdWN1fFa2BGRfOqPdXXusgI3 f5vH86Njl2LC3EmSxykks+b6ZN/5Jp1AwJVwFgGxldLvh0UBBVjjlFdjGSGuw7sJ8KcZ Kie1JDHuv6vQhFo+oI91XkpxBwDGBSDDshLKUwiTxtTJzpq+InR04mjadVIjIhVggX3j SNUdSAlSWXR/S+PYHjgcAGOPeTUd26Xkx7OPvtPeLhcjfeQ8Ko/KN4rc9EYR/Kk5+qJJ NSpIx6mRrvYOm+hi07pZid9jhq8Wjq/QAh1VHYiHH/Q8j0wftNpV3g9roBNJDlUkfU1c 5hgQ== X-Gm-Message-State: AOJu0YyIAc+0UCX+nbWUWVtuGJzxrllenIN37lSsVvqPMAoU7WI41ZlA PfYWM20/Dq6nIfwmaouuVMvfgxOL/KArxicA5xo= X-Google-Smtp-Source: AGHT+IGqelG5EqOq6QaMYb2Ivd62bdgh1Enczu1LBCSo2RgCVvuKwOdSxC0/QRoPbvgeVCOZgVmmvR9sxj0a7dAZwzg= X-Received: by 2002:a05:6830:20ca:b0:6b9:41e1:713f with SMTP id z10-20020a05683020ca00b006b941e1713fmr2029201otq.18.1691658979559; Thu, 10 Aug 2023 02:16:19 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267111 Archived-At: On Thu, Aug 10, 2023 at 3:04=E2=80=AFAM Corwin Brust wrote: > > approach looking specifically for libwebp-7. Here I can see two webp > related DLLs (but I'm fairly sure we only include one of them). The > > libwebpdemux-2.dll C:\msys2\mingw64\bin\libwebpdemux-2.dll > libwebp-7.dll H:\packaging-test\emacs-29.1_1\bin\libwebp-7.dll > > Problem, yes? Packaging problem only? User jbe on Libera.Chat #emacs IRC kindly confirmed both the original issue reproduces using the emacs-29.1_1 binaries, and that adding the "debux" DLL mentioned above resolves the issue. So, I have created a new deps archive and am working on a new release set. Once I have created and verified a new set of binaries, if there are not concerns or countermanding instructions, I'll go ahead and push emacs-29.1_2 to GNU FTP. 1. New deps zip with more webp DLLs: https://corwin.bru.st/emacs-29/emacs-29-2023-08-10-deps.zip 2. In the same folder are dependency sources (src-deps) and sig files: https://corwin.bru.st/emacs-29/ awrhygty (and anyone), You can test that the new set will fix the problem for you by unpacking the deps zip file (link #1, above) and unpacking it on atop the bin folder from your emacs-29.1_1 install. It doesn't matter whether you say "Yes" to allow replacing files or not - the only differences should be some new WEBP related DLLs. Sorry for the inconvenience and thanks for reporting the problem. Eli, I have expressly added WEBP into the list of packages needed, in admin/nt/build-deps-zip.py. It is worth noting that this script is really painful because the upstream MSYS package source paths keep changing; I had to make several unrelated (cert and sqllite3 source archive URL) changes to run it, just now. I think lib-webp7.dll was included at all only because something else we list as a dep was depending on it, but I'm not quite sure what just yet. I realize others don't find this script as important as I do, but I've really struggled to do what it does manually constantly, much less create simpler scripting. I regret not sending in a proper patch for discussion well in advance of the release. Is this the right place, or should I open my own bug report to discuss my version of build-deps-zips and whether to merge my changes that make it work for building Emacs 29 and Enacs 30? (Not attaching anything quite yet, but I did put the current version of the script into the folder I linked above.)