From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.bugs Subject: bug#75013: Windows binary installer ignores user options for Start menu shortcuts Date: Sat, 21 Dec 2024 17:05:53 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000db29030629cfce31" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36952"; mail-complaints-to="usenet@ciao.gmane.io" To: 75013@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 22 00:07:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tP8Z7-0009RZ-O8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Dec 2024 00:07:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tP8Yp-0001V2-Sc; Sat, 21 Dec 2024 18:07:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tP8Yo-0001Up-6Q for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 18:07:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tP8Yn-0003PJ-UP for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 18:07:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=wN/xrH61RZjA1w9ZturnUEYAn5hiZlPiKTkIKbGCTq4=; b=KT75psQF6N/nt9/Ea3L8aW7oYyX27MbwG/zCkqLvMEWqT0/qJqpNUEyv9gGU2thEAzkCccM6S6jrdt28ouqlmHb0HzqZFECN0ly4y2Dbf3JPVZ0LaGwT6bq6J8WjfeDsyZh2buZf/+TKHv0voODN6/SpI2f9YgHIZuFTF2wz71fwjMWip4weMVQ2u8FGFkAfnvSuNaACj9LvJlZ9SkKMGevdtaZtR7KhgiYNV2FmRDysV3e/86qCQErQSSdGPh9OBDKqcga/xg7kmwSgwN4jFXB+WUaa6sVmp3nStGgZB5Q0UlELOIiRTXuL67u75r6nlIQME8O2S1nwBaatm8iMfg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tP8Yn-0005et-OV for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 18:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Corwin Brust Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2024 23:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75013 X-GNU-PR-Package: emacs Original-Received: via spool by 75013-submit@debbugs.gnu.org id=B75013.173482237121683 (code B ref 75013); Sat, 21 Dec 2024 23:07:01 +0000 Original-Received: (at 75013) by debbugs.gnu.org; 21 Dec 2024 23:06:11 +0000 Original-Received: from localhost ([127.0.0.1]:48297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tP8Xy-0005df-SC for submit@debbugs.gnu.org; Sat, 21 Dec 2024 18:06:11 -0500 Original-Received: from mail-ot1-f41.google.com ([209.85.210.41]:41841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tP8Xu-0005dS-SI for 75013@debbugs.gnu.org; Sat, 21 Dec 2024 18:06:09 -0500 Original-Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-71e31d295eeso171281a34.3 for <75013@debbugs.gnu.org>; Sat, 21 Dec 2024 15:06:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734822366; x=1735427166; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wN/xrH61RZjA1w9ZturnUEYAn5hiZlPiKTkIKbGCTq4=; b=Z9hBv4BPCUDRsxycoTFHjB8Q4+Ep2jl0hVemMdwsvn/HRCxrYTEjfOoaeWunqvfyiN FVx05JKk3PbXi6pJ9B97g64jAvDMZ1AGSxqNBpi6S+vQd/Hy3SC0NdNovzrHNKcSVLs5 fmi+Ep6qpcCmWbDbp1429QYMVPC1BjPpeB43960rhR/pFbSai1hDyM0Bka40v3p8gD6n /T4OlIlV4dHzuo8UdEl9tN0znKVtCrnmXxracmedn6FOOoHk94LmvpAUBfO3qMtNmCae GfIjx7fSROVd+bs9+hOMDRZEbsqwW7hgR5QZfdXnEmUIHXPWisCEep+GtX3EeJmmjzu4 CybQ== X-Gm-Message-State: AOJu0YwxQAQov29d1cRXnVlFsATcab/iwVZQz+ljTwJoVSIissImpjhd i7PA3/NDZW2/4BWfP7p6L9YBpGTsHjaMLhZo0FhjiTVKqvFKB5MEbvVHSM/pFh9fcCFuEqBH/0H ZViJQGf1Zqa1XrjqoqQNQg0QKKYiy5DtP X-Gm-Gg: ASbGncsR0ZYbPNHaEHZsYnp7bBAt6LxORck7yl1NX6YhAunfYOijqYoCGz6LAvacwRJ d7h9e7Ki66xGgmBKB/K7RRppGCkk84a1WIVJt X-Google-Smtp-Source: AGHT+IHCfp7wjRwPS1WrVFKf9jqFe1wXCRsDhCXkgraNpgAMaEAcPc3/ZI7DhUkvv7bUIxLvJgotCXPI/7gbCRbllEA= X-Received: by 2002:a05:6830:4489:b0:703:7851:41ba with SMTP id 46e09a7af769-720ff685333mr1795219a34.2.1734822365693; Sat, 21 Dec 2024 15:06:05 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297557 Archived-At: --000000000000db29030629cfce31 Content-Type: text/plain; charset="UTF-8" tags: patch thanks > > I'll look into fixing this for the 30.1 installer, also, replying back > in here if/when I have an "_3" that seems to warrant others' testing > effort. > I'm attaching a (messy, quick) patch which appears to wrap fixing this issue up with fixing those others I've just been asking others to help me close (by testing out patched installers). I will link devel (and OP) rather than here with the (transient, available for some days at least) link to the new version of the installer I've made applying the attached patch (under other cover). I'll report back in (to this bug) with a "stand-alone" patch showing just code needed to resolve this issue (probably for academic purposes, given this consolidated patch works). It should apply to virtually any branch (or release/pre-release source tarball). FTR, it was easy enough to swap reorder things to ensure that the shortcuts got created properly (according to user options, and not prior to asking for input/confirmation of those preferences, as before); however, I had to go to lengths to ensure the uninstaller removes whatever shortcuts it creates. The resulting (seemingly reliable) result is that we now delete empty parent folders (up to the start menu application's folder root) when deleting whatever shortcuts during uninstallation which the given installer had made. I can (and probably should) give the same treatment to the applications folder, removing empty parents of the User's selected install folder, but I think we have enough to test for just now. (The same approach will work; it won't be difficult to add. But let's confirm the recursive delete method works reliably for others). For anyone seeing this and interested in a (slightly) more durable link from which one can follow (by seeing incremental/experimental builds outside of links shared to devel) along, seeing my current version of the attached patch and related binaries using the 30.0.93 (pre-release 3 for Emacs 30) tarball a starting-point, here's an index page: https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-30/?C=M;O=D Note, when browsing the above link: The "latest" and otherwise (not 30.0.93_N_or_bug) releases are the latest snapshots taken from the emacs-30 branch (so, by now, more recent than the release tarball mentioned above, and without this/these patches, for now). Such builds are named based on the git revision and include the sources used in the given folders. Builds related to installer fixes based on Emacs 30/pretest #3 are within my "Emacs 30 root folder", index to which is linked above. --000000000000db29030629cfce31 Content-Type: application/octet-stream; name="emacs.nsi.patch" Content-Disposition: attachment; filename="emacs.nsi.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m4ys611p0 LS0tIGVtYWNzLm5zaS5TVEFCTEUJMjAyNC0xMi0yMSAxNjoyMTowOS45MjEyODAzMDAgLTA2MDAK KysrIGVtYWNzLm5zaQkyMDI0LTEyLTIxIDE2OjI0OjU1LjcxNjAxOTQwMCAtMDYwMApAQCAtMjAs MTYgKzIwLDI3IEBACiAKICFpbnNlcnRtYWNybyBNVUlfUEFHRV9XRUxDT01FCiAKLQotIWRlZmlu ZSBNVUlfTElDRU5TRVBBR0VfVEVYVF9UT1AgIlRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z ZSIKKyMgbGljZW5zaW5nL2Fib3V0IGNsaWNrLXRob3VnaCBwYWdlCishZGVmaW5lIE1VSV9QQUdF X0hFQURFUl9URVhUICJFbWFjcyBpcyBGcmVlIFNvZnR3YXJlIgorIWRlZmluZSBNVUlfUEFHRV9I RUFERVJfU1VCVEVYVCAiQSBjb21wb25lbnQgb2YgdGhlIEdOVSBvcGVyYXRpbmcgc3lzdGVtLiIK KyFkZWZpbmUgTVVJX0xJQ0VOU0VQQUdFX1RFWFRfVE9QICJUaGlzIHByb2dyYW0gaXMgZnJlZSBz b2Z0d2FyZS4iCishZGVmaW5lIE1VSV9MSUNFTlNFUEFHRV9URVhUX0JPVFRPTSAiWW91IGNhbiBy ZWRpc3RyaWJ1dGUgdGhpcyBwcm9ncmFtIGFuZC9vciBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1z IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZy ZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSAo YXMgYWJvdmUpLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLiIKKyFkZWZp bmUgTVVJX0xJQ0VOU0VQQUdFX0JVVFRPTiAiT0siCiAhaW5zZXJ0bWFjcm8gTVVJX1BBR0VfTElD RU5TRSAiZW1hY3MtJHtWRVJTSU9OX0JSQU5DSH1cc2hhcmVcZW1hY3NcJHtFTUFDU19WRVJTSU9O fVxsaXNwXENPUFlJTkciCiAKKyMgdXNlciBvcHRpb24gcGFnZTogaW5zdGFsbGF0aW9uIHBhdGgK ICFpbnNlcnRtYWNybyBNVUlfUEFHRV9ESVJFQ1RPUlkKLSFpbnNlcnRtYWNybyBNVUlfUEFHRV9J TlNURklMRVMKIAorIyB1c2VyIG9wdGlvbiBwYWdlOiBzdGFydCBtZW51IHNob3J0Y3V0CiAhaW5z ZXJ0bWFjcm8gTVVJX1BBR0VfU1RBUlRNRU5VIEFwcGxpY2F0aW9uICRTdGFydE1lbnVGb2xkZXIK IAorIyB1c2VyIG9wdGlvbiBjb25maXJtL2JlZ2luIGluc3RhbGwKKyFpbnNlcnRtYWNybyBNVUlf UEFHRV9JTlNURklMRVMKKworIyB1bmluc3RhbGxlciBjb25maXJtYXRpb24vb3B0aW9ucyAobm8g b3B0aW9ucykKICFpbnNlcnRtYWNybyBNVUlfVU5QQUdFX0NPTkZJUk0KKworIyB1bmluc3RhbGxl ciBiZWdpbgogIWluc2VydG1hY3JvIE1VSV9VTlBBR0VfSU5TVEZJTEVTCiAKICFpbnNlcnRtYWNy byBNVUlfTEFOR1VBR0UgIkVuZ2xpc2giCkBAIC0zOSwyMCArNTAsMjQgQEAKICAgICBTdHJDcHkg JElOU1RESVIgIiRQUk9HUkFNRklMRVM2NFxFbWFjcyIKIGZ1bmN0aW9uZW5kCiAKLQorIyBtYWlu IHNlY3Rpb24gbG9naWMsIHJ1biBhZnRlciBjb25maXJtaW5nIGluc3RhbGxhdGlvbgogU2VjdGlv bgogCisgICMgaW5zaXN0aW5nIG9uIGluc3RhbGxpbmcgc2hvcnRjdXRzIGZvciAiYWxsIHVzZXJz IgorICAjIG1pZ2h0IGVuc3VyZSB1bmluc3RhbGwgY2FuIHJlbW92ZSBzaG9ydGN1dHMgd2UgY3Jl YXRlZAorICAjIFNldFNoZWxsVmFyQ29udGV4dCBhbGwKKyAgCiAgIFNldE91dFBhdGggJElOU1RE SVIKIAogICBGaWxlIC9yIGVtYWNzLSR7VkVSU0lPTl9CUkFOQ0h9CiAKICAgIyBkZWZpbmUgdW5p bnN0YWxsZXIgbmFtZQotICBXcml0ZVVuaW5zdGFsbGVyICRJTlNURElSXFVuaW5zdGFsbC5leGUK KyAgV3JpdGVVbmluc3RhbGxlciAiJElOU1RESVJcVW5pbnN0YWxsLSR7VkVSU0lPTl9CUkFOQ0h9 LmV4ZSIKIAogICAhaW5zZXJ0bWFjcm8gTVVJX1NUQVJUTUVOVV9XUklURV9CRUdJTiBBcHBsaWNh dGlvbgogICA7Q3JlYXRlIHNob3J0Y3V0cwogICBDcmVhdGVEaXJlY3RvcnkgIiRTTVBST0dSQU1T XCRTdGFydE1lbnVGb2xkZXIiCi0gIENyZWF0ZVNob3J0Y3V0ICIkU01QUk9HUkFNU1wkU3RhcnRN ZW51Rm9sZGVyXFVuaW5zdGFsbC5sbmsiICIkSU5TVERJUlxVbmluc3RhbGwuZXhlIgorICBDcmVh dGVTaG9ydGN1dCAiJFNNUFJPR1JBTVNcJFN0YXJ0TWVudUZvbGRlclxVbmluc3RhbGwubG5rIiAi JElOU1RESVJcVW5pbnN0YWxsLSR7VkVSU0lPTl9CUkFOQ0h9LmV4ZSIKIAogICAhaW5zZXJ0bWFj cm8gTVVJX1NUQVJUTUVOVV9XUklURV9FTkQKICAgQ3JlYXRlU2hvcnRDdXQgIiRTTVBST0dSQU1T XCRTdGFydE1lbnVGb2xkZXJcRW1hY3MubG5rIiAiJElOU1RESVJcZW1hY3MtJHtWRVJTSU9OX0JS QU5DSH1cYmluXHJ1bmVtYWNzLmV4ZSIKQEAgLTYzLDE1ICs3OCwzNCBAQAogIyB0aGUgc2VjdGlv biB3aWxsIGFsd2F5cyBiZSBuYW1lZCAiVW5pbnN0YWxsIgogU2VjdGlvbiAiVW5pbnN0YWxsIgog Ci0gICMgQWx3YXlzIGRlbGV0ZSB1bmluc3RhbGxlciBmaXJzdAotICBEZWxldGUgIiRJTlNURElS XFVuaW5zdGFsbC5leGUiCi0KLSAgIyBub3cgZGVsZXRlIGluc3RhbGxlZCBkaXJlY3RvcnkKLSAg Uk1EaXIgL3IgIiRJTlNURElSIgotICBSTURpciAiJElOU1RESVIiCisgICMgcmVtb3ZlIEFsbCBV c2VycyBzaG9ydGN1dHMgb25seQorICAjIFNldFNoZWxsVmFyQ29udGV4dCBhbGwKIAogICAhaW5z ZXJ0bWFjcm8gTVVJX1NUQVJUTUVOVV9HRVRGT0xERVIgQXBwbGljYXRpb24gJFN0YXJ0TWVudUZv bGRlcgorICBTdHJDcHkgJFN0YXJ0TWVudUZvbGRlciAiJFNNUFJPR1JBTVNcJFN0YXJ0TWVudUZv bGRlciIKKworICAjIHJlbW92ZSBTdGFydCBNZW51IFByb2dyYW0gc2hvcnRjdXRzCisgIERlbGV0 ZSAiJFN0YXJ0TWVudUZvbGRlclxFbWFjcy5sbmsiCisgIERlbGV0ZSAiJFN0YXJ0TWVudUZvbGRl clxVbmluc3RhbGwubG5rIgorCisgICMgcmVtb3ZlIGVtcHR5IHBhcmVudHMgdXAgdG8gJFNNUFJP R1JBTVMKKyAgc3RhcnRNZW51RGVsZXRlTG9vcDoKKyAgICBDbGVhckVycm9ycworICAgIFJNRGly ICRTdGFydE1lbnVGb2xkZXIKKyAgICBHZXRGdWxsUGF0aE5hbWUgJFN0YXJ0TWVudUZvbGRlciAi JFN0YXJ0TWVudUZvbGRlclwuLiIKKyAgICBJZkVycm9ycyBzdGFydE1lbnVEZWxldGVMb29wRG9u ZQorICAgIFN0ckNtcCAkU3RhcnRNZW51Rm9sZGVyICRTTVBST0dSQU1TIHN0YXJ0TWVudURlbGV0 ZUxvb3BEb25lIHN0YXJ0TWVudURlbGV0ZUxvb3AKKworICAjIHdlJ3JlIGJhc2ljYWxseSB1c2lu ZyBHT1RPLCBhYm92ZSwgc28gd2Ugc2hvdWxkIGdldCBoZXJlLi4KKyAgc3RhcnRNZW51RGVsZXRl TG9vcERvbmU6CisKKyAgICAjIHJlY3Vyc2l2ZWx5IGRlbGV0ZSBkaXJlY3RvcnkgZm9yIHRoaXMg dmVyc2lvbgorICAgIFJNRGlyIC9yICIkSU5TVERJUlxlbWFjcy0ke1ZFUlNJT05fQlJBTkNIfSIK KworICAgICMgcmVtb3ZlIHRoZSBFbWFjcyBkaXJlY3RvcnkgaW4gUHJvZ3JhbSBGaWxlcyAoaWYg ZW1wdHkpCisgICAgUk1EaXIgIiRJTlNURElSIgorCisgICAgIyBkZWxldGUgdW5pbnN0YWxsZXIg bGFzdAorICAgIERlbGV0ZSAiJElOU1RESVJcVW5pbnN0YWxsLSR7VkVSU0lPTl9CUkFOQ0h9LmV4 ZSIKIAotICBEZWxldGUgIiRTTVBST0dSQU1TXCRTdGFydE1lbnVGb2xkZXJcVW5pbnN0YWxsLmxu ayIKLSAgUk1EaXIgIiRTTVBST0dSQU1TXCRTdGFydE1lbnVGb2xkZXIiCiBTZWN0aW9uRW5kCg== --000000000000db29030629cfce31--