unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Corwin Brust <corwin@bru.st>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 65206@debbugs.gnu.org
Subject: bug#65206: 29.1; [windows][patch] build-deps-zips.py is broken and hard to maintain
Date: Wed, 16 Aug 2023 08:41:25 -0500	[thread overview]
Message-ID: <CAJf-WoSES0gt4XZMtEuCbAgoOmRZ5jc+N5wy35kztwS1075f_Q@mail.gmail.com> (raw)
In-Reply-To: <83leeb8a0j.fsf@gnu.org>

On Wed, Aug 16, 2023 at 7:08 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Corwin Brust <corwin@bru.st>
> > Date: Tue, 15 Aug 2023 20:23:44 -0500
> > Cc: 65206@debbugs.gnu.org
> >
> > On Tue, Aug 15, 2023 at 11:01 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > >
> > > the list in dynamic-library-alist, on lisp/term/w32-win.el.
>
> I'm not sure I understand the reservation.  That list mentions every
> single DLL that we know can be used for each optional feature.  If a
> feature has more than one DLL listed, the first one is usually the
> most popular, and should be tried first.

This solves my worry completely, or nearly so.

To confirm: when walking the list, I will want to take the first DLL
mentioned that actually exists for each entry. Is that right?

> Given this, what problems do you envision with using that list?

There might not be a problem (except the one we are trying to fix).
The alist contains 22 entries, while var DLL_REQ contains 14 entries.
The five on the alist but on mentioned in the script (so far) are:

gdiplus
shlwapi
gobject
gio
webpdemux - this is pretty obviously a miss in the script; it does get
however because it's required by webp which is listed in DLL_REQ

Are all of these errors with the script (so, the corresponding DLLs
should be included)?  If not, I think we will need a way for the
script to know which alist entries to skip/ignore.

> > Does a "invokes Emacs now and errors out if stuff is missing" approach
> > sound right/good?
>
> I'm not sure I understand how would you force Emacs to "error out"
> when we are talking about optional dependencies.  They are optional so
> that Emacs could run even if they are not present.
>

Oops, badly said:  I mean that my build and packaging process should
stop and report an error if it cannot create a "complete" DEPS ZIP.
Nothing affecting the Emacs run-time.





  reply	other threads:[~2023-08-16 13:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 12:40 bug#65206: 29.1; [windows][patch] build-deps-zips.py is broken and hard to maintain Corwin Brust
2023-08-10 13:29 ` Eli Zaretskii
2023-08-10 21:09   ` Corwin Brust
2023-08-15  7:39   ` Corwin Brust
2023-08-15 15:43     ` Eli Zaretskii
2023-08-15 15:53       ` Corwin Brust
2023-08-15 16:01         ` Eli Zaretskii
2023-08-16  1:23           ` Corwin Brust
2023-08-16 12:08             ` Eli Zaretskii
2023-08-16 13:41               ` Corwin Brust [this message]
2023-08-16 14:49                 ` Eli Zaretskii
2023-08-17  7:25                   ` Corwin Brust
2023-08-17  9:55                     ` Eli Zaretskii
2023-08-17 13:31                       ` Corwin Brust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJf-WoSES0gt4XZMtEuCbAgoOmRZ5jc+N5wy35kztwS1075f_Q@mail.gmail.com \
    --to=corwin@bru.st \
    --cc=65206@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).