unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Corwin Brust <corwin@bru.st>
To: 53885@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#53885: 28.0.51 [PATCH] Autoload package-installed-p
Date: Tue, 8 Feb 2022 18:05:45 -0600	[thread overview]
Message-ID: <CAJf-WoRGg9io1nWZK=WRtaqtz8oSZ+vvqX_z4Hzn6dcu746TVg@mail.gmail.com> (raw)
In-Reply-To: <CAJf-WoQyEuZ=-8ZzBQ2nioQwX57GTwZLNC3BGjmoCtjsQNW3-A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

On Tue, Feb 8, 2022 at 5:56 PM Corwin Brust <corwin@bru.st> wrote:
>
> Commentary:
>
> If the change is accpted, please consider fixing this for emacs-28.
> The reproducer represents a common use-case, e.g. see bug #31397.
> Moverover, it is a one-line change unlikely to affect anything aside
> this and similar use-cases.
>

Eli,

Would this be okay for the release branch or should I check if changes
are needed to rebase against master?  Also, hould this receive a NEWS
entry?

> I will submit a patch as soon as I have a BugID from the tracker.
> Although this change is rather trivial I need to practice this
> process.
>

Now attached. TIA for tips and corrections.

[-- Attachment #2: autoload_package-installed-p.patch --]
[-- Type: application/octet-stream, Size: 832 bytes --]

commit 8317de586b6dc02cd7a82d4469dda4b3cedba7a3
Author: Corwin Brust <corwin@bru.st>
Date:   Tue Feb 8 17:48:14 2022 -0600

    Autoload package-installed-p
    
    * lisp/emacs-lisp/package.el (package-installed-p): Add autoload
    cookie. (bug#53885)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 7679ba2fae..4aad58ed6f 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2072,6 +2072,7 @@ package-install-from-archive
                                                  package-alist))))
                  (setf (package-desc-signed (car pkg-descs)) t))))))))))
 
+;;;###autoload
 (defun package-installed-p (package &optional min-version)
   "Return non-nil if PACKAGE, of MIN-VERSION or newer, is installed.
 If PACKAGE is a symbol, it is the package name and MIN-VERSION

  reply	other threads:[~2022-02-09  0:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 23:55 bug#53885: Autoload package-installed-p Corwin Brust
2022-02-09  0:05 ` Corwin Brust [this message]
2022-02-09 13:37   ` bug#53885: 28.0.51 [PATCH] " Eli Zaretskii
2022-02-09 20:16     ` Lars Ingebrigtsen
2022-02-09 23:58       ` Corwin Brust
2022-02-10  6:10         ` Eli Zaretskii
2022-02-10  6:45           ` Lars Ingebrigtsen
2022-02-10  7:21             ` Corwin Brust
2022-02-10  7:57               ` Eli Zaretskii
2022-02-10  8:09                 ` Corwin Brust
2022-02-10  8:18                   ` Eli Zaretskii
2022-02-10  8:41               ` Lars Ingebrigtsen
2022-02-10  8:49                 ` Corwin Brust
2022-02-10 12:04                 ` Eli Zaretskii
2022-02-10 14:54                   ` Corwin Brust
2022-02-10 17:29                     ` Eli Zaretskii
2022-02-09  5:39 ` bug#53885: " Corwin Brust
2022-02-09 14:39   ` Augusto Stoffel
2022-02-09 15:39     ` Corwin Brust
2022-02-10  8:42       ` Augusto Stoffel
2022-02-10  8:59         ` Philip Kaludercic
2022-02-10  9:28           ` Augusto Stoffel
2022-02-10  9:23         ` Corwin Brust
2022-02-10  9:30           ` Augusto Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJf-WoRGg9io1nWZK=WRtaqtz8oSZ+vvqX_z4Hzn6dcu746TVg@mail.gmail.com' \
    --to=corwin@bru.st \
    --cc=53885@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).