bug#43847: ERC - prevent yanking multiple lines into IRC (feature request) *patch*

[Corwin Brust <corwin@bru.st>]

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

Many thanks, Noam.

On Wed, Oct 7, 2020 at 11:05 AM Noam Postavsky <npostavs@gmail.com> wrote:
>
> I hope an ERC user will follow up (I think Bandali was going over ERC
> patches at some point?), but just some general comments:

I'm hoping Bandali and other ERC users will look, also.  I spoke to
someone on ERC today who is using the (prior version), I believe and
has agreed to mention any issues or suggestions.  (They agreed with
you about e-l-d-f-c being irrelevant, which seems pretty darned
obvious to me now too.)

> > diff -u "c:/emacs/share/emacs/27.1/lisp/erc/erc.el-27.1" "c:/emacs/share/emacs/27.1/lisp/erc/erc.el"
>
> > +(defun erc-yank (&optional arg)
> > +  "Unfill then yank.  ARG is handled by `yank', which see."
> > +  (interactive)
> > +  (insert
> > +   (save-excursion
>
> I believe the save-excursion is redundant since all the movement happens
> inside a temp buffer.

Removed save-excursion, thank you.

>
> > +     (with-temp-buffer
> > +       (yank arg)
> > +       (goto-char (point-min))
> > +       (let ((fill-column (point-max))
> > +          (emacs-lisp-docstring-fill-column t))
>
> I don't think binding emacs-lisp-docstring-fill-column should be needed?

*Smacking of forehead*  Right you are.


> > +      (fill-paragraph))
>
> The TAB character should be spaces instead.  I recommend (setq-default
> indent-tabs-mode nil), or at least
>
>     (defun my-lisp-mode-hook ()
>       (setq-local indent-tabs-mode nil))
>     (add-hook 'emacs-lisp-mode-hook #'my-lisp-mode-hook)
>
> Note that if you edit the git repo, it comes with an indent-tabs-mode=nil
> setting for emacs-lisp-mode in .dir-locals.el.
>
> > +       (buffer-string)))))

I'm pulling master now.  This version was created after evaling your
suggested one-liner in my erc.el buffer & please let me know if that's
got it.

Again, thanks

Corwin

[-- Attachment #2: erc-yank_002_rm_save-excusrion-and-elsip-docstring-col.patch --]
[-- Type: application/octet-stream, Size: 1144 bytes --]

diff -u "c:/emacs/share/emacs/27.1/lisp/erc/erc.el-27.1" "c:/emacs/share/emacs/27.1/lisp/erc/erc.el"
--- c:/emacs/share/emacs/27.1/lisp/erc/erc.el-27.1	2020-10-07 08:10:35.000000000 -0500
+++ c:/emacs/share/emacs/27.1/lisp/erc/erc.el	2020-10-08 20:42:26.207684100 -0500
@@ -1155,6 +1155,7 @@
     (define-key map "\C-a" 'erc-bol)
     (define-key map [home] 'erc-bol)
     (define-key map "\C-c\C-a" 'erc-bol)
+    (define-key map "\C-y" 'erc-yank)
     (define-key map "\C-c\C-b" 'erc-switch-to-buffer)
     (define-key map "\C-c\C-c" 'erc-toggle-interpret-controls)
     (define-key map "\C-c\C-d" 'erc-input-action)
@@ -4084,6 +4085,16 @@
         (setq erc-input-ring-index nil))
     (kill-line)))
 
+(defun erc-yank (&optional arg)
+  "Unfill then yank.  ARG is handled by `yank', which see."
+  (interactive)
+  (with-temp-buffer
+    (yank arg)
+    (goto-char (point-min))
+    (let ((fix-column (point-max)))
+      (fill-paragraph))
+    (buffer-string)))
+
 (defun erc-complete-word-at-point ()
   (run-hook-with-args-until-success 'erc-complete-functions))
 

Diff finished.  Thu Oct  8 20:43:11 2020