From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yilkal Argaw Newsgroups: gmane.emacs.bugs Subject: bug#55800: using rgrep function interactively with fido-mode or fido-vertical-mode causes errors Date: Thu, 9 Jun 2022 14:11:05 +0300 Message-ID: References: <83wndvack5.fsf@gnu.org> <83pmjna1di.fsf@gnu.org> <83fskj9sax.fsf@gnu.org> <86zginli36.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15295"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55800@debbugs.gnu.org, Eli Zaretskii To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 09 15:27:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzIBt-0003jW-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 15:27:13 +0200 Original-Received: from localhost ([::1]:45978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzIBs-0000GO-7y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 09:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzG54-0004ch-MK for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 07:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzG54-00022F-9C for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 07:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzG54-0003HP-4Z for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 07:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yilkal Argaw Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2022 11:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55800 X-GNU-PR-Package: emacs Original-Received: via spool by 55800-submit@debbugs.gnu.org id=B55800.165477308412547 (code B ref 55800); Thu, 09 Jun 2022 11:12:02 +0000 Original-Received: (at 55800) by debbugs.gnu.org; 9 Jun 2022 11:11:24 +0000 Original-Received: from localhost ([127.0.0.1]:45255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzG4R-0003GJ-PO for submit@debbugs.gnu.org; Thu, 09 Jun 2022 07:11:24 -0400 Original-Received: from mail-yw1-f178.google.com ([209.85.128.178]:43947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzG4Q-0003G2-6J for 55800@debbugs.gnu.org; Thu, 09 Jun 2022 07:11:22 -0400 Original-Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-3137316bb69so42397347b3.10 for <55800@debbugs.gnu.org>; Thu, 09 Jun 2022 04:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OjMhhqj4apsE/4csucmNEDKCQ6LKFOZ7TNJlRdnDrEo=; b=ZCLhnr/h/RmV5gnly/61mGcTAxd3zVjNmil5q3NrPgaC6rh+XUgLQlO/NfOAmHiVuU 0Nbgypaq0ngv5QcbeMHsAQjXFLY3ASb36jHyTak6CfREcuq6xG8LdA8JqMIH/Fnp7tLe W3ladioHZc4TU9AcPG+2WxJUYpHuUtGfKHQS5wEGTtyDqMKi3O5U0epTSzIBWWgjxMK6 NU/yBP7QMkUeo5a4SGrEX7QKUIjhdjT/YhpHQ8MN6HVVQafVi798xQyTpQECc9wwOyS2 lTPcuSJGGEZFt9VbPs0ZIE1lA1Cd7i/n8vzUBbT/s6Q9Pv1CXo9Ii3SZnq/FIWvTo1po kdoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OjMhhqj4apsE/4csucmNEDKCQ6LKFOZ7TNJlRdnDrEo=; b=U6nczF0BcSZH9Laeh1sdpZ9VIT19EMNp4YblVJbuBismSHaBuV8yOzPh6v/Ru/fwQV ia0UQyzGR7fRjQMRRm67RzvgJQm2Oif2F0wlpUytRELSr0wJn3j9hjpJAnu9pOuD4m7t nskef8wHNo2OLSScc6I79dJLFkzapcQO48YxTJaJqLATNwlZmqZ8Zg4rX5Hpl4iWnrMH i0qVTer4oDvyk943Bp22n6BsJD7is3m1vqng9WnswvpofPtijRSikLqwgPKU81VV2rM+ FPorzhxjBeknbBcO8PLuAehdLkXFscHAsoKPWaIRX2onYJa+9vvXPPjzPi41VOyGRYxw ylQA== X-Gm-Message-State: AOAM533wfQVq1CxMUnPNa9j9TGKYwhMzyBfxIusy9Xa0ZF6v8LVs0VPQ ipXTeb335pGVD5ZZEF8QcmCxJKHBIt2/CIJHVVs= X-Google-Smtp-Source: ABdhPJwlP4k/poVfPfKywZEPzTtazQ/XLHvqfbjhEP/lHUO17PX1DzCeEGKf+a8l2D4RrGBL2EDTCvXPhTUUpDLUqB8= X-Received: by 2002:a81:f106:0:b0:313:39d5:e361 with SMTP id h6-20020a81f106000000b0031339d5e361mr13986113ywm.351.1654773076489; Thu, 09 Jun 2022 04:11:16 -0700 (PDT) In-Reply-To: <86zginli36.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234054 Archived-At: > Did you know that you can use M-j to accept the default value "all" > instead of the highlighted candidate in fido-mode? M-j did not work. Also I do not think that that is how that function was supposed to behave. Looking into the fille grep.el there is a list called "grep-files-aliases" I think that is the list that should be fed to the completion instead of whatever is generated by read-file-name-internal. One could even build a better list of file extensions because asking for "matching wildcards" and providing files instead of file extensions does not quite make sense to a user. With Regards Yilkal A. On Wed, Jun 8, 2022 at 10:41 AM Juri Linkov wrote: > > >> The completion shows file names because the code calls > >> read-file-name-internal. Try the same without fido, and at the prompt > >> for the wildcard type '?' -- you will see a list of files. That's > >> what fido shows. > >> > >> Why that code calls read-file-name-internal, I don't know; perhaps > >> because it wants to support the use case of searching a single file or > >> files in a directory? > > > > I think that is done in the completion option after that where one selects > > the file name or a directory based on ones' needs. This option as > > I mentioned before it was supposed to be for file types. If there is no builtin > > list for file types(extensions) it might be sufficient to leave it alone > > or have it call a list which contains "*" only. I have checked the completion > > options for counsel-rg counsel-ag, consult-rg and they do it do it that way > > Did you know that you can use M-j to accept the default value "all" > instead of the highlighted candidate in fido-mode?