bug#55759: hard coded height value in manoj-dark theme causes problems when increasing default-face-height

bug#55759: hard coded height value in manoj-dark theme causes problems when increasing default-face-height

[Yilkal Argaw]

If one uses fido-vertical-mode and temporarily increases the
default-font-hight by using the function (set-face-attribute 'default
nil :height 180) the completions will not scale properly. I've looked
into the source code for the theme and it shows that the
completions-common-part variable is hardcoded to a value of 81. It
should be changed to a relative value (something like 0.8) so that it
scales properly.

bug#55759: sending a patch for the bug #55759

[Yilkal Argaw]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-change-height-attribute-for-completions-common-part.patch --]
[-- Type: application/octet-stream, Size: 989 bytes --]

From 1fca79e9998353946ab1ad91ccfe814e41c9c605 Mon Sep 17 00:00:00 2001
From: yilkalargaw <yilkalargawworkneh@gmail.com>
Date: Thu, 2 Jun 2022 07:58:19 +0300
Subject: [PATCH] change height attribute for completions-common-part
To: bug-gnu-emacs@gnu.org

---
 etc/themes/manoj-dark-theme.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
index b70620fe21..c7d2d3fee5 100644
--- a/etc/themes/manoj-dark-theme.el
+++ b/etc/themes/manoj-dark-theme.el
@@ -400,7 +400,7 @@ manoj-dark
  '(compilation-warning-face ((t (:bold t :foreground "Orange" :weight bold))))
  '(completions-common-part ((t (:width normal :weight normal
                                 :slant normal :foreground "WhiteSmoke"
-				:background "black" :height 81))))
+				:background "black" :height 0.9))))
  '(completions-first-difference ((t (:bold t :weight bold))))
 
  '(css-selector ((t (:foreground "LightSteelBlue"))))
-- 
2.36.1

bug#55759: hard coded height value in manoj-dark theme causes problems when increasing default-face-height

[Lars Ingebrigtsen]

Yilkal Argaw <yilkalargawworkneh@gmail.com> writes:

> Subject: [PATCH] change height attribute for completions-common-part

Thanks; applied to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no