From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yilkal Argaw Newsgroups: gmane.emacs.bugs Subject: bug#66023: outline-minor-mode-use-buttons depends on whitespace-space face for some reason Date: Mon, 18 Sep 2023 08:31:11 +0000 Message-ID: References: <86wmwoxb5i.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a2393d06059df7f8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25856"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66023@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 10:33:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qi9hU-0006Sp-9W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 10:33:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qi9ff-0005y5-Qz; Mon, 18 Sep 2023 04:31:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qi9fe-0005xg-FE for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 04:31:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qi9fe-00049R-6k for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 04:31:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qi9fm-0007Gf-6G for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 04:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yilkal Argaw Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66023 X-GNU-PR-Package: emacs Original-Received: via spool by 66023-submit@debbugs.gnu.org id=B66023.169502589927902 (code B ref 66023); Mon, 18 Sep 2023 08:32:02 +0000 Original-Received: (at 66023) by debbugs.gnu.org; 18 Sep 2023 08:31:39 +0000 Original-Received: from localhost ([127.0.0.1]:52022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qi9fO-0007Fw-Gr for submit@debbugs.gnu.org; Mon, 18 Sep 2023 04:31:38 -0400 Original-Received: from mail-oo1-xc29.google.com ([2607:f8b0:4864:20::c29]:59661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qi9fM-0007Fk-T1 for 66023@debbugs.gnu.org; Mon, 18 Sep 2023 04:31:37 -0400 Original-Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-57124ee486dso2551768eaf.3 for <66023@debbugs.gnu.org>; Mon, 18 Sep 2023 01:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695025883; x=1695630683; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LwvhtwC992aI/V3tENzNTbSE3k52opEsH1xHWHW1dP4=; b=HyYHDLDPJlEJ3ys1JEtnAW/0yDjiRVE4jOnKoi+gs5RH+4VZ37euQF8zjiqIO2x131 wVwOaLr7mi4tdnEL7sCSlW4SFCZZ10llIwdQvPZkQEPoZDZDkGc7BBl2H6ryOZhEhf80 FHR5QjuUx/BCJ5JCe66awbJPKTbCDsBEPUsdsr+B1hv/UaxAsIgDFIOzlhg3v5spRwcT 2gL5UDV0qUH7IduVOJXWdASuSPR9ipdFIE+sFEPrOJE8HL7s18dm/GE+9WRNTEnevK/Q wYFlJMKNi0pdZOQmzaKlCSWUddu+Z/KS55GLIxbd0OiBq7hIznR+vITA7zrZgbsSTaMJ qzXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695025883; x=1695630683; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LwvhtwC992aI/V3tENzNTbSE3k52opEsH1xHWHW1dP4=; b=B+j4qtEvQd2/HfcNgi+LlcAReT+TNhZhoa5zQWeFLVE2o8mv6rB2Mc7RTYk+aGHhNr hWQD7f3HqldNpi+LJw+i+6equHtgC9RNNrpmXOKxtdDl2BGtL3EaOLYZORCv2DHOuVbz UwEj4mkJ/q23DEbBTwrTtI26OvLbvACgEmX6DnG6It3+ffBpKpPypwP+lNxXSoDajfht 3OmLxdmrC82jgXtrx7VrBTLDcBMmy4eYtKTUnHGHXqwmc6PjYC8WVyrW9CR5MC/MJoRg tFEf7A0CbJcrz/nBUOBZcGxgMScHKKYPz7obPTlZpW4NSCN3ocVSgqcLZaZyPGNgpv/U 4k8A== X-Gm-Message-State: AOJu0YxN6cl1J1IYKoRUMyfHiU/8bId9vLrk75SWG2MOqkebgF6UsLLG k1AasA7MRYeISB+tphn5g8DBf2qHalLjeD/cdUUaopghogU= X-Google-Smtp-Source: AGHT+IH5lTiIOJ3U1pCZo9twVVx27pjxXCqu2FZuloSqvQqV43blKMMZbmmxLoEWtcj5lmtu7lFaookTTXzhRWv3nps= X-Received: by 2002:a4a:6f0d:0:b0:56c:e17e:72ab with SMTP id h13-20020a4a6f0d000000b0056ce17e72abmr7357413ooc.2.1695025882870; Mon, 18 Sep 2023 01:31:22 -0700 (PDT) In-Reply-To: <86wmwoxb5i.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270755 Archived-At: --000000000000a2393d06059df7f8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > PS: Maybe we need to add a new boolean option that will define > whether to inherit the face attribute from the buffer or > to use the outline faces. I think that might be the way to handle it. It might even be worth having that as the default because there might be other faces that inherit from the buffer. On Mon, Sep 18, 2023 at 6:59=E2=80=AFAM Juri Linkov wrote= : > > I kind of make use of the relatively new outline-minor-mode-buttons > > feature. I have specfic settings regarding whitespace mode and I > > observed that hides the outline buttons deeper than level 2. Trying to > > debug this I found that was related to the whitespace-space face and > > but looking at outline.el gave me no hit's as to why that was the > > reason. So I am filing this issue with the minimal configuration to > > recreate the issue. > > Thanks for 100% reproducible case. I don't know what whitespace-mode > does with whitespace where outline-minor-mode-buttons adds own text > properties for buttons, but it's clear there is a conflict between > these two packages each trying to do own stuff in the same shared part > of the buffer. By default outline-minor-mode inherits text properties > at the beginning of the line together with whitespace properties that > make the buttons not visible. > > So you can just override the face inherited from the buffer with > own customization: > > 1. M-x customize-icon RET outline-open RET and the same for outline-close > 2. in the Plist section you can add own value for the face: > > Plist: > [INS] [DEL]: > Key: :face > Value: outline-2 > > PS: Maybe we need to add a new boolean option that will define > whether to inherit the face attribute from the buffer or > to use the outline faces. > --000000000000a2393d06059df7f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> PS: Maybe we need to add a new boolean option that wi= ll define
> whether to inherit the face attribute from the buffer or<= br>> to use the outline faces.

I think that might be the way to h= andle it. It might even be worth having that as the default because there m= ight be other faces that inherit from the buffer.

On Mon, Sep 18, 2023 at 6:= 59=E2=80=AFAM Juri Linkov <juri@linko= v.net> wrote:
> I kind of make use of the relatively new outline-minor-mode-butto= ns
> feature. I have specfic settings regarding whitespace mode and I
> observed that hides the outline buttons deeper than level 2. Trying to=
> debug this I found that was related to the whitespace-space face and > but looking at outline.el gave me no hit's as to why that was the<= br> > reason. So I am filing this issue with the minimal configuration to > recreate the issue.

Thanks for 100% reproducible case.=C2=A0 I don't know what whitespace-m= ode
does with whitespace where outline-minor-mode-buttons adds own text
properties for buttons, but it's clear there is a conflict between
these two packages each trying to do own stuff in the same shared part
of the buffer.=C2=A0 By default outline-minor-mode inherits text properties=
at the beginning of the line together with whitespace properties that
make the buttons not visible.

So you can just override the face inherited from the buffer with
own customization:

1. M-x customize-icon RET outline-open RET and the same for outline-close 2. in the Plist section you can add own value for the face:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Plist:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [INS] [DEL]:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Key: :face
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Value: outline-2

PS: Maybe we need to add a new boolean option that will define
whether to inherit the face attribute from the buffer or
to use the outline faces.
--000000000000a2393d06059df7f8--