From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yilkal Argaw Newsgroups: gmane.emacs.bugs Subject: bug#55800: using rgrep function interactively with fido-mode or fido-vertical-mode causes errors Date: Sun, 5 Jun 2022 16:25:34 +0300 Message-ID: References: <83wndvack5.fsf@gnu.org> <83pmjna1di.fsf@gnu.org> <83fskj9sax.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55800@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 05 15:26:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxqH5-0007z9-7l for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 15:26:35 +0200 Original-Received: from localhost ([::1]:45734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxqH3-0004bt-PI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 09:26:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxqGZ-0004aJ-2s for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 09:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxqGY-000287-QF for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 09:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxqGY-0006uW-Mn for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 09:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yilkal Argaw Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2022 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55800 X-GNU-PR-Package: emacs Original-Received: via spool by 55800-submit@debbugs.gnu.org id=B55800.165443555526549 (code B ref 55800); Sun, 05 Jun 2022 13:26:02 +0000 Original-Received: (at 55800) by debbugs.gnu.org; 5 Jun 2022 13:25:55 +0000 Original-Received: from localhost ([127.0.0.1]:60303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxqGQ-0006u9-TX for submit@debbugs.gnu.org; Sun, 05 Jun 2022 09:25:55 -0400 Original-Received: from mail-yw1-f172.google.com ([209.85.128.172]:41284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxqGN-0006tu-F7 for 55800@debbugs.gnu.org; Sun, 05 Jun 2022 09:25:53 -0400 Original-Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-30ce6492a60so121023077b3.8 for <55800@debbugs.gnu.org>; Sun, 05 Jun 2022 06:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F3+9AL1BcWg9g+i1rSFq27zBq1dVrxAGjx1xPhufP7Q=; b=RCuQ99uFm0Ad/ZTz6EnT1cbPSpzENPY0Q1CW3LI2tYMKrSjuewKfIomgKWp0A6KRGQ HOp/GGvasBh+AJhq/G6xaoVh+AZp+/03x0D/8vzfiOzxc6Nsi8hNkTFiBlfT1CELcexk 4TCLHmfN5bs0ohpVUPyezY63d0xWfoXnX6lL7WXeSPWb1FqXEnqeHL/T5tVFHXzw/2Qi lUlO4UNheJwjue9KW3EvDfXDeqVdBK8wAcFFR/B/Y6X7TyUsi/LRX0R55NkvEX14Lf+N ncatqAN1681fked3AKmtLL63cjp2vuLP1dWWbM8TYEbRgQRjU5t8Y70Ee8JKKIO+/8eC VzFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F3+9AL1BcWg9g+i1rSFq27zBq1dVrxAGjx1xPhufP7Q=; b=pEAvWWfcG0f15HbPj5qP5CDDeQxNc8idjWccnuuraMNXc04oz/jdijMug3WILQALjT uf/7z2UdTbgJZWdB3xcrTTJqVke6g0dsCLSfsaWFchK5tIxZQftJaBA6MbqK0xk5tKkM lSbd3qapKR4bXyhL3QqLjUOLejDSNhD+tCQPYRpMr8g0IaAa+bLeJajQ+aMX6WFknQxd BhTaPvi1U4qqR1gCaaUBxfVZHCeui/AJOWJyCVH3tm8yjf7crB5j2uu7TlVLXcaB6ODk MRSlfmj95sQ/A7bIeUJtKn2wctqbUhoegrDksfNBmJWoMOgr/GKERzU5tk7Na765P7RR NNVQ== X-Gm-Message-State: AOAM530k3WDRtd4/jblqIknIfKv3a/k/zVCOZVLpCSdcSihEHZ/Zo5AS ti3uXWkL+Ow50592USPma/NScrvFfqyJBw0r9lo= X-Google-Smtp-Source: ABdhPJzBwholHnO7Nz2e1rAJFws9LdgvxamwOUZpiW/wg1Wiz+dXM9tQa1dehqVyVGsrCJoQOxJezTRmNSDIEpRPo44= X-Received: by 2002:a81:4e16:0:b0:30c:4653:dd8b with SMTP id c22-20020a814e16000000b0030c4653dd8bmr21266048ywb.399.1654435545832; Sun, 05 Jun 2022 06:25:45 -0700 (PDT) In-Reply-To: <83fskj9sax.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233708 Archived-At: > The completion shows file names because the code calls > read-file-name-internal. Try the same without fido, and at the prompt > for the wildcard type '?' -- you will see a list of files. That's > what fido shows. > > Why that code calls read-file-name-internal, I don't know; perhaps > because it wants to support the use case of searching a single file or > files in a directory? I think that is done in the completion option after that where one selects the file name or a directory based on ones' needs. This option as I mentioned before it was supposed to be for file types. If there is no builtin list for file types(extensions) it might be sufficient to leave it alone or have it call a list which contains "*" only. I have checked the completion options for counsel-rg counsel-ag, consult-rg and they do it do it that way With Regards On Sun, Jun 5, 2022 at 4:03 PM Eli Zaretskii wrote: > > [Please use Reply All to keep the discussion recorded by the bug tracker.] > > > From: Yilkal Argaw > > Date: Sun, 5 Jun 2022 15:36:37 +0300 > > > > > from:Eli Zaretskii > > > to:Yilkal Argaw > > > cc:55800@debbugs.gnu.org > > > date:Jun 5, 2022, 12:47 PM > > > > > > The problem seems to be in grep-read-files, when fido-mode is used: > > > the prompt says "default all", but fido understands RET as selecting > > > the currently-highlighted candidate, which happens to be "./" -- and > > > that, of course, makes no sense as an argument to "-name". > > > > Why does the completion even show file names? In counsel-rg which > > is a command that does similar thing from in the counsel package,the > > second step shows file extension types like c,cpp,el. Can the behaviour > > of the behaviour be modified to show such completion options. > > The completion shows file names because the code calls > read-file-name-internal. Try the same without fido, and at the prompt > for the wildcard type '?' -- you will see a list of files. That's > what fido shows. > > Why that code calls read-file-name-internal, I don't know; perhaps > because it wants to support the use case of searching a single file or > files in a directory?