From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Samuel Wales Newsgroups: gmane.emacs.bugs Subject: bug#61396: diff mode could distinguish changed from deleted lines Date: Thu, 14 Sep 2023 18:58:20 -0700 Message-ID: References: <85f73356-3a11-c76c-dd9a-f2dc1f6ef504@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 61396@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 03:59:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgy6v-00089p-DA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 03:59:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgy6j-00023F-HT; Thu, 14 Sep 2023 21:58:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgy6i-00022k-7H for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 21:58:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgy6h-0007y1-VC for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 21:58:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgy6n-0003wt-Pg for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 21:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Samuel Wales Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 01:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61396 X-GNU-PR-Package: emacs Original-Received: via spool by 61396-submit@debbugs.gnu.org id=B61396.169474312115152 (code B ref 61396); Fri, 15 Sep 2023 01:59:01 +0000 Original-Received: (at 61396) by debbugs.gnu.org; 15 Sep 2023 01:58:41 +0000 Original-Received: from localhost ([127.0.0.1]:41547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgy6S-0003wJ-K2 for submit@debbugs.gnu.org; Thu, 14 Sep 2023 21:58:40 -0400 Original-Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:40004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgy6M-0003w1-QJ for 61396@debbugs.gnu.org; Thu, 14 Sep 2023 21:58:38 -0400 Original-Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2bbbe81185dso5179731fa.0 for <61396@debbugs.gnu.org>; Thu, 14 Sep 2023 18:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694743102; x=1695347902; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ArtbYIkUxO5BK1oYMZ7I1514Lb8TwW1YSD6zDP0c7QE=; b=PmhLaV534mgpA42sKcWuywy5nboLVJ+ormGG+xohIzXKGhQO9t1xiMuTlv3TsgiRUD a1HbSfRSjD47bQczhDlDqvcUWf9mm/bPHxyg5bg9TFV13x5rkjBIvQnL0Sl8yuMyugYA kUmm7HL3huo4nRdKJEuTcM4T19IVPNuJ0vgnBvk9A8EPtQQuqQdBgCbWLtuXPJU0+xv2 B6Me2YvAzqkzB1Mz+C6qt05wp0X4yEl1yPMK1ymWWweu+4syYrUCbLUEs6R0tjLrvHFL 9XXXCofpsxKLzYV3y+EELLb44OGjze3AdyFbGVezzQp+FJp6IkjmwRhgBj0KSbjLJdDN 8wUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694743102; x=1695347902; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ArtbYIkUxO5BK1oYMZ7I1514Lb8TwW1YSD6zDP0c7QE=; b=cgNqlzzg0K6WczIzzmrm1rH+qslJoY8NvPC680e5F99XFLRui5R5jR/8MocZNttbaF mv9RkA7Aexm4z2Ud+2y50nycn0nA29v+BTkR1O5feRuoghd9Xc328O3FpqqGWWPH+Haa 6CaM2GZKBh89nuCXOtlKuBovPsoN8sN47VxZ+nQXr3HXCM4ofYjVUyAYYqtNEl1kPsCR NcneBIujaUEEIawI9cugy3yaO76myFt8yc6qgg7Y7aOnMKBFhKQxHtv8DbsbNe1O4pZ/ vDOLvi7b3Ji1v7j3VNODBJ6x1G9IUFWx3nOiBJZdmWD1vq74Eq3uY5xbRV4BuSCkblTM GR3w== X-Gm-Message-State: AOJu0YxSOqaxei8h/5Ejo7BJPeZ8HfW58SWN0YVoCDNxmRgHSWqMcLmy 9ZLOx1naFKRsX4rxEVejF9aOHKnHdJAi+S5VHtc= X-Google-Smtp-Source: AGHT+IEgTB6hezaJvhzSLhGTb/b0ETnld0CT/QlXHjS+Z/VKQRIVjzlze4YJGX2XyKTUsQtF+1k8B8hVktXdG9WX+vg= X-Received: by 2002:ac2:53b0:0:b0:500:a2ad:bab with SMTP id j16-20020ac253b0000000b00500a2ad0babmr252689lfh.1.1694743101710; Thu, 14 Sep 2023 18:58:21 -0700 (PDT) Original-Received: by 2002:a05:6520:2481:b0:272:37a9:8c91 with HTTP; Thu, 14 Sep 2023 18:58:20 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270471 Archived-At: might need to distinguish from refilled paragraph. On 9/14/23, Stefan Monnier wrote: >> - Like Samuel mentioned, attenuate the indicators' column. Except instead >> of >> inverse video just apply the refine faces? See >> diff-refine-indicators.png. Looks good to me color-wise, though the >> change >> in the indication method is somewhat an inconsistency. > > I think I like that. But I'm not sure how to adapt this to my case > where I "prettify" the indicators into the fringe. > > Maybe a related idea would be to use the diff-refine-added/removed face > on the line-end: the reduced contrast is not a problem there since > there's no text. But it's not always visible (for long enough lines). > > I suspect we'll have to provide various alternatives and see which > ones stick. > > > Stefan > > -- The Kafka Pandemic A blog about science, health, human rights, and misopathy: https://thekafkapandemic.blogspot.com