From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Samuel Wales Newsgroups: gmane.emacs.bugs Subject: bug#61396: diff mode could distinguish changed from deleted lines Date: Fri, 10 Feb 2023 16:50:35 -0700 Message-ID: References: <868rh6yop8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61396@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 11 00:51:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQdAq-0002Eg-7i for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Feb 2023 00:51:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQdAX-0004Zw-6R; Fri, 10 Feb 2023 18:51:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQdAU-0004Yd-Gj for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 18:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQdAT-0005M0-MV for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 18:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQdAT-00045L-Iz for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 18:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Samuel Wales Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Feb 2023 23:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61396 X-GNU-PR-Package: emacs Original-Received: via spool by 61396-submit@debbugs.gnu.org id=B61396.167607304515678 (code B ref 61396); Fri, 10 Feb 2023 23:51:01 +0000 Original-Received: (at 61396) by debbugs.gnu.org; 10 Feb 2023 23:50:45 +0000 Original-Received: from localhost ([127.0.0.1]:38341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQdAC-00044m-S4 for submit@debbugs.gnu.org; Fri, 10 Feb 2023 18:50:45 -0500 Original-Received: from mail-lj1-f182.google.com ([209.85.208.182]:34794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQdAA-00044W-Dn for 61396@debbugs.gnu.org; Fri, 10 Feb 2023 18:50:42 -0500 Original-Received: by mail-lj1-f182.google.com with SMTP id o5so8141616ljj.1 for <61396@debbugs.gnu.org>; Fri, 10 Feb 2023 15:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=B2OjnrSQ73TxhG07zQXoHdAYehvPECDmNQnZ60c18js=; b=TbKeNUnEmzD7FWWF4oHR+EOyahVCjId4dAo9EdGh+e8rzIvfvZ9Y2gwafLiS2TSn2+ WrIav6Y0kfROux6pqovW48hb76blza4I82v3lPKUsnacsqnnnSYejdZsB43Lir7NQ8Qq 31VUnEqnqfw8cxfciqWV7uKMbDPmuttqLUgA2lvarHIajeIZ+4n6sKydCz2XbJfQedsr Efc8hNwRLfMF9UUpyefeIWm2+rPkow6h4GcP/D2PONCbBYR3UjE7D7tlZQOfQ8cjc+IE ssBYt0BaXIpN6e6HAcOhc809C9CMP9lixwLjl0fHDF7TjioMzlc7LQKabOk+pHTp/rIb 1k7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B2OjnrSQ73TxhG07zQXoHdAYehvPECDmNQnZ60c18js=; b=ZIp4TmCvVxAoWlGaYEqVRbgqxCXTMmwllhJ2uusi/DqS46NyNJMFCgePyOKc91JEMg AriOniFBtX2lquRczf9SYGHzwBEZSIsCj02Rk2yLSbNHHooGxcQQ6Cx5J1X+cRLkzxyT FBiz4iUe+iEdBoARXsM3nbUK4Y1UkaSGFU8AaLJIwHO8RQaYjD3C/8+tcty9d381/icG OqKPU8WZKlFN7XPt4ltfsHoycYsTdbicGPTfBLWzdoff5p3fFbLyQGwg/4OjDO059egC 2SIv13hlzdbOnWf8U+Og/kmgcGTlEgjHsJZIF8CAM6fbEaCdCXpG3uZqTlqxQm2mIGfV sC3g== X-Gm-Message-State: AO0yUKVUEMVSKgpfB7RBTEY9TCN4ACeFoyLOq/mZaAMsT1hbnDhA5stZ BfmLVzoVeuHCbJvm9l4QO6CzWRKzd6krhPXv1f7XAcBKoTZP5Q== X-Google-Smtp-Source: AK7set+t3MniISdXg9oswSmqzx26iJm+HwtT3jQUaKiaVFVl+Xo6sI/BChsxECqAToLfic9n4MGAy4DoZq6pJ0VUvNo= X-Received: by 2002:a2e:97d3:0:b0:293:1d08:99fd with SMTP id m19-20020a2e97d3000000b002931d0899fdmr3503431ljj.111.1676073036628; Fri, 10 Feb 2023 15:50:36 -0800 (PST) Original-Received: by 2002:aa6:c266:0:b0:23b:5e81:46ba with HTTP; Fri, 10 Feb 2023 15:50:35 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255308 Archived-At: highlighting for all good men in + is the current case. i am proposing that this is insufficient. - has no indication or highlighting other than del face and it is not a deleted line. On 2/10/23, Samuel Wales wrote: > it is an interesting idea to change the gutter from - to !, but i'm > not sure this is ok for diff -u, i think it could maybe break things?, > and it would not distinguish - from +. > > On 2/10/23, Juri Linkov wrote: >>> a fix is to have a different face for changed lines. i >>> suggest a muted bg face. another fix is to stick a colored >>> marker INDICATOR in A where changes in B exist. >>> >>> -now is the time^ >>> +now is the time FOR ALL GOOD MEN >>> >>> where ^ is a colored marker -- actually just a changed bg >>> for the newline in this case would work, but i don't think >>> emacs supports that. >> >> We have a dedicated face to indicate the changed lines. >> Its name is 'diff-changed' and it can be used for context diffs >> that have a special indicator '!' at the beginning of changed lines. >> Is it possible to output the same indicator for unified diffs? >> > > > -- > The Kafka Pandemic > > A blog about science, health, human rights, and misopathy: > https://thekafkapandemic.blogspot.com > -- The Kafka Pandemic A blog about science, health, human rights, and misopathy: https://thekafkapandemic.blogspot.com