From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Greselin Newsgroups: gmane.emacs.bugs Subject: bug#36147: 26.2; recentf-open-files doesn't display tree widgets when called from an emacsclient instance Date: Mon, 10 Jun 2019 08:27:19 +0200 Message-ID: References: <87ftoi25lz.fsf@gmail.com> <877e9u1u77.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e005bf058af2478a" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238879"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36147@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 10 08:29:43 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haDoM-000zz9-Ck for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 08:29:42 +0200 Original-Received: from localhost ([::1]:41118 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haDoK-0003rt-TN for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 02:29:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56979) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haDnk-0003rb-0X for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 02:29:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haDni-0001b9-PD for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 02:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haDni-0001b2-JN for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 02:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1haDni-0002TD-Ed for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 02:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Greselin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2019 06:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36147 X-GNU-PR-Package: emacs Original-Received: via spool by 36147-submit@debbugs.gnu.org id=B36147.15601480849427 (code B ref 36147); Mon, 10 Jun 2019 06:29:02 +0000 Original-Received: (at 36147) by debbugs.gnu.org; 10 Jun 2019 06:28:04 +0000 Original-Received: from localhost ([127.0.0.1]:55859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haDmm-0002Rz-1X for submit@debbugs.gnu.org; Mon, 10 Jun 2019 02:28:04 -0400 Original-Received: from mail-pg1-f171.google.com ([209.85.215.171]:43914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haDmk-0002RU-3r for 36147@debbugs.gnu.org; Mon, 10 Jun 2019 02:28:02 -0400 Original-Received: by mail-pg1-f171.google.com with SMTP id f25so4458006pgv.10 for <36147@debbugs.gnu.org>; Sun, 09 Jun 2019 23:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aiCHYxDsXbfUwfgfXxIenIcSRHDnvazx1oq2kwAFjL8=; b=CFknCLPa0mJyBQGNXvOJwa83mfSbIfwJwSSu4WcnwbxRhIiE0GQLVPLgVyUArirIKo IIS57IVwU0r8ESvQCaMyeGNZFw+8jIuReCgtqs2KSSvEBQrUwmSA7gX0JL0jcGXS7JzP Lfa+qmfO5tCQcUdfpx5HzJTvRSABPr/fISVduVo1T69lWo5rpYEJdPpxDKDD2wzf+qyJ TyM4s7hVrGfT0EFJOGZnnggFshGJhbf+QgVlBYkYDjVCjRgqVwIX/scgFVthy1LOd8CT ogOZ0lsKe3qAdqj2viNOhZ8IcwsGDeR56UDPcIePLHoKVgOy6LNfl5QRevD/vytwyrUE 6KYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aiCHYxDsXbfUwfgfXxIenIcSRHDnvazx1oq2kwAFjL8=; b=HmSJ8tSC9IM70TDgd0AK2OJJUW48dsBlw9ZJQZVD9FmF2FJd2qJLziZlUALxD0Auy1 cnQC7DJ1V60DDSARnY+d5ovDJxuZklWfHZN4LlvYDRPr7NtiJQ7pe2tbTUkkxonvGuBk QMnpdbiFe9mp6Cqj+AYGo7OfPzKRXX+INVW5s9DFCsgzUtuTy6nzYfWJXCMTeiMxpc1r 2m4XwYZv6ANm5JSJWTZBgJoIWDlAa09lnprSrqx5Ulg+kPnGnVtJy5rtYGdjNmyGcjZO 5g/nqgj9A9jL5CyMPdZco/yzVp0HVKmh2bTG3Mu2bgGeGpzm8xRVoNhdzio16MIsGLdw 4dyw== X-Gm-Message-State: APjAAAUwNcBOY/9zguynXgMvn7iF9AY+TBuKUGHBR7KpmpQNY5RDdivb BEW2HnYl25w5piaLbUneUigXOhwyTalyZ0y79rU= X-Google-Smtp-Source: APXvYqwHI8QJ/av5QFRzSu/ULbjATNDf4I611IvYXmk3srNxYbIDtdJQ4IBPtkiWSXqBPYYjQMUjmyGXhQPBHDV0dGs= X-Received: by 2002:a62:6:: with SMTP id 6mr9290663pfa.159.1560148076134; Sun, 09 Jun 2019 23:27:56 -0700 (PDT) In-Reply-To: <877e9u1u77.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160322 Archived-At: --000000000000e005bf058af2478a Content-Type: text/plain; charset="UTF-8" Yes, setting tree-widget-image-enable to t makes recentf-open-file work correctly in my system, too. On Sun, 9 Jun 2019 at 20:37, Noam Postavsky wrote: > Andrea Greselin writes: > > > Yes it does! Thank you! > > > > On Sun, 9 Jun 2019 at 16:30, Noam Postavsky wrote: > >> > >> I guess the problem is that tree-widget-image-enable is set just once on > >> load, based on the current display (and the daemon has no display so it > >> doesn't support displaying images). Does it help to explicitly set > >> tree-widget-image-enable to non-nil? > > Looks like we could solve this bug just by making > tree-widget-image-enable default to t unconditionally then. It seems to > do the right thing in that case, e.g., I tried > > ;; from > https://stackoverflow.com/questions/25104291/change-text-of-tree-widget-node > (widget-create > 'tree-widget :open t :tag "one" > :args > (list (widget-convert > 'tree-widget > :tag "two" > :args (mapcar (apply-partially #'widget-convert 'item) > '("three" "four"))))) > > it shows image when looking at it in a graphic frame, and text when > looking at the same buffer in a tty frame. > > --000000000000e005bf058af2478a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, setting tree-widget-image-enable to t makes rece= ntf-open-file work correctly in my system, too.

On Sun, 9 Jun 2019= at 20:37, Noam Postavsky <npostavs@gmail.com> wrote:
Andrea Greselin <greselin.andrea@gmail.com> wri= tes:

> Yes it does! Thank you!
>
> On Sun, 9 Jun 2019 at 16:30, Noam Postavsky <npostavs@gmail.com> wrote:
>>
>> I guess the problem is that tree-widget-image-enable is set just o= nce on
>> load, based on the current display (and the daemon has no display = so it
>> doesn't support displaying images).=C2=A0 Does it help to expl= icitly set
>> tree-widget-image-enable to non-nil?

Looks like we could solve this bug just by making
tree-widget-image-enable default to t unconditionally then.=C2=A0 It seems = to
do the right thing in that case, e.g., I tried

=C2=A0 =C2=A0 ;; from ht= tps://stackoverflow.com/questions/25104291/change-text-of-tree-widget-node<= /a>
=C2=A0 =C2=A0 (widget-create
=C2=A0 =C2=A0 =C2=A0'tree-widget :open t :tag "one"
=C2=A0 =C2=A0 =C2=A0:args
=C2=A0 =C2=A0 =C2=A0(list (widget-convert
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'tree-widget
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :tag "two"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :args (mapcar (apply-partially #&= #39;widget-convert 'item)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 '("three" "four")))))

it shows image when looking at it in a graphic frame, and text when
looking at the same buffer in a tty frame.

--000000000000e005bf058af2478a--