From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Irelan Newsgroups: gmane.emacs.bugs Subject: bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins) Date: Mon, 11 Oct 2021 19:40:54 -0700 Message-ID: References: <87a6jf3rft.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8932"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51140@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 12 04:42:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ma7kM-00028n-Kv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Oct 2021 04:42:30 +0200 Original-Received: from localhost ([::1]:40506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ma7kK-0004eP-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 22:42:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ma7ju-0004eG-H1 for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 22:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ma7ju-0004JK-7x for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 22:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ma7ju-0002Y0-5O for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 22:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Irelan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Oct 2021 02:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51140 X-GNU-PR-Package: emacs Original-Received: via spool by 51140-submit@debbugs.gnu.org id=B51140.16340064889748 (code B ref 51140); Tue, 12 Oct 2021 02:42:02 +0000 Original-Received: (at 51140) by debbugs.gnu.org; 12 Oct 2021 02:41:28 +0000 Original-Received: from localhost ([127.0.0.1]:33090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma7jM-0002XA-Ht for submit@debbugs.gnu.org; Mon, 11 Oct 2021 22:41:28 -0400 Original-Received: from mail-il1-f175.google.com ([209.85.166.175]:33777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma7jL-0002Wx-3V for 51140@debbugs.gnu.org; Mon, 11 Oct 2021 22:41:27 -0400 Original-Received: by mail-il1-f175.google.com with SMTP id s3so5541438ild.0 for <51140@debbugs.gnu.org>; Mon, 11 Oct 2021 19:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X7tr4upNFacK0i2OfBQYbFgRGBKfWVj6n82BxcThrvg=; b=ILd7kEeaDZ2xBD127Ib8EYWuqpgGzrv9rERhRZllOUsRVYxM0NlbEkq9eu9XaIHgjI vef8e11Xg1MU3lyzP8sfkeIb6rI3vN30drgjchbMQfSi0xrLvE9QWKV/vVr/3dz+MTQc UcgeyQQF3IDlf1aqsntZGctA9fVeWrologzux3b6D2F/3+bVyHYgRe7w+om+3v7gyUNm KKDdZQ+IH8HSXzPy0Ld9AjMZmJRFEACctdm6qvNkEwHIXZ6LeYH3EIr4ZVcDjuYBtWAm zpxyrn29qPF6zMh1WSkorv6Np0RyYa6PJP2MUnayS0owd8Ps9FTQf33xXdzjU6nEk6AQ cxIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X7tr4upNFacK0i2OfBQYbFgRGBKfWVj6n82BxcThrvg=; b=Ae42Y+Sc9jx1NdKZyaYHkF7D0QXBTUn1rtnJMVKCeAbxU+BAxa4tb+4tjeCPcJzAdd kIzJytk0vRTWl5TEZJmNz9mrVYgOETJlHbpsVl0Yi9U2mmvjY2PZJV2tvKErbEck79AM AlLKiLuMkDfjcgzIUJ19nUPzlFPGkzVlqcCe/Dx1hxGaCPBlrnHxitlLTUEDLWp1ccwh T7Dwm1TIPAVJJhIk0xafYKSohb9tzgBdvKdazutsNvnWyI4114Tk5rltK7+UpPZSN5SV oyRD9aKA2xbOcROMfVrPVStawq+/TwUaI2s15Aj+RKhjemuf423u3EoOkTPV3ZTyHViZ NmPA== X-Gm-Message-State: AOAM5325Y1nb8KnkhZytZex6s3ZGDb03wiRUlnV5KDtJUGchypiQLP/S 4xYnNth1zDRf3xuchUmf6KPYUh2SbgiFf5FoVA== X-Google-Smtp-Source: ABdhPJz6ArqcXYXMZgsQqxXOfxxC46NSqpAhW2XOVH9b7t1BKja0babfaTGgg/CFfQeCAVX04vwgN2J3dZln5W+RMTM= X-Received: by 2002:a05:6e02:1a28:: with SMTP id g8mr22859015ile.22.1634006481119; Mon, 11 Oct 2021 19:41:21 -0700 (PDT) In-Reply-To: <87a6jf3rft.fsf@web.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216981 Archived-At: I changed the function definition to the following, which I think doesn't have the free variable problem, and got the same error: (defun +ivy--always-return-zero-exit-code-a (fn &rest args) (let ((process-exit-status-orig (symbol-function 'process-exit-status))) (cl-letf* (((symbol-function 'process-exit-status) (lambda (_proc) (let ((code (funcall process-exit-status-orig proc))) (if (= code 2) 0 code))))) (apply fn args))) Interestingly, I now see the error when I evaluate the function definition, not when I call the advised function. I think this isolates it to `cl-flet`, since `symbol-function` seems to return the correct function definition and I can funcall that definition. (let* ((process-exit-status-orig (symbol-function 'process-exit-status)) (proc (start-process-shell-command "true" nil "true"))) (sleep-for 1) (funcall process-exit-status-orig proc)) returns 0, as expected. On Mon, Oct 11, 2021 at 7:30 PM Michael Heerdegen wrote: > > Robert Irelan writes: > > > (defun +ivy--always-return-zero-exit-code-a (fn &rest args) > > (cl-letf* (((symbol-function 'process-exit-status-orig) > > (symbol-function 'process-exit-status)) > > ((symbol-function 'process-exit-status) > > (lambda (_proc) > ^^^^^ > > (let ((code (process-exit-status-orig proc))) > ^^^^ > > I don't know about native compilation, I just found this free variable > problem when compiling your defun normally. You may want to correct > your recipe. > > Michael. -- Robert Irelan rirelan@gmail.com