From: James Stout <james.wolf.stout@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 16345@debbugs.gnu.org
Subject: bug#16345: 24.3; url-http sometimes closes connection prematurely
Date: Sun, 27 Dec 2015 15:28:32 -0800 [thread overview]
Message-ID: <CAJGMLzyR7pfioBVb+tr5UkW1T1EE2EE6Lafz32wCyhaeni0caA@mail.gmail.com> (raw)
In-Reply-To: <87fuyq2ril.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
I'm suggesting the following change:
Before: (if (re-search-forward "^\r*$" nil t) (url-http-debug "Saw end of
trailers..."))
After: (if (re-search-forward "^\r?\n" nil t) (url-http-debug "Saw end of
trailers..."))
This is based purely on my reading of the spec; this wasn't actually a
problem I ran into (and it's just going to affect a debug message).
On Fri, Dec 25, 2015 at 12:38 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> James Stout <james.wolf.stout@gmail.com> writes:
>
> > Yep, that fix works for me, thanks! Next time I'll be sure to check
> resolved bugs (I only checked open ones) and the source code trunk.
> >
> > I did notice that only one instance of the regular expression was
> changed. I'm not using chunked encoding with trailers, so it's hard for
> > me to verify whether this indeed is a bug, but I think this line also
> needs to be fixed:
> >
> http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/lisp/url/url-http.el#L1037
>
> Could you send a fix for the line in question?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
>
[-- Attachment #2: Type: text/html, Size: 1936 bytes --]
next prev parent reply other threads:[~2015-12-27 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 21:01 bug#16345: 24.3; url-http sometimes closes connection prematurely James Stout
2014-01-04 23:46 ` Glenn Morris
2014-01-05 19:59 ` James Stout
2015-12-25 20:38 ` Lars Ingebrigtsen
2015-12-27 23:28 ` James Stout [this message]
2015-12-28 17:49 ` Lars Ingebrigtsen
2015-12-28 18:50 ` James Stout
2015-12-28 19:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJGMLzyR7pfioBVb+tr5UkW1T1EE2EE6Lafz32wCyhaeni0caA@mail.gmail.com \
--to=james.wolf.stout@gmail.com \
--cc=16345@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).