From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: James Stout Newsgroups: gmane.emacs.bugs Subject: bug#16345: 24.3; url-http sometimes closes connection prematurely Date: Mon, 28 Dec 2015 10:50:44 -0800 Message-ID: References: <4u1u0n71jo.fsf@fencepost.gnu.org> <87fuyq2ril.fsf@gnus.org> <87d1tqv4y8.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b3a94e881b9080527f9c99d X-Trace: ger.gmane.org 1451328741 12206 80.91.229.3 (28 Dec 2015 18:52:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 18:52:21 +0000 (UTC) Cc: 16345@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 28 19:52:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDctv-0000Oc-0I for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 19:52:11 +0100 Original-Received: from localhost ([::1]:45857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDctu-0007XT-9N for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 13:52:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDctq-0007Vq-3U for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:52:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDctm-000856-5V for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:52:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDctm-000852-2K for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDctl-0007fs-L6 for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Stout Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 18:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16345-submit@debbugs.gnu.org id=B16345.145132867829448 (code B ref 16345); Mon, 28 Dec 2015 18:52:01 +0000 Original-Received: (at 16345) by debbugs.gnu.org; 28 Dec 2015 18:51:18 +0000 Original-Received: from localhost ([127.0.0.1]:46692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDct1-0007er-9Z for submit@debbugs.gnu.org; Mon, 28 Dec 2015 13:51:18 -0500 Original-Received: from mail-ig0-f179.google.com ([209.85.213.179]:33304) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDcsw-0007eb-7V for 16345@debbugs.gnu.org; Mon, 28 Dec 2015 13:51:14 -0500 Original-Received: by mail-ig0-f179.google.com with SMTP id mv3so121905051igc.0 for <16345@debbugs.gnu.org>; Mon, 28 Dec 2015 10:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=pMJ2hBN9331pk05/iPUQ4O7Tv/ogba06qku/vzQ9At4=; b=cwRQkIqAX3P62eAwnzMNMpGHE4REHBJS3N8i46MFIpXcV+LO0RhSQO5f3MmUJTeSXp jzWwFz36OiXls7ZY6AbFhEsRVUYTkW1qZXobpQ/qJwHK+m1RVXecBZR1n1Uf86gSwYDy ll91/c0QrggwUSxj30D5CFpdrSHeLKhzkCU9yCOs662jN859pXPPWhfWkM5w7ZA8vDS/ cXQthV6aBBi2EmH/nWF6fAM49eS1YYzMXIBw/vMk4dnAt3yTrSGJVgZovbq/Hh2Khvep XyEJdc6vpwWTEZt/da07bFhVNiuXArj7u1QjlyuELgj5KwY24cOhpVO1EkWqqKDsj6p3 fQ0w== X-Received: by 10.50.70.70 with SMTP id k6mr15503070igu.69.1451328664604; Mon, 28 Dec 2015 10:51:04 -0800 (PST) Original-Received: by 10.79.117.148 with HTTP; Mon, 28 Dec 2015 10:50:44 -0800 (PST) In-Reply-To: <87d1tqv4y8.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110913 Archived-At: --047d7b3a94e881b9080527f9c99d Content-Type: multipart/alternative; boundary=047d7b3a94e881b9020527f9c99b --047d7b3a94e881b9020527f9c99b Content-Type: text/plain; charset=UTF-8 This is the first Emacs patch I've ever sent; let me know if I'm doing it wrong. On Mon, Dec 28, 2015 at 9:49 AM, Lars Ingebrigtsen wrote: > James Stout writes: > > > I'm suggesting the following change: > > > > Before: (if (re-search-forward "^\r*$" nil t) (url-http-debug "Saw end of > > trailers...")) > > After: (if (re-search-forward "^\r?\n" nil t) (url-http-debug "Saw end of > > trailers...")) > > > > This is based purely on my reading of the spec; this wasn't actually a > problem > > I ran into (and it's just going to affect a debug message). > > Can you send a patch for the change? > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --047d7b3a94e881b9020527f9c99b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
This is the first Emacs patch I've ever sent; let me k= now if I'm doing it wrong.

On Mon, Dec 28, 2015 at 9:49 AM, Lars Ingebrigtsen <larsi@= gnus.org> wrote:
James Stout <jame= s.wolf.stout@gmail.com> writes:

> I'm suggesting the following change:
>
> Before: (if (re-search-forward "^\r*$" nil t) (url-http-debu= g "Saw end of
> trailers..."))
> After: (if (re-search-forward "^\r?\n" nil t) (url-http-debu= g "Saw end of
> trailers..."))
>
> This is based purely on my reading of the spec; this wasn't actual= ly a problem
> I ran into (and it's just going to affect a debug message).

Can you send a patch for the change?

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no

--047d7b3a94e881b9020527f9c99b-- --047d7b3a94e881b9080527f9c99d Content-Type: application/octet-stream; name="0001-Fixed-regular-expression-for-end-of-HTTP-trailers-to.patch" Content-Disposition: attachment; filename="0001-Fixed-regular-expression-for-end-of-HTTP-trailers-to.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iiqbkya20 RnJvbSBhYjJjNGIzMWE2NjE5ZGQwZGJkY2FhYjU1ZTMyZTJiNmE4MDgyNmI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW1lcyBTdG91dCA8amFtZXMud29sZi5zdG91dEBnbWFpbC5j b20+CkRhdGU6IE1vbiwgMjggRGVjIDIwMTUgMTA6NDc6MzEgLTA4MDAKU3ViamVjdDogW1BBVENI XSBGaXhlZCByZWd1bGFyIGV4cHJlc3Npb24gZm9yIGVuZCBvZiBIVFRQIHRyYWlsZXJzIHRvIG1h dGNoCiBzcGVjLgoKLS0tCiBsaXNwL3VybC91cmwtaHR0cC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdXJs L3VybC1odHRwLmVsIGIvbGlzcC91cmwvdXJsLWh0dHAuZWwKaW5kZXggOTE2ZjI2My4uZTVjMmMz YSAxMDA2NDQKLS0tIGEvbGlzcC91cmwvdXJsLWh0dHAuZWwKKysrIGIvbGlzcC91cmwvdXJsLWh0 dHAuZWwKQEAgLTEwNjcsNyArMTA2Nyw3IEBAIHRoZSBlbmQgb2YgdGhlIGRvY3VtZW50LiIKIAkJ ICAod2hlbiAobG9va2luZy1hdCAiXHI/XG4iKQogCQkgICAgKHVybC1odHRwLWRlYnVnICJSZW1v dmluZyB0ZXJtaW5hdG9yIG9mIGxhc3QgY2h1bmsiKQogCQkgICAgKGRlbGV0ZS1yZWdpb24gKG1h dGNoLWJlZ2lubmluZyAwKSAobWF0Y2gtZW5kIDApKSkKLQkJICAoaWYgKHJlLXNlYXJjaC1mb3J3 YXJkICJeXHIqJCIgbmlsIHQpCisJCSAgKGlmIChyZS1zZWFyY2gtZm9yd2FyZCAiXlxyP1xuIiBu aWwgdCkKIAkJICAgICAgKHVybC1odHRwLWRlYnVnICJTYXcgZW5kIG9mIHRyYWlsZXJzLi4uIikp CiAJCSAgKGlmICh1cmwtaHR0cC1wYXJzZS1oZWFkZXJzKQogCQkgICAgICAodXJsLWh0dHAtYWN0 aXZhdGUtY2FsbGJhY2spKSkpKSkpKSkpCi0tIAoyLjYuMgoK --047d7b3a94e881b9080527f9c99d--