bug#19493: [PATCH] Fix trailing ... for outline-toggle-children

[Oleh Krehel <o.krehel@tue.nl>]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

I attach the updated patch.

On 19 January 2015 at 05:14, Dmitry Gutov <dgutov@yandex.ru> wrote:

> That doesn't seem to be the full solution either. For instance, if the
> current heading has subheadings, with or without your patch "..." will
> remain at the end of the last of them.

If you're using `outline-toggle-children', it's supposed to leave the
children hidden.

The patch basically just fixes `outline-show-entry', which was is called by
`outline-toggle-children' in my original issue.

Oleh

[-- Attachment #2: 0001-lisp-outline.el-outline-show-entry-Fix-one-invisible.patch --]
[-- Type: text/x-patch, Size: 1183 bytes --]

From 78ada3f9fcbd6fa066038325174561bf6a95e493 Mon Sep 17 00:00:00 2001
From: Oleh Krehel <ohwoeowho@gmail.com>
Date: Sat, 7 Feb 2015 18:54:07 +0100
Subject: [PATCH] lisp/outline.el (outline-show-entry): Fix one invisible char

* lisp/outline.el (outline-show-entry): Previously, when called for
the last outline in a file, a single invisible char was left.
Add a check for this condition.
---
 lisp/outline.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/outline.el b/lisp/outline.el
index ae31b80..059ca62 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -777,7 +777,12 @@ Show the heading too, if it is currently invisible."
   (save-excursion
     (outline-back-to-heading t)
     (outline-flag-region (1- (point))
-                         (progn (outline-next-preface) (point)) nil)))
+                         (progn
+                           (outline-next-preface)
+                           (if (= 1 (- (point-max) (point)))
+                               (point-max)
+                             (point)))
+                         nil)))
 
 (define-obsolete-function-alias
     'show-entry 'outline-show-entry "25.1")
-- 
1.8.4