From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philip Hudson Newsgroups: gmane.emacs.bugs Subject: bug#33460: 24.4; Eshell histfile symlinks not followed Date: Wed, 21 Nov 2018 23:09:16 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c6ddae057b34d755" X-Trace: blaine.gmane.org 1542842715 14792 195.159.176.226 (21 Nov 2018 23:25:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2018 23:25:15 +0000 (UTC) To: 33460@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 22 00:25:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbrp-0003hs-C4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Nov 2018 00:25:09 +0100 Original-Received: from localhost ([::1]:43068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbtv-0006UC-L3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 18:27:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbtm-0006Ss-CR for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:27:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPbte-0003br-TS for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:27:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPbte-0003b8-Od for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPbte-0005z7-Io for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Hudson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Nov 2018 23:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33460 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154284280622980 (code B ref -1); Wed, 21 Nov 2018 23:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Nov 2018 23:26:46 +0000 Original-Received: from localhost ([127.0.0.1]:40340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbtO-0005yZ-Gg for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:26:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbd8-0005V4-8w for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:09:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPbd1-0004zq-LU for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:09:52 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPbd1-0004yh-A8 for submit@debbugs.gnu.org; Wed, 21 Nov 2018 18:09:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbcz-0000Gu-Ux for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:09:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPbcw-0004sC-MD for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:09:49 -0500 Original-Received: from mail-pl1-f196.google.com ([209.85.214.196]:45775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPbcs-0004jX-Sh for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 18:09:45 -0500 Original-Received: by mail-pl1-f196.google.com with SMTP id a14so7530918plm.12 for ; Wed, 21 Nov 2018 15:09:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=aovTCD6wwgNbb6IdHWOOcleF5MqOMn4eWCOM6+x5b9c=; b=E+RA6hspOfNczNMpczxsG763mcVxsAktur67L5jz6i/kbGM5ApLBkTAnOZP1Sntpxk r4JhOI0qT92wSLrQHiLFJQLohU4NZvWQHzP4gkPCXDIFeuzPRXUiQwVf7mm39oixXPw3 Q6nNI04uFxOHtgzFyifpt44JStCQMBkEzzF3k9NHhbSC+zViph9h0DY/qjhnJ1s4Jkac YVjYHcasgpaEhNGDDDeIi60aUza94Fr+Fqw8pxA/Dun0cyJ+pIcgwkI5ygdkaSWcE/pO eWGWzHqonjjJCcS/HKaT3PtY3asC1ubabYvHLmB3An+gRS7FbOEOC36sXwy/YmFYql5+ z2TA== X-Gm-Message-State: AA+aEWZKNqS0NVaCm9yTUryfWimMb2S7juDokF6eirPV1Z5rxQm6lKBt hT3pLmx9uNOf2ogFhD528Jk9oe60KtyJeNWQFR5Brg== X-Google-Smtp-Source: AFSGD/UUUZfGO0786GTu9EuqiDSEmoMMr3U/HYbBT0i36PxrjYjWtcEWsik81kECm8hWb/9K7pdiD0yf48jh3h3ytC4= X-Received: by 2002:a17:902:f81:: with SMTP id 1mr2020867plz.174.1542841772190; Wed, 21 Nov 2018 15:09:32 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Wed, 21 Nov 2018 18:26:43 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152653 Archived-At: --000000000000c6ddae057b34d755 Content-Type: text/plain; charset="UTF-8" If the file named by the value of option `eshell-history-file-name' is a symbolic link, then it will be replaced and overwritten instead. It should be dereferenced (followed) first, and its target file should be replaced and overwritten. The attached patch uses function `file-truename' to fix this. The patch was made using source cloned from git savannah HEAD today, which I think is version 26.1.90, based on ChangeLog.3 in the cloned repo. In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.5) of 2017-09-12 on hullmann, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.11604000 System Description: LMDE 2 Betsy -- Phil Hudson http://hudson-it.ddns.net Pretty Good Privacy (PGP) ID: 0x4E482F85 --000000000000c6ddae057b34d755 Content-Type: text/x-patch; charset="US-ASCII"; name="eshellResolveHistFile.patch" Content-Disposition: attachment; filename="eshellResolveHistFile.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jors4rdx0 ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwgYi9saXNwL2VzaGVsbC9lbS1oaXN0 LmVsCmluZGV4IDYyZTJmNTcuLmY4NjZkZmQgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWhp c3QuZWwKKysrIGIvbGlzcC9lc2hlbGwvZW0taGlzdC5lbApAQCAtNDY2LDE1ICs0NjYsMTYgQEAg bG9zdCBpZiBgZXNoZWxsLWhpc3RvcnktcmluZycgaXMgbm90IGVtcHR5LiAgSWYKIFVzZWZ1bCB3 aXRoaW4gcHJvY2VzcyBzZW50aW5lbHMuCiAKIFNlZSBhbHNvIGBlc2hlbGwtcmVhZC1oaXN0b3J5 Jy4iCi0gIChsZXQgKChmaWxlIChvciBmaWxlbmFtZSBlc2hlbGwtaGlzdG9yeS1maWxlLW5hbWUp KSkKKyAgKGxldCogKChmaWxlIChvciBmaWxlbmFtZSBlc2hlbGwtaGlzdG9yeS1maWxlLW5hbWUp KQorCSAocmVzb2x2ZWQtZmlsZSAoZmlsZS10cnVlbmFtZSBmaWxlKSkpCiAgICAgKGNvbmQKICAg ICAgKChvciAobnVsbCBmaWxlKQogCSAgKGVxdWFsIGZpbGUgIiIpCiAJICAobnVsbCBlc2hlbGwt aGlzdG9yeS1yaW5nKQogCSAgKHJpbmctZW1wdHktcCBlc2hlbGwtaGlzdG9yeS1yaW5nKSkKICAg ICAgIG5pbCkKLSAgICAgKChub3QgKGZpbGUtd3JpdGFibGUtcCBmaWxlKSkKLSAgICAgIChtZXNz YWdlICJDYW5ub3Qgd3JpdGUgaGlzdG9yeSBmaWxlICVzIiBmaWxlKSkKKyAgICAgKChub3QgKGZp bGUtd3JpdGFibGUtcCByZXNvbHZlZC1maWxlKSkKKyAgICAgIChtZXNzYWdlICJDYW5ub3Qgd3Jp dGUgaGlzdG9yeSBmaWxlICVzIiByZXNvbHZlZC1maWxlKSkKICAgICAgKHQKICAgICAgIChsZXQq ICgocmluZyBlc2hlbGwtaGlzdG9yeS1yaW5nKQogCSAgICAgKGluZGV4IChyaW5nLWxlbmd0aCBy aW5nKSkpCkBAIC00ODksNyArNDkwLDcgQEAgU2VlIGFsc28gYGVzaGVsbC1yZWFkLWhpc3Rvcnkn LiIKICAgICAgICAgICAgICAgKGluc2VydCAoc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMgKHJpbmct cmVmIHJpbmcgaW5kZXgpKSA/XG4pCiAJICAgICAgKHN1YnN0LWNoYXItaW4tcmVnaW9uIHN0YXJ0 ICgxLSAocG9pbnQpKSA/XG4gP1wxNzcpKSkKIAkgIChlc2hlbGwtd2l0aC1wcml2YXRlLWZpbGUt bW9kZXMKLQkgICAod3JpdGUtcmVnaW9uIChwb2ludC1taW4pIChwb2ludC1tYXgpIGZpbGUgYXBw ZW5kCisJICAgKHdyaXRlLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSByZXNvbHZlZC1m aWxlIGFwcGVuZAogCQkJICduby1tZXNzYWdlKSkpKSkpKSkKIAogKGRlZnVuIGVzaGVsbC1saXN0 LWhpc3RvcnkgKCkK --000000000000c6ddae057b34d755--