unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Darren Hoo <darren.hoo@gmail.com>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 15668@debbugs.gnu.org
Subject: bug#15668: 24.3.50; No font lock on active region
Date: Tue, 22 Oct 2013 05:36:38 +0800	[thread overview]
Message-ID: <CAJ+QY_E+yAQW+ix6J--1M3A0P7C+ssPuy0YeZ_Dhaye2fE_Xjg@mail.gmail.com> (raw)
In-Reply-To: <C30E13CB-347C-4972-9DC3-2FDC03703FB8@swipnet.se>


[-- Attachment #1.1: Type: text/plain, Size: 1908 bytes --]

Hi,

On Tue, Oct 22, 2013 at 2:47 AM, Jan Djärv <jan.h.d@swipnet.se> wrote:

>
> Both Gtk+ and NS does this.  The reason is that we use the system defined
> selection colors, and the background may be ill-matched to Emacs foreground
> colors.
> For example, many Gnome settings use an almost black color for selection
> background, so Emacs black for text color is almost unreadable.  These
> settings use white(ish) for text color which is much better.  But by
> setting foreground selection color, you loose font-lock.  OSX uses a light
> blue for background, which is very near to blue used by
> font-lock-constant-face and also near font-lock-function-name-face.
>
> It would be nice if one could define a face with a foreground color to be
> used when foreground and background otherwise are to similar.
>


I've noticed the changes you made in revno: 114473, I can customize-faces
of region for
my own preference. But I would argue that it might be better to leave
foreground  of
region face to be unspecified by default and only use
 ns_selection_bg_color for background.
Let Emacs theme designers take care of the use ns_selection_fg_color if
they want to
their theme to work flawlessly on OSX.

I suppose that many users do want fancy font-lock on active regions as many
IDE does
although even on text-mode this behaviour between different Emacs releases
is non-consistent.

I think the reason Gtk uses both gtk_selection_fg_color and
gtk_selection_bg_color is that
there are many themes for user to choose and different GNU/Linux
distributors choose different
themes thus the fock-lock on regions thing has to lose . But on OSX the
color of highlight text is
seldom changed (or at least for me).

By default I find that both font-lock-constant-face and
font-lock-function-name-face are quite
readable on the default light blue selectedBackgroundColor.

[-- Attachment #1.2: Type: text/html, Size: 2512 bytes --]

[-- Attachment #2: faces.png --]
[-- Type: image/png, Size: 27378 bytes --]

      parent reply	other threads:[~2013-10-21 21:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21  5:56 bug#15668: 24.3.50; No font lock on active region Darren Hoo
2013-10-21 16:30 ` Eli Zaretskii
2013-10-21 18:47   ` Jan Djärv
2013-10-21 19:06     ` Eli Zaretskii
2013-10-21 19:20       ` Eli Zaretskii
2013-10-22 16:14       ` Jan Djärv
2013-10-22 16:28         ` Eli Zaretskii
2013-11-01 15:54           ` Jan Djärv
2013-10-21 21:36     ` Darren Hoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+QY_E+yAQW+ix6J--1M3A0P7C+ssPuy0YeZ_Dhaye2fE_Xjg@mail.gmail.com \
    --to=darren.hoo@gmail.com \
    --cc=15668@debbugs.gnu.org \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).