From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#38024: Remove icomplete workaround Date: Sun, 31 Oct 2021 23:55:49 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36681"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org, joaotavora@gmail.com, kevin.legouguec@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 01 04:57:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhORh-0009Jx-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 04:57:17 +0100 Original-Received: from localhost ([::1]:58820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhORg-0003Hf-6i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 23:57:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhORT-0003HV-4b for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 23:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhORS-0007mo-NG for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 23:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhORS-0003lq-GR for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 23:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Nov 2021 03:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38024 X-GNU-PR-Package: emacs Original-Received: via spool by 38024-submit@debbugs.gnu.org id=B38024.163573896814421 (code B ref 38024); Mon, 01 Nov 2021 03:57:02 +0000 Original-Received: (at 38024) by debbugs.gnu.org; 1 Nov 2021 03:56:08 +0000 Original-Received: from localhost ([127.0.0.1]:33482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhOQa-0003kX-GC for submit@debbugs.gnu.org; Sun, 31 Oct 2021 23:56:08 -0400 Original-Received: from mail-pl1-f182.google.com ([209.85.214.182]:35750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhOQY-0003k3-Ma for 38024@debbugs.gnu.org; Sun, 31 Oct 2021 23:56:07 -0400 Original-Received: by mail-pl1-f182.google.com with SMTP id n18so10733795plc.2 for <38024@debbugs.gnu.org>; Sun, 31 Oct 2021 20:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MlQuR4uhkdxDae/niNoI0y8V7UHhtakevyGmuvkqkCo=; b=Y14pi0XFR8l5LvtlZLFtpzInMuR0ZvsaZV/t6FEOd/3yyUJ0N1zomj/etQxtDSsuAq rHtJTW/mLaPSRoQaILS+LYFBIJOHzA1t1cyhtU+2TJRBMpe9PRpGFTdsVlZgSAFrxaOv PEYjpKs+m5i+w/Tx4ZV6wDUJDJNEbT7BXbmUWhM5sI/o2t59U3KMimXQl/CbRmAub81s DAoS9clXJJws+TYAXf2X/PqU38BY5UEK2/hPwnveQfY4IRkeJ7N/vTTl8Rf10UtI+opp 7e/JnYIersMdHO+xeozQ2r3DoLdvMcy2sWFVV7x9IZeHu9db1G3W+peY1AdYq7zYjeQh aSgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MlQuR4uhkdxDae/niNoI0y8V7UHhtakevyGmuvkqkCo=; b=cbcgYOvoxhgPNOPdN3N37pqYBD6EIlxSihOBOtJAiBUmyzaAUzLc/uU67a15nPl8uY fa/YGgmV0XjcsTQkpW9InN7nV09d9+WObOEpKHMuYsu9w78dWvCHVyYC7mGDwPIZJ8ui LS4MsBEAitXEwtesBjyqrGe/LKHa9fbe4fUu7tALBTBLtnvT2uf+pNEXgLwfMLQewCaB lghyeWS6Ljeva6mZDkS9ivl+bZu0uPEOIYZ1ch3dahp4BMMnMs76p8LQPZp+UilsHd2k j12rCQCjZ3xT/xPj6HaM0gPF4QpfY8jhRlmy15gm+WjR8SeeUr6oIP9BysOwPKo5ThKw CCTg== X-Gm-Message-State: AOAM532KJnCw51MS8t6DDXh9n2db/SflieAklbNW6iWpDbAF9qLC2ykF 8UIMuDTe3RwyQJSCfkD9oxIiD/34vIJfW9tSnHQ= X-Google-Smtp-Source: ABdhPJxX1pc+kiuf4gFu66wSdS//P9IDt5FYBF8gpo579vRPcsPVfO81oZWYnqRcB2fbOnmdVn5kdJH3kg3rUQPvcds= X-Received: by 2002:a17:90a:c78f:: with SMTP id gn15mr12138666pjb.54.1635738960611; Sun, 31 Oct 2021 20:56:00 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218743 Archived-At: On Sun, Oct 31, 2021 at 10:38 PM Stefan Monnier wrote: > > Aaron Jensen [2021-10-31 20:49:23] wrote: > > Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024 > > > > The reason this fixed things was not captured and I can not reproduce > > the bug with the fix disabled on master. > > > > This workaround has been copied to other libraries without clear > > understanding of why it existed in the first place and it caused a > > problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581 > > > > Would it be possible to remove it? I'm ccing the original reporter and > > fixer in case they are able to shed more light on this or test without > > the fix to see if they can reproduce it. > > > > I've attached a patch if we are good to remove it. > > Thanks, I just pushed your patch to `master`. > We'll see if the problem comes back, and if so, we'll have to try and > fix it better. Great, thank you!