From: Aaron Jensen <aaronjensen@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org,
joaotavora@gmail.com, kevin.legouguec@gmail.com
Subject: bug#38024: Remove icomplete workaround
Date: Sun, 31 Oct 2021 23:55:49 -0400 [thread overview]
Message-ID: <CAHyO48zxhCxTJYo6MXokmq0NLvG-HWDFCbSrB7ss=VEPQUgr3g@mail.gmail.com> (raw)
In-Reply-To: <jwvcznkhaey.fsf-monnier+emacs@gnu.org>
On Sun, Oct 31, 2021 at 10:38 PM Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>
> Aaron Jensen [2021-10-31 20:49:23] wrote:
> > Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024
> >
> > The reason this fixed things was not captured and I can not reproduce
> > the bug with the fix disabled on master.
> >
> > This workaround has been copied to other libraries without clear
> > understanding of why it existed in the first place and it caused a
> > problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581
> >
> > Would it be possible to remove it? I'm ccing the original reporter and
> > fixer in case they are able to shed more light on this or test without
> > the fix to see if they can reproduce it.
> >
> > I've attached a patch if we are good to remove it.
>
> Thanks, I just pushed your patch to `master`.
> We'll see if the problem comes back, and if so, we'll have to try and
> fix it better.
Great, thank you!
next prev parent reply other threads:[~2021-11-01 3:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHyO48wYzmHL0FEc9e3peZXzHdxOSwoF4da3Qvjd2XyWvPqoMg@mail.gmail.com>
2021-11-01 2:38 ` bug#38024: Remove icomplete workaround Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-01 3:55 ` Aaron Jensen [this message]
2021-11-01 9:28 ` Kévin Le Gouguec
2021-11-01 15:33 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHyO48zxhCxTJYo6MXokmq0NLvG-HWDFCbSrB7ss=VEPQUgr3g@mail.gmail.com' \
--to=aaronjensen@gmail.com \
--cc=38024@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=kevin.legouguec@gmail.com \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).