From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sat, 7 Dec 2024 14:59:30 -0500 Message-ID: References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d9674f0628b391c5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32631"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, me@eshelyaron.com, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 21:01:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tK0zN-0008FB-3u for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 21:01:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tK0zG-0005oE-MD; Sat, 07 Dec 2024 15:01:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tK0zA-0005np-BX for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 15:01:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tK0z8-0002hi-U4 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 15:01:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:References:In-Reply-To:From:Mime-Version:To:Subject; bh=IsRr5xpr1kfK2RBM7ae8pJJhYGQGCVuDeQlFq9c1Mqc=; b=kbO64isaEUz2WBBWKwvZoWG1Z4v8tFXqmcFRo3oqWTDxevkObJfe3V2a9+00D9tdW12CuAKnhyG3PlzYSlU6BSvg9tHwbosO3aE/vJtmFp/05IiprRbXBSKPBl0wfiyWE7rKQuLw6DCxKksq23JE0lzsNYEFh9LpqwM2Eg71V84pf16wTSzqWT75tn3y9ohpHtjsg672k7rW4TRA/sIk/3YV1ndn9Wgb7UnEWC9ifQfOy/aC5NS47t1A5LBdFlKG2+H8uHo+RQiTmgZVOsQNY694tYtu8SX4QVHiuSHc6CfbC9ZvwyWLwurJlo7mAsVE2mogdxuPR2do0DjSSqLZHQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tK0z8-0008NR-FM for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 15:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173360164332164 (code B ref 73862); Sat, 07 Dec 2024 20:01:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 7 Dec 2024 20:00:43 +0000 Original-Received: from localhost ([127.0.0.1]:48619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK0yo-0008Mg-Qa for submit@debbugs.gnu.org; Sat, 07 Dec 2024 15:00:43 -0500 Original-Received: from mail-lj1-f180.google.com ([209.85.208.180]:48598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK0yj-0008ML-Pc for 73862@debbugs.gnu.org; Sat, 07 Dec 2024 15:00:41 -0500 Original-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-3003e203acaso8144541fa.1 for <73862@debbugs.gnu.org>; Sat, 07 Dec 2024 12:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733601572; x=1734206372; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IsRr5xpr1kfK2RBM7ae8pJJhYGQGCVuDeQlFq9c1Mqc=; b=hlHe4ZLc9DpjMvFu1mUYkwdYPvIsr1QQebEVNi/zQDm3IwcYiXLrS8d8TqSDpowFxZ IqkUku4w2xsTbRQrFR/ApqMtXQ0ZeAE7Z7Lwnx2fdRj4oD7Z8il37a56IH6RpHuHCCMg 3MWMOW05guUc4w1w1Wb/jXqfaF6qd8bQA4Srd5dY7l6Za3M5nCGgVenJkDAukU4QmRmx kHbRaA0TtV6e7xrszEN4kb6VtSCLU/W0LUEBmXNoeYTKTGDKEFNQR0V+HQ8GMUeUIz6x DiOIsxk0zK/rHdDB4AJ6K/OqpgK2eT8CHWN4vCNgsCWDh7weQz3z5k6DgrDrmz2dktiv YbRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733601572; x=1734206372; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IsRr5xpr1kfK2RBM7ae8pJJhYGQGCVuDeQlFq9c1Mqc=; b=thEXc108E20lUV3zBFGVHGKNF6uh+nYusJ1TDcQlJSbrQAsCgzLmAE0uJHNLpwf09w 1nT4AJwc53mg0AKSnoaQWcy8b3VuVnpkdxzMyCzIlwHJdDRj+HjUP6R5oSnbMwFQFLPT 5QX6Y66QV5PtYxT+Vb157vTLrGpt32ZQQKichXYl1UKtKqvw5d5g0iy/6swejGvh3yBF wm6hAU67QPRwyp69WKxYRxzPd3cOiz5Kuna+GwC5rpg9egymPNQOooi9RH+DnZvRUups kl+atgzudlVk7WbqoLU9R3wE6Sl+Czde50MS4hkKrixARndXNTvYYcZBm3hZKBZbYp7m dPnw== X-Forwarded-Encrypted: i=1; AJvYcCXKf8fhqyrqU4dPwsDCyHc7L51UPxr/DUYHh0YJVIRutj4Fe3Xv+KzeuoikgMsBqvJK79/v+A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwUDP+5GkQ0s8TDbMcXxkbkwI/KRd9Jf/32VFNGCT20OYMNdHab Z1MDSAMKRgsIceIPG4wGxbYiMFViLCPcJKIy1XiHKyNeQHHkNBTWpaFgjN9aFVA+vxv+P/Aycsa 09AxgJJVnCTLzIuLEhcEKMyo4Cok= X-Gm-Gg: ASbGncuzoz+ze0+3/69Dukrj9jklTGwhwRV5t6SrMt70sEzay8ruFQLHvalz+irKdtu 7Ei+CL7OEz1ZD+XrAB0tnEaGnpn7lO9jrNq/n9/XnEdyDIVYDGKOlDA5V X-Google-Smtp-Source: AGHT+IFGUSIk1UwsyXfyqbH18mQVODO5AJOVRQTpmDRXYtpy1yntlH0QJgDfIZ79821ckQv+dwOXGCN7dsf3E2xVSok= X-Received: by 2002:a05:651c:154f:b0:300:3a15:8f1f with SMTP id 38308e7fff4ca-3003a1593admr23882761fa.32.1733601571461; Sat, 07 Dec 2024 11:59:31 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sat, 7 Dec 2024 14:59:30 -0500 X-Superhuman-ID: m4ello73.95a68c99-786f-4ac0-90b7-696c251d971d In-Reply-To: <86r06jgv1j.fsf@gnu.org> X-Mailer: Superhuman Desktop (2024-12-02T20:06:08Z) X-Superhuman-Draft-ID: draft000d29c40e307c9b X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296601 Archived-At: --000000000000d9674f0628b391c5 Content-Type: text/plain; charset="UTF-8" On Sat, Dec 07, 2024 at 11:19 AM, Eli Zaretskii wrote: > From: Aaron Jensen > Date: Sat, 7 Dec 2024 14:06:35 -0500 > Cc: monnier@iro.umontreal.ca, trevor.m.murphy@gmail.com, me@eshelyaron.com, > 73862@debbugs.gnu.org > > Would it make sense to extend the face doc strings that should not use > inheritance to indicate that? > > I'm not sure. Inheritance does work for the basic faces, it's just that > face-remapping doesn't get passed by inheritance. > Yeah, I guess that'd be throwing the baby out with the bathwater. I retract. Another possibility would be to issue a warning when attempting to remap mode-line or header-line. The user would at least see that what they're doing is fraught. I believe this would require reconciling the terminal vs GUI difference for mode-line you mentioned earlier. This would still be adding specialization in a generalized place, and arguably that's a worse place to do it than where you added it in your patch, so feel free to disregard that idea. Thanks, Aaron --000000000000d9674f0628b391c5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Dec 07, 2024 at 11:19 AM, Eli Zaretskii <eliz@gnu.org> wrote:
<= div class=3D"sh-quoted-content">
=

From: Aaron Jensen <aaronjensen@gmail.c= om>
Date: Sat, 7 Dec 202= 4 14:06:35 -0500
Cc: monnier@iro.umontreal.ca, = trevor.m.murphy@gmail.com, me@eshelyaron.com,=20 73862@debbugs.gnu.org

Would it make sense to extend the face doc strings that should not use inheritance to indicate that?

I'm not sure. Inheritance does work for the basic faces, it's just that face-remapping doesn't get passed by inheritance.


Yeah, I gu= ess that'd be throwing the baby out with the bathwater. I retract.
<= /div>

Another possibility would be to issue a warning wh= en attempting=C2=A0to remap mode-line or header-line. The user would at lea= st see that what they're doing is fraught. I believe this would require= reconciling the terminal vs GUI difference for mode-line you mentioned ear= lier. This would still be adding specialization in a generalized place, and= arguably that's a worse place to do it than where you added it in your= patch, so feel free to disregard that idea.

T= hanks,

Aaron

<= div>
--000000000000d9674f0628b391c5--