From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Date: Mon, 1 May 2023 10:06:51 -0400 Message-ID: References: <87ilddec31.fsf@yahoo.com> <87edo0exct.fsf@yahoo.com> <83wn1sns1n.fsf@gnu.org> <87pm7kchqw.fsf@yahoo.com> <83pm7knpzi.fsf@gnu.org> <83o7n4noql.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11678"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, alan@idiocy.org, 63187@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 16:08:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptUCO-0002om-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 16:08:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptUCC-0004AP-LK; Mon, 01 May 2023 10:08:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptUCB-0004A4-LN for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 10:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptUCB-0007uA-D6 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 10:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptUCA-0002o8-E6 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63187 X-GNU-PR-Package: emacs Original-Received: via spool by 63187-submit@debbugs.gnu.org id=B63187.168295003410718 (code B ref 63187); Mon, 01 May 2023 14:08:02 +0000 Original-Received: (at 63187) by debbugs.gnu.org; 1 May 2023 14:07:14 +0000 Original-Received: from localhost ([127.0.0.1]:40788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptUBN-0002mn-HT for submit@debbugs.gnu.org; Mon, 01 May 2023 10:07:13 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:52559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptUBJ-0002mW-2m for 63187@debbugs.gnu.org; Mon, 01 May 2023 10:07:12 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-51fdc1a1270so1620286a12.1 for <63187@debbugs.gnu.org>; Mon, 01 May 2023 07:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682950023; x=1685542023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WJrotv/1IOJwyvGHzcKsqgVL9vPYq+tqv/BVJNAIbwA=; b=lpuL9NYuAG3kG5GBbkKILjMN68mOExXzL648EEutLGUFvd+8B0cJ4EQ8+OkKqrpSpi xrK0XqTZwzSOgz3GTOqaOmWrnSwIuBvWSuDyFZb+EfQ9g39RiOGH/w96fDFCtYT2NbVs 6E89uMYqA5zaxG64cWmx1D99OKkSAc7q9f8/+24nTTnTD52B5mBybvv1tOTSYmea1cD2 +TuSYpvBy+HIe24u6aPPhETifJX1g05cHinnkVnqopiR9Mjq2b7ijYVzvZ7juy69/1Td +jVQtJ2UKDKdo6YtKPZITutcph9z6U1YxGnqGtPwLNeihiMCWZz/yeoQahjZA/A6bRwB uzbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682950023; x=1685542023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WJrotv/1IOJwyvGHzcKsqgVL9vPYq+tqv/BVJNAIbwA=; b=DI9WAOrF/Fp6cA9CAuT6x58NHj+diMLymRU6kvXVKnZPNtP296tBBcURMGsxfypIgy KGlzR0y0azunR1J+HHAPsIlUA3tfuTykUd/jC5YAD+F/xGV6vhjxqdOH1hsT3wTxoeI3 ra74AUtmS9BwQJl1vVNOUIu6NIb25uP7JFrZTMhILO2GXjq1867tjP26bzWHfMS8QsVT KUleRr6tqVKpiCbrMVn7tjyYywXU4Sb3PV+mS/GsaiXY+F7L0v39Wk33NfaD6o5h8jRG zy3cKn5R92zwjCbxWMKaDa/ozV6vVo58uv7yR2cyT+AmbevQ/gFQ/K2PWaaVbQFd3sGT eu1A== X-Gm-Message-State: AC+VfDy2OouFwPhHCu+hgVm6Pc3PS8Q/ow6S2l4aJAXkrke4PIpU8sn+ 4DZvSGMKDUuGpYsFuVyxv1Y3b6Ry4DPWiKRelhQ= X-Google-Smtp-Source: ACHHUZ5le123V6zhh9tap90PwT3ZLkawHRt+kgiK0tK1CwwvvcdT5E8Lz7oVRdGmknUJUmS+89WEuf0E0suq8+8/kdY= X-Received: by 2002:a17:90a:cc0b:b0:24d:f507:5437 with SMTP id b11-20020a17090acc0b00b0024df5075437mr4684036pju.41.1682950023160; Mon, 01 May 2023 07:07:03 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260872 Archived-At: On Mon, May 1, 2023 at 9:55=E2=80=AFAM Aaron Jensen = wrote: > > On Mon, May 1, 2023 at 9:51=E2=80=AFAM Eli Zaretskii wrote= : > > > > > From: Aaron Jensen > > > Date: Mon, 1 May 2023 09:47:50 -0400 > > > Cc: Po Lu , Alan Third , 63187@d= ebbugs.gnu.org > > > > > > { > > > NSRect srcRect =3D NSMakeRect (x, from_y, width, height); > > > NSPoint dest =3D NSMakePoint (x, to_y); > > > EmacsView *view =3D FRAME_NS_VIEW (f); > > > > > > [view copyRect:srcRect to:dest]; > > > #ifdef NS_IMPL_COCOA > > > [view setNeedsDisplayInRect:srcRect]; > > > #endif > > > } > > > > > > Why is the source being marked for redisplay? I would expect the > > > destination to be marked as such, or am I missing something? > > > > IMO, both should be marked for redisplay. Or maybe I don't understand > > the significance of marking a rectangle for redisplay. > > For reference, this is in `ns_scroll_run'. Only the destination is > changed, right? I imagine the source would be effectively marked when > it's copied into, so marking the source in this code would be > redundant, unless I'm missing something? Also, the previous version of `ns_flush_display' was this: static void ns_flush_display (struct frame *f) /* Force the frame to redisplay. If areas have previously been marked dirty by setNeedsDisplayInRect (in ns_clip_to_rect), then this will call draw_rect: which will "expose" those areas. */ { block_input (); [FRAME_NS_VIEW (f) displayIfNeeded]; unblock_input (); } The displayIfNeeded has been removed and is now ultimately replaced with stuff I don't understand. After looking at this code, I'm now wondering if my problem has to do with the fact that I use child frames for things like completions. I have recollection of the painting artifacts appearing under areas that child frames are temporarily covering. Is it possible that somehow those areas aren't being properly repainted/marked for repainting?