From: Aaron Jensen <aaronjensen@gmail.com>
To: Alan Third <alan@idiocy.org>, Kai Ma <justksqsf@gmail.com>,
Aaron Jensen <aaronjensen@gmail.com>,
63187@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Po Lu <luangruo@yahoo.com>
Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS
Date: Thu, 20 Jul 2023 22:02:53 -0400 [thread overview]
Message-ID: <CAHyO48zaMwXQrX9YiEpcewrrAUXU3srKW1+ZFgiQgWVUpm0+5w@mail.gmail.com> (raw)
In-Reply-To: <ZJyPtpTUMT30rD0X@idiocy.org>
On Wed, Jun 28, 2023 at 3:53 PM Alan Third <alan@idiocy.org> wrote:
>
> On Mon, Jun 26, 2023 at 03:27:41PM +0800, Kai Ma wrote:
> >
> >
> > > On Jun 25, 2023, at 20:46, Alan Third <alan@idiocy.org> wrote:
> > >
> > >>>
> > >>> modified src/nsterm.m @@ -10622,7 +10622,7 @@ - (void) display
> > >>> {
> > >>> NSTRACE_WHEN (NSTRACE_GROUP_FOCUS, "[EmacsLayer display]");
> > >>>
> > >>> - if (context)
> > >>> + if (context && context != [NSGraphicsContext currentContext])
> > >>> {
> > >>> [self releaseContext];
> > >>>
> > >>>
> > >>> ...
> > >>>
> > >>> Actually...
> > >>>
> > >>> That change should probably be made anyway. If the NS run loop kicks
> > >>> in between an ns_focus call and an ns_unfocus call, it could call
> > >>> display and our display function will happily destroy the existing
> > >>> context without creating a new one, so any *subsequent* drawing
> > >>> operations, up until ns_unfocus, will be lost.
> > >>
> > >> OK, I'm adding this to my current build.
> > >>
> > >> Is this in line with the type of issue I'm seeing where scrolling
> > >> works but the ghosting either replicates (or scrolls with it?) In
> > >> other words, what would you expect to see in this scenario? Would it
> > >> just stop painting entirely?
> > >
> > >
> > > Kai, it might be worth trying just that change above, while keeping
> > > the call to performSelectorInMainThread and see if it fixes anything
> > > for you.
> >
> > Unfortunately, the problem persists (as in the YouTube video) if performSelectorInMainThread is present.
>
> OK. Thanks for trying it.
I've been using this for about a month now and have seen no artifacts:
diff --git a/src/nsterm.m b/src/nsterm.m
index 78089906752..d23fb650ab8 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -2708,9 +2708,6 @@ Hide the window (X11 semantics)
EmacsView *view = FRAME_NS_VIEW (f);
[view copyRect:srcRect to:dest];
-#ifdef NS_IMPL_COCOA
- [view setNeedsDisplayInRect:destRect];
-#endif
}
unblock_input ();
@@ -10435,7 +10432,7 @@ @implementation EmacsLayer
cache. If no free surfaces are found in the cache then a new one
is created. */
-#define CACHE_MAX_SIZE 2
+#define CACHE_MAX_SIZE 1
- (id) initWithColorSpace: (CGColorSpaceRef)cs
{
@@ -10621,7 +10618,7 @@ - (void) display
{
NSTRACE_WHEN (NSTRACE_GROUP_FOCUS, "[EmacsLayer display]");
- if (context)
+ if (context && context != [NSGraphicsContext currentContext])
{
[self releaseContext];
I'm not sure what the ramifications are for CACHE_MAX_SIZE 1 on slower
machines, but I don't notice any performance issues on my M1.
Alan, what do you think we should do? Is there anything else you think
I should test for the next bit of time?
Thanks,
Aaron
next prev parent reply other threads:[~2023-07-21 2:02 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2fs8histt.fsf@gmail.com>
2023-04-30 10:33 ` bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Eli Zaretskii
2023-04-30 10:46 ` Aaron Jensen
2023-04-30 13:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-30 14:25 ` Aaron Jensen
2023-04-30 14:42 ` Eli Zaretskii
2023-04-30 14:57 ` Aaron Jensen
2023-04-30 15:26 ` Eli Zaretskii
2023-04-30 16:48 ` Aaron Jensen
2023-04-30 19:04 ` Eli Zaretskii
2023-04-30 23:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-01 12:40 ` Eli Zaretskii
2023-05-01 13:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-01 13:25 ` Eli Zaretskii
2023-05-01 13:47 ` Aaron Jensen
2023-05-01 13:52 ` Eli Zaretskii
2023-05-01 13:55 ` Aaron Jensen
2023-05-01 14:06 ` Aaron Jensen
2023-05-09 3:07 ` Aaron Jensen
2023-05-09 5:39 ` Eli Zaretskii
2023-05-13 13:54 ` Eli Zaretskii
2023-05-13 14:23 ` Aaron Jensen
2023-05-18 11:21 ` Eli Zaretskii
2023-05-18 15:59 ` Aaron Jensen
2023-06-08 5:40 ` Kai Ma
2023-06-08 7:33 ` Kai Ma
2023-06-08 12:51 ` Alan Third
2023-06-08 13:42 ` Kai Ma
2023-06-08 14:57 ` Kai Ma
2023-06-08 17:22 ` Alan Third
2023-06-09 2:42 ` Kai Ma
2023-06-09 2:47 ` Aaron Jensen
2023-06-09 3:12 ` Kai Ma
2023-06-09 18:27 ` Alan Third
2023-06-09 18:46 ` Aaron Jensen
2023-06-09 20:00 ` Alan Third
2023-06-12 13:04 ` Aaron Jensen
2023-06-16 2:17 ` Aaron Jensen
2023-06-19 15:46 ` Aaron Jensen
2023-06-24 4:17 ` Kai Ma
2023-06-24 13:34 ` Aaron Jensen
2023-06-24 14:14 ` Alan Third
2023-06-24 14:52 ` Aaron Jensen
2023-06-24 15:08 ` Eli Zaretskii
2023-06-24 15:41 ` Alan Third
2023-06-24 16:05 ` Aaron Jensen
2023-06-24 21:29 ` Alan Third
2023-06-24 21:43 ` Aaron Jensen
2023-06-25 12:46 ` Alan Third
2023-06-25 17:07 ` Aaron Jensen
2023-06-25 18:17 ` Alan Third
2023-06-25 19:07 ` Aaron Jensen
2023-06-25 21:18 ` Alan Third
2023-06-25 22:33 ` Aaron Jensen
2023-06-26 7:27 ` Kai Ma
2023-06-28 19:53 ` Alan Third
2023-07-21 2:02 ` Aaron Jensen [this message]
2023-07-23 11:20 ` Alan Third
2023-07-23 13:01 ` Aaron Jensen
2023-07-25 14:47 ` Aaron Jensen
2023-07-25 15:45 ` Eli Zaretskii
2023-06-23 8:48 ` Alan Third
2023-06-23 11:54 ` Aaron Jensen
2023-05-01 17:26 ` Alan Third
2023-05-01 22:40 ` Aaron Jensen
2023-05-02 10:14 ` Alan Third
2023-05-02 12:21 ` Eli Zaretskii
2023-05-02 22:36 ` Alan Third
2023-05-03 8:11 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-03 13:08 ` Eli Zaretskii
2023-05-02 0:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-02 0:32 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHyO48zaMwXQrX9YiEpcewrrAUXU3srKW1+ZFgiQgWVUpm0+5w@mail.gmail.com \
--to=aaronjensen@gmail.com \
--cc=63187@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=justksqsf@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).