bug#30141: (26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes)

[Aaron Jensen <aaronjensen@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Wed, Mar 14, 2018 at 1:14 AM, martin rudalics <rudalics@gmx.at> wrote:
> When creating a frame we could make the parameter inherit from the
> current value of `frame-resize-pixelwise' unless the parameter has
> been specified explicitly for the new frame.  But unless we can find a
> sufficiently strong reason for implementing such a parameter, it might
> be better to pursue your proposal first.  This would avoid that we
> have to introduce a function like `frame-resize-pixelwise' which tells
> for a specific frame whether it should be resized pixelwise or not.

Awesome, I've always felt like that was the most expected behavior.
Patch attached.

[-- Attachment #2: 0001-Save-frame-pixel-width-height-if-frame-resize-pixelw.patch --]
[-- Type: application/octet-stream, Size: 1988 bytes --]

From 436442959739f3b62acf37da5996b356821a64e6 Mon Sep 17 00:00:00 2001
From: Aaron Jensen <aaronjensen@gmail.com>
Date: Wed, 14 Mar 2018 07:51:25 -0700
Subject: [PATCH] Save frame pixel/width height if frame-resize-pixelwise is
 non-nil

* lisp/frameset.el (frameset--record-relationships): Replace check for
  text width/height and replace with check for frame-resize-pixelwise.
---
 lisp/frameset.el | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/lisp/frameset.el b/lisp/frameset.el
index 0e3363d7ae..8bccc8b1d2 100644
--- a/lisp/frameset.el
+++ b/lisp/frameset.el
@@ -800,22 +800,17 @@ frameset--record-relationships
              (cons nil
                    (and mb-frame
                         (frameset-frame-id mb-frame)))))))))
-  ;; Now store text-pixel width and height if it differs from the calculated
-  ;; width and height and the frame is not fullscreen.
+  ;; Now store text-pixel width and height if `frame-resize-pixelwise'
+  ;; is set.
   (dolist (frame frame-list)
-    (unless (frame-parameter frame 'fullscreen)
-      (unless (eq (* (frame-parameter frame 'width)
-                     (frame-char-width frame))
-                  (frame-text-width frame))
-        (set-frame-parameter
-         frame 'frameset--text-pixel-width
-         (frame-text-width frame)))
-      (unless (eq (* (frame-parameter frame 'height)
-                     (frame-char-height frame))
-                  (frame-text-height frame))
-        (set-frame-parameter
-         frame 'frameset--text-pixel-height
-         (frame-text-height frame))))))
+    (when (and frame-resize-pixelwise
+               (not (frame-parameter frame 'fullscreen)))
+      (set-frame-parameter
+       frame 'frameset--text-pixel-width
+       (frame-text-width frame))
+      (set-frame-parameter
+       frame 'frameset--text-pixel-height
+       (frame-text-height frame)))))
 
 ;;;###autoload
 (cl-defun frameset-save (frame-list
-- 
2.15.1