From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#32932: [PATCH v2] Fix more drawing bugs in NS port (bug#32932) Date: Mon, 19 Nov 2018 18:30:05 -0800 Message-ID: References: <20181109090855.GA31723@breton.holly.idiocy.org> <20181113221336.GA65891@breton.holly.idiocy.org> <20181119223548.GA2325@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1542680950 13141 195.159.176.226 (20 Nov 2018 02:29:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Nov 2018 02:29:10 +0000 (UTC) Cc: Boris Buliga , 32932@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 20 03:29:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOvmj-0003Jj-KD for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Nov 2018 03:29:05 +0100 Original-Received: from localhost ([::1]:59915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOvoq-0006oA-7J for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Nov 2018 21:31:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOvoh-0006o3-BI for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 21:31:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOvod-0001d2-Dn for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 21:31:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57244) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gOvob-0001Za-VH for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 21:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gOvob-0005e3-Qg for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2018 21:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Nov 2018 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154268101621643 (code B ref 32932); Tue, 20 Nov 2018 02:31:01 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 20 Nov 2018 02:30:16 +0000 Original-Received: from localhost ([127.0.0.1]:33269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOvns-0005d1-2n for submit@debbugs.gnu.org; Mon, 19 Nov 2018 21:30:16 -0500 Original-Received: from mail-yw1-f65.google.com ([209.85.161.65]:42744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOvnq-0005bv-8e for 32932@debbugs.gnu.org; Mon, 19 Nov 2018 21:30:14 -0500 Original-Received: by mail-yw1-f65.google.com with SMTP id x2so158959ywc.9 for <32932@debbugs.gnu.org>; Mon, 19 Nov 2018 18:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=AjWk9Enide/suwpck+90NsgyoaJOn5YEqUFzK5o+QAs=; b=gSBRrrRQYuHq8bmXGZHxGR6iFFYfinQj+zoDY8ZES92PJyTeIqGsntQAFShR77ZQZL WHPdbMuA5tY1+hZcq2UTNs/Yqr7MqQsPmViE7ldorIyadiLcs6SYy4/VXg2t/wxLuqPE +bVOgE2HDY1LnmA35RQvb8IeStk6FQosfSwU8puiPVoK7UbrUPD8lE/2FUJb4dznFpdY dBNKuUD7kOhz78oxk1MV5iD2oBfsRrm+uX4FfTnR4cIBqNqbj9WYkxyQwj8vDVA18R66 XX5QQz2iUdHAAGMikzRzMUgTTzW2ZanjL/FUmf0cT8MhrD8qNOSlrm1eF4WP/csUPqk3 zysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=AjWk9Enide/suwpck+90NsgyoaJOn5YEqUFzK5o+QAs=; b=kXXxQ2AJzDS72jmjjqnrDpnFB6JlCPZSEQmwSj3mCGunnn883pGFbSbaE5BMnqp3vI iBP3FAMBQzAllcSKbMM+k+JLQnyrgr8iXN0PJD+3UK82YeBEdPrhm3giHU9IluPKL5Bv 0ftq+HPgPDDHGuYS7uNGFC/z/xbaS471KHclAfnaVFRzLusHhzonVIzTgtpZ4NCSG/wE ci18CRWcRBRfygFFWPBvO+DSsE/xT0+9RNBSqTQ64eCyE1JUZk5PznKVjYOoXmT4YWZO YwIS4G27nL40YBxj4SjJv0ZCYNs6lrSBBDDw1zR1LFCOvTPTpPoHyWK2A2eWrF8cxIff J3Dg== X-Gm-Message-State: AGRZ1gJrsduxsfLCjNkFTlAyOA6rqvzU9h8KnQQCwKecsj1gDMYg5SRF EaDbfmcfRciTK79DmEozSSwJ3VhLYCvdJp7U350kJVVh X-Google-Smtp-Source: AJdET5cLnKriBQajwBVup04gZyd9Wvj4Qmjn/R5JQMLttAcNZt6KI3KPhGTcSZFkwUmUoSW3o8DgMjzCM1u52NnaNyE= X-Received: by 2002:a81:460b:: with SMTP id t11-v6mr142961ywa.441.1542681007087; Mon, 19 Nov 2018 18:30:07 -0800 (PST) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Nov 2018 18:30:05 -0800 In-Reply-To: <20181119223548.GA2325@breton.holly.idiocy.org> X-Mailer: Airmail (528) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152554 Archived-At: On November 19, 2018 at 2:35:51 PM, Alan Third (alan@idiocy.org(mailto:alan@idiocy.org)) wrote: > On Thu, Nov 15, 2018 at 05:20:09PM -0800, Aaron Jensen wrote: > > On November 14, 2018 at 10:19:39 AM, Alan Third > > (alan@idiocy.org(mailto:alan@idiocy.org)) wrote: > > > > > I suspect that's due to the whitespace checks that the Emacs tree > > > builds into git. I know there's a way to disable them, but I don't > > > know what. > > > > > > You could just try reverting the commits yourself and then > > > extracting the 4th patch from the file and applying it. > > > > Okay, I was able to apply them. It renders a blank frame, however. > > Today I realised I=E2=80=99m able to install Mojave on an external HDD wi= thout > affecting my High Sierra install, so I gave it a go and this patch > works, so I guess it maybe didn=E2=80=99t apply correctly. Perhaps it doe= sn=E2=80=99t > apply to master? Oh, good I=E2=80=99m glad you're able to test it now. I was able to get the patch to apply properly by deleting everything in .git/hooks and then applying your patch to emacs-26. I was then able to merge that to master and it worked. It is, however, unusably slow. The performance degrades more the bigger the frame is. I=E2=80=99ve gone back to what I was using before (mas= ter + the patch you reference below). > Given that Emacs 26.2 is in pre=E2=80=90release now I=E2=80=99m inclined = to leave > emacs-26 as=E2=80=90is for now, unless we require the 8th of November pat= ch > (Further changes to NS drawing (bug#32932))? I don=E2=80=99t think we do = as > iirc it just solves a minor redrawing issue (i.e. Emacs is still > usable without it). Is that right? Yes, it is still usable, though if I remember correctly it lessens the overall blank glitches (which still happen even w/ the patch). So yes, it=E2=80=99s usable, but you do occasionally have to resize the window or d= o something else to get it to repaint. You still have to w/ the patch, just less often. Thanks, Aaron