From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sat, 7 Dec 2024 07:28:33 -0600 Message-ID: References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ace10a0628ae1bde" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12405"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, me@eshelyaron.com, Stefan Monnier , 73862@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 14:30:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJusx-00035q-Ah for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 14:30:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJusp-0000J3-1y; Sat, 07 Dec 2024 08:30:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJusl-0000I6-09 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:30:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJusk-0002vt-Gr for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:30:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:References:From:In-Reply-To:Mime-Version:To:Subject; bh=4+dG/RbKR1jAPgvdehDSnPEY+IkRm81YQgY+PzOgAfE=; b=ZysxR/XBtL+BAQUIMP65X39cpM79Su73SVC7H8sr0CAyhPB2OByOJjsKB0Gls9C2qitl+6mPCvADfRFA/1nIPc89iQPibQSRWS5OnQ/thJKFnCNa9mJg0HbgAyKTBj6vTACBDR9osZaY9JKFM3S4dFdTFWDWb+wYH/mnnZPdeqFzlXIQNh+Ews7LQZzNBWzJ1p83+9lTlfQUHQif048C6g9ItzmNvFa0IliTZ2rmaBRiqi0Nx3Asp/6bH8AXy0NQAqH7KqHCsb0rkfKo72KbVO9KnO1Zkut8Y0dclNrTOa3f3dKTumq9JeLSjm9S+kf1Fg2kLbvpx/2cDhDJ7tcFew==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJusk-0005Fk-BT for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173357818320131 (code B ref 73862); Sat, 07 Dec 2024 13:30:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 7 Dec 2024 13:29:43 +0000 Original-Received: from localhost ([127.0.0.1]:45965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJusQ-0005Eb-IU for submit@debbugs.gnu.org; Sat, 07 Dec 2024 08:29:43 -0500 Original-Received: from mail-lj1-f179.google.com ([209.85.208.179]:50317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJusO-0005EM-CV for 73862@debbugs.gnu.org; Sat, 07 Dec 2024 08:29:41 -0500 Original-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-3001d009633so25951411fa.0 for <73862@debbugs.gnu.org>; Sat, 07 Dec 2024 05:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733578114; x=1734182914; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4+dG/RbKR1jAPgvdehDSnPEY+IkRm81YQgY+PzOgAfE=; b=T9w53EyIdzT8NL6V2lm541KWUhbtJlSDREvXsQWJ/Wy0qVt8TeNKLZsnsAb1dMHgIw s8YAlU/dYNb3oBeuZTdAyA66+zeWoCnPn930R/Wl/WrsGSXvfQOHflXl+dvpNWRfb7P+ vUad50xro3jqtAD7u93f/koU+OgMA0Qv5haMKd/YfVoh08HbHcJCwPLQ3sQRF1RxiSwB 0rhe5BsViBdmNEXzfrPW0yAAs72bams5C/loKPnf0Tt9/zkpf2VbH2Ln5eO/dXPZr7U9 /HxHeeexjzph2WM+qr8uD/wHvpvCglfrflE6DnutCZUk3mWUqf6eR5sVNnNTOPWxfiw2 IKoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733578114; x=1734182914; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4+dG/RbKR1jAPgvdehDSnPEY+IkRm81YQgY+PzOgAfE=; b=Vg9pdNcJfqfMXkDOKyvcKqp7MSauNYiJ030ujyzNPp8tGhr7pPsFs+aM7g2AKAFKfF Lm44YEsm5tsRTPNqyPuAPc3zSIw21PGNbUDQevRZ2akFFJzJO2uH/Ud2+l0sb1yCsSvw 08hF5cBHmS13METV6SZ83qTDiHeNAC+sGXXy9OVHde4GKQz/kcingAWQSJUHUpuTCDw5 LbpS6G1LOOW1ZosTfl3iVDki5whuoa0whKPCNiOCDugWi+T013ETKFu4VzdunbJsYmji LehEv+0tEOcXzH2t4PiUxnS+yww2B3dNZmjQrehntd0X9/UBiCx6C51sZ4OoZF3+KhYH cgtQ== X-Forwarded-Encrypted: i=1; AJvYcCXxU1h0eQguNw7Hfw+fSU5alihLhLqEMhfPSJzQ3ibO13mJj/5obGZzq4nboZDIPLVKTitMtw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxFR0FoJ2hH+B318VR4moKhmH/eP2gYwN46qiWz6R7ZR+eKAQ2s Pq61lO5p9nwV+uN950olnjCviynxnY2A9eJJ55MqmzQkOKr/FCDRoNgNYWSzbVgM8ITp7Pdlr+v qMJTtffao94zxCp7NHu6p+d6/Zeg= X-Gm-Gg: ASbGnctj34ylLmwpwnJCurLK12/NTlENobS8i2n99E2xwLbPd17h8ODoHUghLZrTgxu 5XIQj3LuJXV3OUylHJvSbxmGvPh1JOruOz6oMjVGeAWhUcxi0aUeb4F5K X-Google-Smtp-Source: AGHT+IEpqwyijPMbItte+q7dkbnHc53EGFNMO1y5gkaHIBorVv7mH2ztPnEVa9aFhhffKp9qV4u7+luttGFBKALgEmA= X-Received: by 2002:a2e:9a0e:0:b0:300:1d45:8705 with SMTP id 38308e7fff4ca-3002f8aa077mr21539011fa.1.1733578113996; Sat, 07 Dec 2024 05:28:33 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sat, 7 Dec 2024 07:28:33 -0600 X-Superhuman-Draft-ID: draft00c7da932ae014ff In-Reply-To: <86ldwrkeiy.fsf@gnu.org> X-Mailer: Superhuman Desktop (2024-12-02T20:06:08Z) X-Superhuman-ID: m4e7mwia.398bed27-545d-4704-a69a-3f07fbf82f3f X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296566 Archived-At: --000000000000ace10a0628ae1bde Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 07, 2024 at 1:50 AM, Eli Zaretskii wrote: > If we do prefer to support remapping mode-line and header-line faces, the= n > I can suggest the semi-kludgey "fix" below. Is this better than what we > have now? > Does this patch make it so that remaps are considered for header-line even if header-line-active no longer inherits from header-line? If so, I'd consider that even more surprising. The more I think about this, the less inclined I'd be to play special case whack-a-mole with it and the more I'd be inclined to either "live with it" or figure out a way to disable remapping entirely in certain rendering contexts. Tab bar mode is another one that comes to mind that probably shouldn't use remaps at all when rendering. We could treat the computing of basic faces similarly=E2=80=A6 a= side from the initial remap of *-inactive/active, remapping would stop being considered. If that's not feasible, then I don't see this proposed patch as better. Users have already made do with the header-line transition in 29 it sounds like. Thanks, --000000000000ace10a0628ae1bde Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Dec 07, 2024 at 1:50 AM, Eli Zaretskii= <eliz@gnu.org> wrote: <= br>

If we do prefer to support re= mapping mode-line and header-line faces, then I can suggest the semi-kludgey "fix" below. Is this better = than what we have now?

<= div class=3D"">

Does this patch ma= ke it so that remaps are considered for header-line even if header-line-act= ive no longer inherits from header-line? If so, I'd consider that even = more surprising. The more I think about this, the less inclined I'd be = to play special case whack-a-mole with it and the more I'd be inclined = to either "live with it" or figure out a way to disable remapping= entirely in certain rendering contexts. Tab bar mode is another one that c= omes to mind that probably shouldn't use remaps at all when rendering. = We could treat the computing=C2=A0of basic faces similarly=E2=80=A6 aside f= rom the initial remap of *-inactive/active, remapping would stop being cons= idered. If that's not feasible, then I don't see this proposed patc= h as better. Users have already made do with the header-line transition in = 29 it sounds like.

Thank= s,
--000000000000ace10a0628ae1bde--