From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#30364: 26.0.91; thread crash on macos Date: Mon, 19 Feb 2018 12:16:51 -0800 Message-ID: References: <83inavbg3p.fsf@gnu.org> <83eflic32p.fsf@gnu.org> <83zi469rge.fsf@gnu.org> <83vaeu9mtn.fsf@gnu.org> <83o9km9jr5.fsf@gnu.org> <83inau9hqa.fsf@gnu.org> <83eflhac8i.fsf@gnu.org> <83mv0496dn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="94eb2c0b29f6e847ee0565965f9a" X-Trace: blaine.gmane.org 1519071417 1034 195.159.176.226 (19 Feb 2018 20:16:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Feb 2018 20:16:57 +0000 (UTC) Cc: 30364@debbugs.gnu.org, Alan Third , Noam Postavsky , Noam Postavsky , Andreas Schwab To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 19 21:16:52 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enrrg-0007os-0L for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Feb 2018 21:16:44 +0100 Original-Received: from localhost ([::1]:52201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enrth-0000FE-Up for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Feb 2018 15:18:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enrs2-0007cZ-JL for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 15:17:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enrry-0008Sy-BA for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 15:17:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1enrry-0008Sp-5x for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 15:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1enrrx-000177-Sn for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2018 15:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2018 20:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30364 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30364-submit@debbugs.gnu.org id=B30364.15190714194270 (code B ref 30364); Mon, 19 Feb 2018 20:17:01 +0000 Original-Received: (at 30364) by debbugs.gnu.org; 19 Feb 2018 20:16:59 +0000 Original-Received: from localhost ([127.0.0.1]:51683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enrrv-00016o-6G for submit@debbugs.gnu.org; Mon, 19 Feb 2018 15:16:59 -0500 Original-Received: from mail-qt0-f169.google.com ([209.85.216.169]:47044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enrrt-00016a-J0 for 30364@debbugs.gnu.org; Mon, 19 Feb 2018 15:16:58 -0500 Original-Received: by mail-qt0-f169.google.com with SMTP id u6so13718364qtg.13 for <30364@debbugs.gnu.org>; Mon, 19 Feb 2018 12:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6CG9uys7fX+OMLJT9fryuOQD7Z8V/rV00rc4kfLvVyY=; b=QTYRmfCOsHzqfAeIk/PVkahc5e8zKEuYVyXjnFoO+vBRSj9EcU5if4GSDkBtCxmQJe dn0v12ebacXIWp4ZqmNFlJ28p0WZVd8PafVHTqb/PmsS7g5LxiAnvljJv/I9hKs40zxE CXzNmj0+EfoOXfGBQcVmx5RMCIOSV71p2DvavSVlVPkZUS6YB9KtF5HifZHT2MPW2GPO AaGUkxcyQ1+l0RS8dRitn6Oalv2/ynyQftA6F38h2Ov/K7En9kUPPUVb3dTLAnPkwAMe cCl02gO42Kt94MGKYu9VrnhEGcyjzqlP76X5QyORRlzuBbo3XM+ZXCUUgNVHbKh4oViG /uEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6CG9uys7fX+OMLJT9fryuOQD7Z8V/rV00rc4kfLvVyY=; b=mX5fPgXWmmcENZ//f3lVOaTDhuKLFCIEHxXAcLyVyJhbeQuPiZXEdAUMgtAjOGvp/g QgTD3yq1XvFD1ffohEijpJehgTwXzIw06knnQ6r9qwa4ldWrKDQQZ7Bxq9zSNBitekGN O8IhG95s1GtfIsrx0/P4fTwTk7I9bUCHEqx1BGD0FPj4d2lCDa8HyiLBFvbu9UhIZLNa oWYdnPc2xTss2i/BELigTrer//DTrwYcWTcXgrs+YmKd1Z7gMpKgR6zwS4fXKDyf0fcB Eeft+bgsAvpAdiRyDPtlHShhNY311CiZ4N/DPGImsQb9tLp563PZGfsXmQUhCay88fE1 OMNA== X-Gm-Message-State: APf1xPCbU4EqcbKdU4VYp9X+byDr+EjRxn36V+aDxl+HjY3YyxUVG5JW OhB08rD6yJD4Ab7sJY7hxcv3YRF+WHmWP2Z/U4A= X-Google-Smtp-Source: AH8x225su74e/tlvfahMzG/aNuVhUt4mPFMWWG/uIo4bEKMuxH8Ly24BGOzDMEWvJC1Oi5faVtC0pbgkjOd6zkFSu8s= X-Received: by 10.200.27.122 with SMTP id p55mr26329136qtk.254.1519071412102; Mon, 19 Feb 2018 12:16:52 -0800 (PST) Original-Received: by 10.237.54.65 with HTTP; Mon, 19 Feb 2018 12:16:51 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144035 --94eb2c0b29f6e847ee0565965f9a Content-Type: text/plain; charset="UTF-8" On Mon, Feb 19, 2018 at 12:08 PM, Paul Eggert wrote: > x86-64 is not the only 64-bit platform; I suggest making REQUIRED_STACK_SIZE > equal to sizeof (void *) * 1024 * 1024. Also, no camelcase please. And why > fail merely because pthread_attr_setstacksize fails? Updated, thank you for the feedback. I'm mixed on failing when setstacksize fails, but it seems like the worst case is it'd create a thread w/ too small a stack size and it may crash on GC. Maybe that's better than failing outright on some platforms. Thanks, Aaron --94eb2c0b29f6e847ee0565965f9a Content-Type: application/octet-stream; name="0001-Require-a-larger-stack-size-for-threads-bug-30364.patch" Content-Disposition: attachment; filename="0001-Require-a-larger-stack-size-for-threads-bug-30364.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jduntgcn0 RnJvbSA3MTRiZWVlNThlMTg2MGExNGM4Nzk5MTVjNTdmYzgxZDg2YmQwNzY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAxOCBGZWIgMjAxOCAxMTo0Mzo0NyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJl cXVpcmUgYSBsYXJnZXIgc3RhY2sgc2l6ZSBmb3IgdGhyZWFkcyAoYnVnIzMwMzY0KQoKKiBzcmMv c3lzdGhyZWFkLmMgKHN5c190aHJlYWRfY3JlYXRlKTogUmVxdWlyZSBhdCBsZWFzdCA4TUIgc3Rh Y2sgc2l6ZQogIGZvciB4NjQgYW5kIDRNQiBmb3IgeDg2LgotLS0KIHNyYy9zeXN0aHJlYWQuYyB8 IDcgKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L3NyYy9zeXN0aHJlYWQuYyBiL3NyYy9zeXN0aHJlYWQuYwppbmRleCA0ZmZiN2RiMTQzLi5jMjky MzQzMzkyIDEwMDY0NAotLS0gYS9zcmMvc3lzdGhyZWFkLmMKKysrIGIvc3JjL3N5c3RocmVhZC5j CkBAIC05NCw2ICs5NCw4IEBAIHN5c190aHJlYWRfeWllbGQgKHZvaWQpCiAjaW5jbHVkZSA8c3lz L3ByY3RsLmg+CiAjZW5kaWYKIAorI2RlZmluZSBSRVFVSVJFRF9TVEFDS19TSVpFIHNpemVvZiAo dm9pZCAqKSAqIDEwMjQgKiAxMDI0CisKIHZvaWQKIHN5c19tdXRleF9pbml0IChzeXNfbXV0ZXhf dCAqbXV0ZXgpCiB7CkBAIC0xNjEsMTAgKzE2MywxNSBAQCBzeXNfdGhyZWFkX2NyZWF0ZSAoc3lz X3RocmVhZF90ICp0aHJlYWRfcHRyLCBjb25zdCBjaGFyICpuYW1lLAogewogICBwdGhyZWFkX2F0 dHJfdCBhdHRyOwogICBpbnQgcmVzdWx0ID0gMDsKKyAgc2l6ZV90IHN0YWNrX3NpemUgPSAwOwog CiAgIGlmIChwdGhyZWFkX2F0dHJfaW5pdCAoJmF0dHIpKQogICAgIHJldHVybiAwOwogCisgIGlm ICghcHRocmVhZF9hdHRyX2dldHN0YWNrc2l6ZSAoJmF0dHIsICZzdGFja19zaXplKSAmJgorICAg ICAgc3RhY2tfc2l6ZSA8IFJFUVVJUkVEX1NUQUNLX1NJWkUpCisgICAgcHRocmVhZF9hdHRyX3Nl dHN0YWNrc2l6ZSAoJmF0dHIsIFJFUVVJUkVEX1NUQUNLX1NJWkUpOworCiAgIGlmICghcHRocmVh ZF9hdHRyX3NldGRldGFjaHN0YXRlICgmYXR0ciwgUFRIUkVBRF9DUkVBVEVfREVUQUNIRUQpKQog ICAgIHsKICAgICAgIHJlc3VsdCA9IHB0aHJlYWRfY3JlYXRlICh0aHJlYWRfcHRyLCAmYXR0ciwg ZnVuYywgYXJnKSA9PSAwOwotLSAKMi4xNS4xCgo= --94eb2c0b29f6e847ee0565965f9a--