From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line Date: Sat, 10 Jun 2023 11:06:21 -0400 Message-ID: References: <831qij24qm.fsf@gnu.org> <83o7lnzhm5.fsf@gnu.org> <83mt17zcwn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20014"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63988@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 17:07:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q80BU-000514-O7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 17:07:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q80BE-0004ri-1b; Sat, 10 Jun 2023 11:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q80BC-0004rU-GO for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 11:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q80BC-0004rP-8E for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 11:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q80BB-00075I-Lj for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 11:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63988 X-GNU-PR-Package: emacs Original-Received: via spool by 63988-submit@debbugs.gnu.org id=B63988.168640960127204 (code B ref 63988); Sat, 10 Jun 2023 15:07:01 +0000 Original-Received: (at 63988) by debbugs.gnu.org; 10 Jun 2023 15:06:41 +0000 Original-Received: from localhost ([127.0.0.1]:36113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q80Ar-00074h-1z for submit@debbugs.gnu.org; Sat, 10 Jun 2023 11:06:41 -0400 Original-Received: from mail-pf1-f169.google.com ([209.85.210.169]:56823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q80Ao-00074T-TK for 63988@debbugs.gnu.org; Sat, 10 Jun 2023 11:06:40 -0400 Original-Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-655d1fc8ad8so2451109b3a.1 for <63988@debbugs.gnu.org>; Sat, 10 Jun 2023 08:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686409593; x=1689001593; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=umJ5wxNS2hQR5RqzzVrSXHoFTd7mfJEzTG+ADcPhzQc=; b=cUSQNyVORCgCaQykFLUNYPHJIlGnnK1HdghunRcd+QB2qz8q5K71LiH9CebxlYu9mQ MBufaCyuSQzJyq0tF6Cxtlev/V0ec8PG8cvZ1cNk4FG6xuAT96w3N9tERHyAPiMNkiRv HrVI0m+Yr+VxqOwv4cINe/Yn3cLs6SSXBphtfB3DQyEQmBWoXyP4ud0sy+ZzfvDivFgZ 0m6/UMKPvEKPwv7fTZTpCNzCwow+G/QBrtHEpX6MssP3uK8rEOf9wJQxsY7qJ71+0Wii CCK7+oNKNwX5IDO7pA+8w9w9+9f73pGeULJznvopPiOUtAQVD0XunEO7oZIF2/JcLy5M b+dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686409593; x=1689001593; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umJ5wxNS2hQR5RqzzVrSXHoFTd7mfJEzTG+ADcPhzQc=; b=JhOqQy5dJ4IgDvf4lT/BDMJ17hmMJs0fFV9lYvDHwwD7T2vCazOAksmDr3NqtAWvef v5MhAyvA0MyZaWH0eXdfcJBbwBKM6YVDFLh5dVsgXoe7bua3z7kV7jE3x+PV8bzLjber F0tBJpWrtoD1GcNvzSDPr+vNqkrlar1PWH1BHQ3hB2cszO8vUwNEtMLh8rSPUn+RMNsT UYo+tBOdbiSnIbv+Eit31JlQ3G28EwclqtBQLJKvlAQiG2i5M4UyWgzOK8sKlf5xkELs 1DuO96fjkSvkATn7YXfaAYiUeRYMBFTVVHhsKGcdq9SpG0zzd1gEF/QM+eYsmBqMECH3 71kQ== X-Gm-Message-State: AC+VfDxwRERShkJuZ8cRNASiXC0NF/HZxz2j8bPcEVvTf/ODVJbs+rRV w93kSrb6oCVYOjgKis323FDmSNR/V5cHPSq4wJc= X-Google-Smtp-Source: ACHHUZ5+/xxMN+wbU4th9TDZA9b1BzEjt+H8aXBvQq+9gYNkAYP+dq9/su28sv3jpShVVuYedMya7oR+znBaZAwbZxk= X-Received: by 2002:a05:6a20:1442:b0:114:28dc:2d94 with SMTP id a2-20020a056a20144200b0011428dc2d94mr5026914pzi.25.1686409592698; Sat, 10 Jun 2023 08:06:32 -0700 (PDT) In-Reply-To: <83mt17zcwn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263220 Archived-At: On Sat, Jun 10, 2023 at 9:04=E2=80=AFAM Eli Zaretskii wrote: > > > From: Aaron Jensen > > Date: Sat, 10 Jun 2023 07:59:30 -0400 > > Cc: 63988@debbugs.gnu.org > > > > > > > So maybe we should declare this feature a failed experiment and r= emove > > > > > it? > > > > > > > > I'll admit I don't really understand the change. Is it actually > > > > evaluating the cdr of the eval form up to two additional times to i= n > > > > order to determine whether or not to display the headerline at all? > > > > > > Only two? > > > > Well, 2 per render. I'm just guessing at reading the diff. > > window_wants_header_line is called in many other places as well. > > > I'd personally prefer performance to being able to hide the header > > line optionally > > What's wrong with setting header-line-format to nil? What I meant is that I have no use for this feature and that I'd rather be required to set it to nil to hide it. That's me personally though, I don't know the impetus for the original addition. > > though I still don't really understand the change and > > why the one time it's eval'd in order to get the actual text/format > > can't be used to determine whether or not to show the header line. > > Mainly because the window layout decisions need to know whether there > will be a header line before it's actually displayed. Ah, that makes sense.