From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sun, 8 Dec 2024 12:26:29 -0500 Message-ID: References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> <86jzcafcj6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006d781e0628c58c92" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, Eli Zaretskii , monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 08 18:28:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tKL54-0006qC-QQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Dec 2024 18:28:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKL4i-0008UL-OA; Sun, 08 Dec 2024 12:28:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKL4d-0008U5-Fv for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 12:28:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKL4d-00079S-7Z for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 12:28:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:References:In-Reply-To:From:Mime-Version:To:Subject; bh=yjXsa502WmPdzQIocXgpb2DG0FaIawr9TxmbCZZgWeg=; b=JLYLh/Lt8cojq5e0pDbqzKR9MMRTryBCM5pzvgFhV9ePOiCxkjSH9YzKZmPFc8JR9apkhfkBsSXUDky1pW/x2IWuLaM6sa8EBJQnxmL4mlKhsZcpNzrBGNJACGWFA5y+7UDB5M/OXaYYzVh3RKQyWyln8ucH12trwr8wafcUG/U8J57ew5zWsgJ/pbp2cTeerpO3WDd8YOamq8bsNn0EasPkpWkFloQH9YuszS+6ilIfkDyEZJCGAhu13WspsWu3KW2LEURMBO1FW09hSc70HaAb/EnMGTNhcjNMXlgIS0QZW1LROAWrsylh3SKF/giV/Z78hmP2FQ/EDdO847ffgg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKL4c-0004ob-1i for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 12:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173367886018471 (code B ref 73862); Sun, 08 Dec 2024 17:28:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 8 Dec 2024 17:27:40 +0000 Original-Received: from localhost ([127.0.0.1]:51559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKL4F-0004nq-DA for submit@debbugs.gnu.org; Sun, 08 Dec 2024 12:27:39 -0500 Original-Received: from mail-lj1-f175.google.com ([209.85.208.175]:46377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKL4C-0004nZ-7F for 73862@debbugs.gnu.org; Sun, 08 Dec 2024 12:27:37 -0500 Original-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-30167f4c1deso8346381fa.1 for <73862@debbugs.gnu.org>; Sun, 08 Dec 2024 09:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733678790; x=1734283590; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yjXsa502WmPdzQIocXgpb2DG0FaIawr9TxmbCZZgWeg=; b=gtjYqgsJBI2m0RtlO1GojZb66IFyp/MuAokMQQCusMTLeq+Y59RFpXuPLr6SA66I3k p6FB5WikHTruB9w2YQ6lD1BPndfdiLyLVEjo92fy8gdc0Rbubwt3Ur+e0+8MKitu+vT/ b9QE0ly4Qg3Qa5RoaHmWdwzML5DxeS+XqHXAXp4t8Mhe8MuYfZmRIWX7UC9AUDGLWzhg 9A59rblyrIO7raDIX2D3xBnmtvArHb2KOnnVc0896+0DkU01Vzo2RLtraKjFMpDi5dL5 iHNntFHVkii3mPY7BPkX0goaNe3MWg4594iEMq0cjv1wHjnmbsRuZ20dXuFfuYx3wHG6 bfvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733678790; x=1734283590; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yjXsa502WmPdzQIocXgpb2DG0FaIawr9TxmbCZZgWeg=; b=U8vOBM+j99ay4+DC4M5KE65p3E2Vj3LoNiQILBCcDg0PJE1wJWUwEEeUsHFfhlRaSe LpHPkMN12zl7oGL52QSAlhTw7RBKFoFFw3SZay7j2q2tdHPmKIIapmYcvQyZcNPk7lp/ +GBDKEXUXjDLrKJA0SXZF3ZV57SW7Em8xwnfA/vvExchwJz+kro71qNQ9j7jXj1yj6ac Q25eDpyFakpMibu5DvssIDi6RmmmyIUFasEv2tJ6vrUKRKUGnGTRU9fG/KO4UmLL5DtD zc++Wpmo9U9+Ta1pJ6u8w5CJu5lWjeoP26Z2UvBIxLUActcruK8vsmSK0aFrEKG3j5FG B4Dw== X-Forwarded-Encrypted: i=1; AJvYcCVD3gl2VQoWjScB3g7l8xJCke8fiakxeb2ABWKMlNwLKX5Tw9zXU26JXcHC/yXjsWCBR6Nvzg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwEahh4SFxWJmMuH3IwzqTD90kFoCkJsY+nE2HGNI8bGfdPJWoS 5DPN2ikYhAjnbo7tpdkmocdQ6nKlTyrpBS8u0V9O5pulMDzKTZbJP1x1lVJACs1LtnWVtOTdbZq agTVJ7VHCWlKlInLc6BguuT46NeE= X-Gm-Gg: ASbGnctcwoWl/tGOPbmDbf4yv15fCQ/Gamt+RMi90gIv9xzwOalORRvVa7hbQdfcDTG I3yXyQKQDbkLC278ilALOMLnMOm11hEscROP5ObyLNGolF8zaLnE3BT8= X-Google-Smtp-Source: AGHT+IFjVCEztWaSTHCmeN3ESpmiFCqd23RVaghghnTYyID/2Sbe6B7csz873aRjc7jZJMr+FqZBGORV/pZZkg4bjoQ= X-Received: by 2002:a2e:86da:0:b0:302:2620:ec89 with SMTP id 38308e7fff4ca-3022620ef1dmr408001fa.19.1733678789914; Sun, 08 Dec 2024 09:26:29 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sun, 8 Dec 2024 12:26:29 -0500 X-Mailer: Superhuman Desktop (2024-12-06T20:05:50Z) X-Superhuman-ID: m4fvkqnr.f9edd5a9-f0f4-491b-ac2b-afadc3a523ab X-Superhuman-Draft-ID: draft001c139085d92c11 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296652 Archived-At: --0000000000006d781e0628c58c92 Content-Type: text/plain; charset="UTF-8" On Sun, Dec 08, 2024 at 8:29 AM, Eshel Yaron wrote: > Eli Zaretskii writes: > > From: Eshel Yaron > Cc: Aaron Jensen , monnier@iro.umontreal.ca, > trevor.m.murphy@gmail.com, 73862@debbugs.gnu.org > Date: Sun, 08 Dec 2024 15:11:07 +0100 > > Eli Zaretskii writes: > > We also haven't yet heard from Eshel. > > I don't have any concrete suggestions at this point. It's surely a > complicated situation. > > Did you try the patch I posted, and if you did, did it resolve your > original problems? > > I did now, and it doesn't entirely solve the problem: with this patch, > after remapping header-line in one buffer, the remapping now works for that > buffer as expected, but it still also "spreads" to other buffers, which is > unexpected. > I see the leak now as well. When I tested it at first, I did not see it perhaps because I did not switch back to the original window and trigger a computation of the basic faces. That's what causes the leak. Steps: (setq header-line-format "Some header") (face-remap-set-base 'header-line 'highlight) (switch-to-buffer-other-window "new") ;; In new buffer/window: (setq header-line-format "Some header") (other-window) ;; In original buffer/window: (set-face-attribute 'default nil :height (+ (face-attribute 'default :height) 10)) Aaron --0000000000006d781e0628c58c92 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Dec 08, 2024 at 8:29 AM, Eshel Yaron <= /span><me@eshelyaron.com> wrote= :

Eli Zaretskii <= ;eliz@gnu.org> writes:

From: Eshel Yaron <me@eshelyaron.com>= ;
Cc: Aaron Jensen <aaronjensen@gmail.co= m>, monnier@iro.umontreal.= ca, trevor.m.murphy@gmail.com, 73862@debbugs.gnu.org
Date: Sun, 08 Dec 20= 24 15:11:07 +0100

Eli Zaretskii <eliz@gnu.org> writes:

We also haven't yet heard from Eshel.

I don't have any concrete suggestions at this point. It's surely a complicated situation.

Did you try the patch I posted, and if you did, did it resolve your original problems? =20

I did now, and it doesn't entirely solve the problem: with this patch, after remapping header-line in one buffer, the remapping now works for that buffer as expected, but it still also "spreads" to other buf= fers, which is unexpected.


I see the leak = now as well. When I tested it at first, I did not see it perhaps because I = did not switch back to the original window and trigger a computation=C2=A0o= f the basic faces. That's what causes the leak.

Steps:

(setq header-line-format "Some header")
(face-remap-set-base 'header-line 'highlight)
<= /div>
(switch-to-buffer-other-window "new")
;; In new buffer/window:
(setq header-line-format "Some header")
(other-window)
;; In original buffer/w= indow:
(set-face-attribute 'default nil :height (+ (face-attr= ibute 'default :height) 10))

Aaron
--0000000000006d781e0628c58c92--