From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Mon, 5 Nov 2018 08:11:29 -0800 Message-ID: References: <83tvl0hdn6.fsf@gnu.org> <20181101225519.GA40584@breton.holly.idiocy.org> <837ehufqxw.fsf@gnu.org> <20181103203635.GB41015@breton.holly.idiocy.org> <83muqpeuw0.fsf@gnu.org> <20181104132404.GA58336@breton.holly.idiocy.org> <20181104201148.GA70884@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541434653 14671 195.159.176.226 (5 Nov 2018 16:17:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2018 16:17:33 +0000 (UTC) Cc: boris@d12frosted.io, 32932@debbugs.gnu.org To: Eli Zaretskii , Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 05 17:17:29 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJhZA-0003hP-Mu for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2018 17:17:29 +0100 Original-Received: from localhost ([::1]:36018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhbG-0005Nt-Jz for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2018 11:19:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhaT-0003QM-0P for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 11:18:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJhTu-0008CW-7l for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 11:12:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59447) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJhTu-0008CM-3Z for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 11:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gJhTt-0004ZJ-Ox for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 11:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Nov 2018 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154143431017542 (code B ref 32932); Mon, 05 Nov 2018 16:12:01 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 5 Nov 2018 16:11:50 +0000 Original-Received: from localhost ([127.0.0.1]:35472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJhTi-0004Ys-1A for submit@debbugs.gnu.org; Mon, 05 Nov 2018 11:11:50 -0500 Original-Received: from mail-yb1-f177.google.com ([209.85.219.177]:37989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJhTb-0004YV-VU for 32932@debbugs.gnu.org; Mon, 05 Nov 2018 11:11:44 -0500 Original-Received: by mail-yb1-f177.google.com with SMTP id u103-v6so2456811ybi.5 for <32932@debbugs.gnu.org>; Mon, 05 Nov 2018 08:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=CosjlIJcKA1VamTl8DXUCHlhA59ARjHfyeix31KGX4A=; b=Q/T5VRmNUbPpQSHTab80388D2B/bsedBG35Z5Aat6BG9XC07T/bx6XIgMd/eGCCk/j dDhkYDcq1JLgREyMv3P5kioHLJUnOgghOeeYfSaruHWbvactxba2mwyJKIG7mAumkUaP sTUBfbZkiDC1T9iirgrqF439w6juuPP9aMMmxVIC2LP6dWeNhgltXkwU67uZqz1KG7eu /kNk/S+vxx2Dp/ahPMsx7Lb5NliSOoM2uIzahixqTv0c2WYvvBCpiZMZpTu98a44JaBk J//eeQZ/zhXv8DjNzDPp1Dq4LIAuMfwIXzIB6gWoIP0BeTjgGCV9Y02rrpmIw4gBSln8 Cx4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=CosjlIJcKA1VamTl8DXUCHlhA59ARjHfyeix31KGX4A=; b=Y1jNVvN2UYd7ybmxHcS7GnNka5YQSdTaVr6j4cKVifGUD46wjy9FW6Lg7KYWMq4qiF cnGarA1aG64uNg9KIozOl+9nTJhv3Mv5HULcHXGcEjRR6xNvSVJ1RvkRDZQKIfgs7MmL fT9kPddiHNRXlr5TsDyeo7GyNxYKeRWdWltxnTjtBPD4MMXCuoPdClV7FEv89J/ncTuu OxENqKYeDOYX5q2Zq6PAuj62+abmM47P0mBo3p9KD6wK0mtV1pxccbO2rWiKlTiHdu38 lXR5yZhiXwBEuIzRLWyYOAWF5Z/x3XJn29FthA8uowqbIQRyplhirj14Ann7JzUHIjMd VQ1A== X-Gm-Message-State: AGRZ1gLTpCEh2ZqVeoLeeSCRHlFuy5zPuttWh2hBrLBrxz/CuU0qcRId 7m138wJ24sFkLuBNJiF5+mC/bsqCt+F+hw0Z3H1C0Uq2 X-Google-Smtp-Source: AJdET5fwUkwXsmsnq1go01wctlon6JkSyWk4ayUGN+Y187UIM8Otic1fQhXTefgZhHq1vS3cfGwo9Y2ha5wvxQIGShs= X-Received: by 2002:a25:ef10:: with SMTP id g16-v6mr21440935ybd.164.1541434298297; Mon, 05 Nov 2018 08:11:38 -0800 (PST) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Mon, 5 Nov 2018 08:11:29 -0800 In-Reply-To: <20181104201148.GA70884@breton.holly.idiocy.org> X-Mailer: Airmail (528) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152057 Archived-At: On November 4, 2018 at 12:11:52 PM, Alan Third (alan@idiocy.org(mailto:alan@idiocy.org)) wrote: > After thinking about this for a while I realised that what we probably > need to do is just make sure the frame is updated before redisplay > starts changing it. > > This seems to work here: > > modified src/nsterm.m > @@ -1061,6 +1061,17 @@ static NSRect constrain_frame_rect(NSRect frameRec= t, bool isFullscreen) > > ns_update_auto_hide_menu_bar (); > > + /* Flush any existing changes to screen before redisplay gets going. > + If we don't do this then it's possible for redisplay to mark > + areas as garbaged so they won't be redrawn in the next drawRect > + call. > + > + Is this a bad thing to do since we're effectively calling > + frame_expose from within redisplay? */ > + block_input (); > + [FRAME_NS_VIEW (f) displayIfNeeded]; > + unblock_input (); > + > if ([view isFullscreen] && [view fsIsNative]) > { > // Fix reappearing tool bar in fullscreen for Mac OS X 10.7 That works for me as well for my repro. I=E2=80=99ll try it out for a while and report back if I notice any issues. Thanks, Aaron