From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#30141: (26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes) Date: Wed, 17 Jan 2018 03:50:24 -0800 Message-ID: References: <5A5F1397.2050001@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a1135a05af5c4d50562f77398" X-Trace: blaine.gmane.org 1516189770 10014 195.159.176.226 (17 Jan 2018 11:49:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 17 Jan 2018 11:49:30 +0000 (UTC) To: martin rudalics , 30141@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 17 12:49:26 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebmDQ-0001Uk-Fn for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jan 2018 12:49:12 +0100 Original-Received: from localhost ([::1]:58044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebmFQ-0007p8-2Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jan 2018 06:51:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebmFH-0007oW-7M for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 06:51:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebmFE-00070j-3o for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 06:51:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebmFD-00070V-Ut for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 06:51:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebmFC-0005C3-8S for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2018 06:51:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jan 2018 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30141-submit@debbugs.gnu.org id=B30141.151618983319926 (code B ref 30141); Wed, 17 Jan 2018 11:51:02 +0000 Original-Received: (at 30141) by debbugs.gnu.org; 17 Jan 2018 11:50:33 +0000 Original-Received: from localhost ([127.0.0.1]:59489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebmEi-0005BK-Rh for submit@debbugs.gnu.org; Wed, 17 Jan 2018 06:50:33 -0500 Original-Received: from mail-qk0-f170.google.com ([209.85.220.170]:40171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebmEh-0005B8-4P for 30141@debbugs.gnu.org; Wed, 17 Jan 2018 06:50:31 -0500 Original-Received: by mail-qk0-f170.google.com with SMTP id d18so24854676qke.7 for <30141@debbugs.gnu.org>; Wed, 17 Jan 2018 03:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=clcpG/kpD+sdE6Jy7a8tm/K4L7S3Maef5DpH5ctMjnE=; b=LG26JlGpWRfIoHK6BY2FuOzsMcfjKxfNeZsTEudV8ApgdEIzAWj3GletoX6zuChvZi bDiGX444NIdKfzXcTCV4R0rAdYddGbwi4BZjL8GEdGlDBs8uFpa69NICAspVdll/iVIm +LpAI40xwxB2KfWKmtZ9uQ8DNX9y0SpmyvK9UIKo6KSI0qGuZwl50v9i8SU6e+x8h4i0 sZ3qj/Rk/KHGZEX/uaBwZC8cfUX9YcVXt1BhmAJoII40fY8r4n8VzOR4RXg4zDqvHRZx 4nkmnVbs6yNZv/TC27p9UeVg8+JPAAgmLSrq1u1uIq6wWAq7TrZ96HKqpKYhGNZ3VeN6 6LqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=clcpG/kpD+sdE6Jy7a8tm/K4L7S3Maef5DpH5ctMjnE=; b=BGZifr8+SHyFJzF4BbF5MFigw0dbHjiEbF3VXLP2owdDurUT6a7KiR/MYz8IxJim/h HlpgqXAaL2JnUNIIGowTaynbleF/WeIXtlRzl6zte/rb3XxxKvoc8wqIB0Zb6yu8cfm7 eP5ZqL568llcfQD+9ZV/JaQzo9uCPgC1ThVCYgciCl920vOxOzbsib+GcPX/24tc9sOx AyVrMHB0LeB++UGDMFFfLNSZF9mEsZ4t3IHL9fNCMq3mmxmQmHFk5y7sQOIe+zBGvq9g 2p78wEot5RFOueUf5Gh4Ulhlu4/GJzxrpb37f0kK4k911diioGTC/mACy7xWBwJ2KDi7 ixxw== X-Gm-Message-State: AKwxytexAzbZcdGrjH7HPTh5ygyohc6QO7MCbXP5w/LIiVSaSFG5F8V2 CNvcHm3BxT3TcpJYEE/fr0f6dyNCenoXNOgAMM4= X-Google-Smtp-Source: ACJfBotqqkE7K2wEr3lJ0reYrcb1EPCqwFd15lI0gbg/4rvppgWLEYE9A1e/KfplSgIUWym7OaVVi80A9u+N8nuS/Js= X-Received: by 10.55.16.38 with SMTP id a38mr58544020qkh.61.1516189825465; Wed, 17 Jan 2018 03:50:25 -0800 (PST) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Wed, 17 Jan 2018 03:50:24 -0800 In-Reply-To: <5A5F1397.2050001@gmx.at> X-Mailer: Airmail (467) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142223 Archived-At: --001a1135a05af5c4d50562f77398 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable From: martin rudalics (mailto:rudalics@gmx.at) > Doesn't look wrong to me. But if we use it we'd have to change the > comment below: Updated patch attached. I tried out a naive approach to filtering (filter out all frameset-- params when restoring) and it broke on the mini buffer restoring, though I didn=E2=80=99t debug the exact issue. Reading over the code makes me wonder if I put the text pixel width/height saving code in the wrong place, frameset--record-relationships, as it is named, seems to be more about the relationships between frames. Tossing in pixel sizing in there is a bit misplaced probably. Maybe it would be more appropriate to add a custom width/height filter that would save the text pixel width/height while filtering. Either way, this patch fixes a bug so it is probably worth applying if you=E2=80=99re good with it. Thanks, Aaron --001a1135a05af5c4d50562f77398 Content-Type: application/octet-stream; name=patch2 Content-Disposition: attachment; filename=patch2 Content-Transfer-Encoding: base64 X-Attachment-Id: 6e6c12f256917f69_0.1 ZGlmZiAtLWdpdCBhL2xpc3AvZnJhbWVzZXQuZWwgYi9saXNwL2ZyYW1lc2V0LmVsCmluZGV4IDNm YjY5MDFlOTQuLmY5ZTNiNjg5ZmIgMTAwNjQ0Ci0tLSBhL2xpc3AvZnJhbWVzZXQuZWwKKysrIGIv bGlzcC9mcmFtZXNldC5lbApAQCAtMjMwLDExICsyMzAsMTAgQEAgZnJhbWVzZXQtcHJvcAogOzsg ZmlsdGVyaW5nIGZ1bmN0aW9ucykgaXMgY29waWVkIHRvIEZJTFRFUkVEIGFzIGlzLiAgS2V5d29y ZCB2YWx1ZXMgOnNhdmUsCiA7OyA6cmVzdG9yZSBhbmQgOm5ldmVyIHRlbGwgdGhlIGZ1bmN0aW9u IHRvIGNvcHkgQ1VSUkVOVCB0byBGSUxURVJFRCBpbiB0aGUKIDs7IHJlc3BlY3RpdmUgc2l0dWF0 aW9ucywgdGhhdCBpcywgd2hlbiBzYXZpbmcsIHJlc3RvcmluZywgb3IgbmV2ZXIgYXQgYWxsLgot OzsgVmFsdWVzIDpzYXZlIGFuZCA6cmVzdG9yZSBhcmUgbm90IHVzZWQgaW4gdGhpcyBwYWNrYWdl LCBiZWNhdXNlIHVzdWFsbHkgaWYKLTs7IHlvdSBkb24ndCB3YW50IHRvIHNhdmUgYSBwYXJhbWV0 ZXIsIHlvdSBkb24ndCB3YW50IHRvIHJlc3RvcmUgaXQgZWl0aGVyLgotOzsgQnV0IHRoZXkgY2Fu IGJlIHVzZWZ1bCwgZm9yIGV4YW1wbGUsIGlmIHlvdSBhbHJlYWR5IGhhdmUgYSBzYXZlZCBmcmFt ZXNldAotOzsgY3JlYXRlZCB3aXRoIHNvbWUgaW50ZW50LCBhbmQgd2FudCB0byByZXVzZSBpdCBm b3IgYSBkaWZmZXJlbnQgb2JqZWN0aXZlCi07OyB3aGVyZSB0aGUgZXhwZWN0ZWQgcGFyYW1ldGVy IGxpc3QgaGFzIGRpZmZlcmVudCByZXF1aXJlbWVudHMuCis7OyBWYWx1ZXMgOnNhdmUgYW5kIDpy ZXN0b3JlIGNhbiBiZSB1c2VmdWwsIGZvciBleGFtcGxlLCBpZiB5b3UgYWxyZWFkeQorOzsgaGF2 ZSBhIHNhdmVkIGZyYW1lc2V0IGNyZWF0ZWQgd2l0aCBzb21lIGludGVudCwgYW5kIHdhbnQgdG8g cmV1c2UgaXQgZm9yCis7OyBhIGRpZmZlcmVudCBvYmplY3RpdmUgd2hlcmUgdGhlIGV4cGVjdGVk IHBhcmFtZXRlciBsaXN0IGhhcyBkaWZmZXJlbnQKKzs7IHJlcXVpcmVtZW50cy4KIDs7CiA7OyBG aW5hbGx5LCB0aGUgdmFsdWUgY2FuIGFsc28gYmUgYSBmaWx0ZXJpbmcgZnVuY3Rpb24sIG9yIGEg ZmlsdGVyaW5nCiA7OyBmdW5jdGlvbiBwbHVzIHNvbWUgYXJndW1lbnRzLiAgVGhlIGZ1bmN0aW9u IGlzIGNhbGxlZCBmb3IgZWFjaCBtYXRjaGluZwpAQCAtNDQyLDMyICs0NDEsMzQgQEAgZnJhbWVz ZXQtc2Vzc2lvbi1maWx0ZXItYWxpc3QKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdmFyIGZyYW1lc2V0 LXBlcnNpc3RlbnQtZmlsdGVyLWFsaXN0CiAgIChuY29uYwotICAgJygoYmFja2dyb3VuZC1jb2xv ciAgIC4gZnJhbWVzZXQtZmlsdGVyLXNhbml0aXplLWNvbG9yKQotICAgICAoYnVmZmVyLWxpc3Qg ICAgICAgIC4gOm5ldmVyKQotICAgICAoYnVmZmVyLXByZWRpY2F0ZSAgIC4gOm5ldmVyKQotICAg ICAoYnVyaWVkLWJ1ZmZlci1saXN0IC4gOm5ldmVyKQorICAgJygoYmFja2dyb3VuZC1jb2xvciAg ICAgICAgICAgIC4gZnJhbWVzZXQtZmlsdGVyLXNhbml0aXplLWNvbG9yKQorICAgICAoYnVmZmVy LWxpc3QgICAgICAgICAgICAgICAgIC4gOm5ldmVyKQorICAgICAoYnVmZmVyLXByZWRpY2F0ZSAg ICAgICAgICAgIC4gOm5ldmVyKQorICAgICAoYnVyaWVkLWJ1ZmZlci1saXN0ICAgICAgICAgIC4g Om5ldmVyKQogICAgICA7OyBEb24ndCBzYXZlIHRoZSAnY2xpZW50JyBwYXJhbWV0ZXIgdG8gYXZv aWQgdGhhdCBhIHN1YnNlcXVlbnQKICAgICAgOzsgYHNhdmUtYnVmZmVycy1raWxsLXRlcm1pbmFs JyBpbiBhIG5vbi1jbGllbnQgc2Vzc2lvbiBiYXJrcyBhdAogICAgICA7OyB0aGUgdXNlciAoQnVn IzI5MDY3KS4KLSAgICAgKGNsaWVudCAgICAgICAgICAgICAuIDpuZXZlcikKLSAgICAgKGRlbGV0 ZS1iZWZvcmUgICAgICAuIDpuZXZlcikKLSAgICAgKGZvbnQgICAgICAgICAgICAgICAuIGZyYW1l c2V0LWZpbHRlci1mb250LXBhcmFtKQotICAgICAoZm9yZWdyb3VuZC1jb2xvciAgIC4gZnJhbWVz ZXQtZmlsdGVyLXNhbml0aXplLWNvbG9yKQotICAgICAoZnVsbHNjcmVlbiAgICAgICAgIC4gZnJh bWVzZXQtZmlsdGVyLXNoZWx2ZS1wYXJhbSkKLSAgICAgKEdVSTpmb250ICAgICAgICAgICAuIGZy YW1lc2V0LWZpbHRlci11bnNoZWx2ZS1wYXJhbSkKLSAgICAgKEdVSTpmdWxsc2NyZWVuICAgICAu IGZyYW1lc2V0LWZpbHRlci11bnNoZWx2ZS1wYXJhbSkKLSAgICAgKEdVSTpoZWlnaHQgICAgICAg ICAuIGZyYW1lc2V0LWZpbHRlci11bnNoZWx2ZS1wYXJhbSkKLSAgICAgKEdVSTp3aWR0aCAgICAg ICAgICAuIGZyYW1lc2V0LWZpbHRlci11bnNoZWx2ZS1wYXJhbSkKLSAgICAgKGhlaWdodCAgICAg ICAgICAgICAuIGZyYW1lc2V0LWZpbHRlci1zaGVsdmUtcGFyYW0pCi0gICAgIChvdXRlci13aW5k b3ctaWQgICAgLiA6bmV2ZXIpCi0gICAgIChwYXJlbnQtZnJhbWUgICAgICAgLiA6bmV2ZXIpCi0g ICAgIChwYXJlbnQtaWQgICAgICAgICAgLiA6bmV2ZXIpCi0gICAgIChtb3VzZS13aGVlbC1mcmFt ZSAgLiA6bmV2ZXIpCi0gICAgICh0dHkgICAgICAgICAgICAgICAgLiBmcmFtZXNldC1maWx0ZXIt dHR5LXRvLUdVSSkKLSAgICAgKHR0eS10eXBlICAgICAgICAgICAuIGZyYW1lc2V0LWZpbHRlci10 dHktdG8tR1VJKQotICAgICAod2lkdGggICAgICAgICAgICAgIC4gZnJhbWVzZXQtZmlsdGVyLXNo ZWx2ZS1wYXJhbSkKLSAgICAgKHdpbmRvdy1pZCAgICAgICAgICAuIDpuZXZlcikKLSAgICAgKHdp bmRvdy1zeXN0ZW0gICAgICAuIDpuZXZlcikpCisgICAgIChjbGllbnQgICAgICAgICAgICAgICAg ICAgICAgLiA6bmV2ZXIpCisgICAgIChkZWxldGUtYmVmb3JlICAgICAgICAgICAgICAgLiA6bmV2 ZXIpCisgICAgIChmb250ICAgICAgICAgICAgICAgICAgICAgICAgLiBmcmFtZXNldC1maWx0ZXIt Zm9udC1wYXJhbSkKKyAgICAgKGZvcmVncm91bmQtY29sb3IgICAgICAgICAgICAuIGZyYW1lc2V0 LWZpbHRlci1zYW5pdGl6ZS1jb2xvcikKKyAgICAgKGZyYW1lc2V0LS10ZXh0LXBpeGVsLWhlaWdo dCAuIDpzYXZlKQorICAgICAoZnJhbWVzZXQtLXRleHQtcGl4ZWwtd2lkdGggIC4gOnNhdmUpCisg ICAgIChmdWxsc2NyZWVuICAgICAgICAgICAgICAgICAgLiBmcmFtZXNldC1maWx0ZXItc2hlbHZl LXBhcmFtKQorICAgICAoR1VJOmZvbnQgICAgICAgICAgICAgICAgICAgIC4gZnJhbWVzZXQtZmls dGVyLXVuc2hlbHZlLXBhcmFtKQorICAgICAoR1VJOmZ1bGxzY3JlZW4gICAgICAgICAgICAgIC4g ZnJhbWVzZXQtZmlsdGVyLXVuc2hlbHZlLXBhcmFtKQorICAgICAoR1VJOmhlaWdodCAgICAgICAg ICAgICAgICAgIC4gZnJhbWVzZXQtZmlsdGVyLXVuc2hlbHZlLXBhcmFtKQorICAgICAoR1VJOndp ZHRoICAgICAgICAgICAgICAgICAgIC4gZnJhbWVzZXQtZmlsdGVyLXVuc2hlbHZlLXBhcmFtKQor ICAgICAoaGVpZ2h0ICAgICAgICAgICAgICAgICAgICAgIC4gZnJhbWVzZXQtZmlsdGVyLXNoZWx2 ZS1wYXJhbSkKKyAgICAgKG91dGVyLXdpbmRvdy1pZCAgICAgICAgICAgICAuIDpuZXZlcikKKyAg ICAgKHBhcmVudC1mcmFtZSAgICAgICAgICAgICAgICAuIDpuZXZlcikKKyAgICAgKHBhcmVudC1p ZCAgICAgICAgICAgICAgICAgICAuIDpuZXZlcikKKyAgICAgKG1vdXNlLXdoZWVsLWZyYW1lICAg ICAgICAgICAuIDpuZXZlcikKKyAgICAgKHR0eSAgICAgICAgICAgICAgICAgICAgICAgICAuIGZy YW1lc2V0LWZpbHRlci10dHktdG8tR1VJKQorICAgICAodHR5LXR5cGUgICAgICAgICAgICAgICAg ICAgIC4gZnJhbWVzZXQtZmlsdGVyLXR0eS10by1HVUkpCisgICAgICh3aWR0aCAgICAgICAgICAg ICAgICAgICAgICAgLiBmcmFtZXNldC1maWx0ZXItc2hlbHZlLXBhcmFtKQorICAgICAod2luZG93 LWlkICAgICAgICAgICAgICAgICAgIC4gOm5ldmVyKQorICAgICAod2luZG93LXN5c3RlbSAgICAg ICAgICAgICAgIC4gOm5ldmVyKSkKICAgIGZyYW1lc2V0LXNlc3Npb24tZmlsdGVyLWFsaXN0KQog ICAiUGFyYW1ldGVycyB0byBmaWx0ZXIgZm9yIHBlcnNpc3RlbnQgZnJhbWVzZXRzLgogRE8gTk9U IE1PRElGWS4gIFNlZSBgZnJhbWVzZXQtZmlsdGVyLWFsaXN0JyBmb3IgYSBmdWxsIGRlc2NyaXB0 aW9uLiIpCg== --001a1135a05af5c4d50562f77398--